Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Submitting public character sheet problem

1620678735
Divers
Pro
Sheet Author
I am trying to submit my first public charcater sheet on github, but this failed. I have Pro subscription, a github account, I did fork, clone, branch, add ., commit, push, and everything went ok, until the pull request Error message : "All checks have failed 1 failing check @roll20deploy Character Sheet Validation — Pull Request failed to validate. Correct errors below." Is there a way to know why did it fail ? What should I correct ? Thanks for any help.
1620679273

Edited 1620681051
Andreas J.
Forum Champion
Sheet Author
Translator
That always happen with new sheets, it's too bad that it doesn't clearly state that's the error for contributors. This is a fairly common source of confusion. If you go and look at the other currently active PRs, you see that none that are tagged as "New Sheet" have passed all checks.
1620680409
Divers
Pro
Sheet Author
Thanks! I understand that I should delete this PR and submit another PR without specifying it's a new sheet ? 
1620680825
Andreas J.
Forum Champion
Sheet Author
Translator
No, dont touch anything, everything is normal. Just let it sit, wait for a human reply.
1620681114

Edited 1620681394
Divers
Pro
Sheet Author
oups, I went too fast :-/ I will reopen it. And be more patient. Thank you !!
1621242986
Divers
Pro
Sheet Author
Hello, does anyone know how long is it for roll20 to check for a merge request ? => I have submitted a push of my fork/branch to "master branch", of a new character sheet, for a game not yet implemented in roll20.
1621247930
David
Sheet Author
Divers said: Hello, does anyone know how long is it for roll20 to check for a merge request ? => I have submitted a push of my fork/branch to "master branch", of a new character sheet, for a game not yet implemented in roll20. For new sheets and certain other issues there is no timescale.
1621248318
Divers
Pro
Sheet Author
ok, thanks :-) And for previous new sheets ? is it weeks ? months ? ages ? ;-)
1621249057

Edited 1621251464
Andreas J.
Forum Champion
Sheet Author
Translator
TL;DR: They will likely check your sheet in the next two days, nothing to worry about. Slightly longer wait than usual. Usually Roll20 merges sheet updates 1-2 times a week, and approved new sheets slightly less often, about once a week. Currently, there are a total of 36 other pull requests waiting in the repository for review/approval, so it seems for the last week they skipped doing any merges/reviews of new sheet for some reason, while still merging some updates. Your PR have the bad luck of being the second-oldest, submitted 7 days ago, and there is another PR that's 8 days old. While Roll20 seems to have merged sheet updates last week, it was only a few that seems like just small fixes, so guess they didn't have the time to review all larger update or new sheets. I'm pretty sure they will go through the accumulated PRs in the next few days, and at least merge the sheet updates quickly, but I've noticed a tendency for them to process & merge new sheet submissions last, sometime even leaving new sheets to be merged some day later. There are extra steps involved in adding new sheets to the system, so it's understandable that they take slightly more time than just updates to existing sheets. At this point, I feel like I should write a guide on the sheet submission process, and specifically on the behaviour of the repo maintainer. Yes, they should be doing reviews/updates 1-2 times a week, but realistically that doesn't happen every single week, and delays happen sometimes, for what ever reason. Every time when Roll20 don't adhere to a clockwork timetable of 1-merge-a-week, there is almost always someone posting wondering why the merges haven't been done, even if they might be off with just a few days from their regular schedule. You're completely reasonable to start wondering after 7 days have passed, but I hope you realize they probably don't work during the weekend on non-critical issues like this, it's more practical to think it from a perspective of how many business days have passed, which is still 5, since Monday workday haven't started even for the early bird in US, where the company is located. Divers said: And for previous new sheets ? is it weeks ? months ? ages ? ;-) It's never been more than 3 weeks for new sheet, basically ever. Realistically , based on my observation of the last half a year or so, the wait for a new sheet to get approved is 1-2 weeks , while on occasions you get lucky and it happens in under a week. That is, if there is no issues with the sheet that would obviously cause delays, but this isn't the issue as they haven't reviewed the sheet yet, they will always provide feedback if something on your end is holding things back. The kicker? It's not even Monday morning yet in US, where most Roll20 employees are located, so even the earliest Roll20 employees haven't woken up on the East Coast. It's entirely possible your sheet gets reviewed & merged in about 6-8 hours, when they actually have people on the clock. During weekends & nights they don't really have people working on non-critical parts of the platform. Sorry for the rant, but I just realized once again I really should write a guide on this, so just wrote out general things on this that often comes up when people comes with questions, and somewhat over-explaining the situation for you. The Readme in the repository & the Github Guide only explains how to do submit sheet updates or new sheets , but doesn't explain what to expect, the timeline, or common obstacles . I'll use parts of this post as basis for the guide, and include a FAQ section so it can be referenced in the future, both regarding new sheet submissions, and on sheet updates.
1621254182
Divers
Pro
Sheet Author
Great !! It explains what I should expect. #sittingandpressingf5 ;-) Thanks Andreas once again
1621285110
Divers
Pro
Sheet Author
It' online :-) Great ! But... well... it doesn't appear as in the sandbox... I am opening another thread for this new issue
1621287350
Andreas J.
Forum Champion
Sheet Author
Translator
hm, your mistake was in the sheet.json to put legacy=true , even though you did the sheet using the new format. change that in a pr and it should get fixed. Had you tested your sheet.json in the Sheet Sandbox , you would have noticed. In general, it's better to test & develop sheets in general.
1621372832
Divers
Pro
Sheet Author
oh, great ! I didn't know that would have an impact on this. Thanks again ! :-)
1621375172
Divers
Pro
Sheet Author
I changed legacy=true to legacy=false. And submitted a PR. This should fix my styling bug.