One Click requests?

Good morning. I got my API to the point where I think it can support general use and hopefully got it branched and correctly submitted for one-click. How long does the review generally take? In case it affects the answer, it's what I would call medium complexity code (maybe 12-15 functions), a little over 1k lines and it's purpose is character sheet importing. - Ernie

There isn't much in the way of "review". There is some JSON validation which happens immediately (pass/fail), and then occasionally there is an overt issue of the file or submission package that the R20 team might catch, but they don't do a line-level code audit. If your submission doesn't fail JSON validation and the R20 staff in charge of performing the merge notice that you want your script into the 1-click, then you only have to wait for the merge -- which I think they aim to do on Tuesdays.

Are you eepjr24?  You should have all your changes in one pull request.  If you are taking over maintaining an existing script, you should append your information, rather than replacing the original author's. Try not to upload any extraneous files.  I don't think that .hde file is necessary.

I thought I did. Not taking anything over, if I replaced something from another author it was during a copy paste and I screwed something up. All the changes should be in the ImportHS6e subdirectory, anything else is an error on my part. The hde file is necessary for the character sheet to be generated in the source program (Hero Designer). If I can't maintain that here I will end up sending everyone to another github which kind of defeats the purpose? - E

Should be fine to leave the .hde there if it makes sense to your potential users and doesn't contain any proprietary information that is outside the licensing for Hero System stuff. This is the second pull request and the one where the prior author seems to have been omitted:&nbsp; <a href="https://github.com/Roll20/roll20-api-scripts/pull/1290" rel="nofollow">https://github.com/Roll20/roll20-api-scripts/pull/1290</a> &nbsp; (unless you just changed users and user names)

The one you just linked was done in error. Can I simply close the pull request or do I need to submit a request to have it removed? - E

One thing you might want to change, Ernest... your line offset for error tracking looks like it was never updated to your positioning of the thrown error. At your line 23, you have this: try { throw new Error(''); } catch (e) { API_Meta.ImportHS6e.offset = (parseInt(e.stack.split(/\n/)[1].replace(/^.*:(\d+):.*$/, '$1'), 10) - (13)); } That 13 at the end that you are subtracting should represent the line number of the line where this error is thrown (in effect, subtracting your way back to line "0" of this portion of the consolidated scripts for a game. So you probably want to change that to 23 before this file gets merged in. =D

You can just close it, it will go away. =D

Thanks, Tim, fixed. Thanks, Aaron, closed. - E