Sheetworkers and Drop Menus

Ok, what's the issue you are running into?

1622571260

Pro

It doesn't set the damage.

1622573479

Scott C.

Forum Champion

Sheet Author

API Scripter

Compendium Curator

Ok, a couple things I notice. It is possible, actually very likely, to have modifier never set. This then results in modifier being undefined, and will cause setAttrs  to error out. You'll see this if you watch the developer console while working with your sheet. This is probably causing your problem because when setAttrs errors out in this way, it also corrupts the attribute that it was trying to set and makes it unchangeable by the sheetworker until a refresh. I'd recommend wrapping your setAttrs  in an if: if(modifier){     setAttrs({weapondmg_1:modifier}); }  And, just some general code critique. ==  is technically correct, but really ===  should be used instead. The full reasoning is admittedly a little beyond my code knowledge. The tldr though is that ==  (and != ) coerce the variable on the right side to match the type of the variable on the left side. While this seems like it is preferable, it has some odd effects where things you think would be equivalent aren't, and vice versa. Additionally, this behavior can depend on what type is on the left or right of the comparison. To ensure that you get consistent behavior, ===  (and !== ) are the preferred comparison methods as they compare the types rather than coercing them to be the same. This stack overflow thread has some good descriptions of the problems you can run into.

1622574212

keithcurtis

Forum Champion

Marketplace Creator

API Scripter

One of my favorite the Aaron quotes: You'll always want to use "===" until you learn the difference between "==" and "===". And then you'll always want to use "===".

1622583801

Pro

Sheet Author

API Scripter

Another thing you can do that is handy is (when setting values that are going to be used in setAttrs) is never do this: let modifier; But instead always set a default value that is valid, like let modifier = "1d6"; or something that will show the user there is a problem, like let modifier = "N/A"; When you letter set the modifier, you overwrite that default value, but having a default value that is invalid, you can see if something isn't being set properly. You can also combine it with CSS to change the HTML attribute's colour to read, or something, when it equals the default value. Again, so it makes it easy to spot there's an incorrect value somewhere. But as Scott points out, the main issue is here: if (weaponspec_1 == 9 && weaponhand_1 == 1) modifier = "1d12"; else if (weaponspec_1 == 9 && weaponhand_1 == 0) modifier = "1d10"; You don't handle what happens when weaponspec_1 is not 9.

1622594093

Pro

If it's not 9 it's whatever value you make it. With the modifications given above I was able to get it to work. GiGs said: But as Scott points out, the main issue is here: if (weaponspec_1 == 9 && weaponhand_1 == 1) modifier = "1d12"; else if (weaponspec_1 == 9 && weaponhand_1 == 0) modifier = "1d10"; You don't handle what happens when weaponspec_1 is not 9.

1622595581

Pro

Thank you Scott C. I got it to work.  Scott C. said: Ok, a couple things I notice. It is possible, actually very likely, to have modifier never set. This then results in modifier being undefined, and will cause setAttrs  to error out. You'll see this if you watch the developer console while working with your sheet. This is probably causing your problem because when setAttrs errors out in this way, it also corrupts the attribute that it was trying to set and makes it unchangeable by the sheetworker until a refresh. I'd recommend wrapping your setAttrs  in an if: if(modifier){     setAttrs({weapondmg_1:modifier}); }  And, just some general code critique. ==  is technically correct, but really ===  should be used instead. The full reasoning is admittedly a little beyond my code knowledge. The tldr though is that ==  (and != ) coerce the variable on the right side to match the type of the variable on the left side. While this seems like it is preferable, it has some odd effects where things you think would be equivalent aren't, and vice versa. Additionally, this behavior can depend on what type is on the left or right of the comparison. To ensure that you get consistent behavior, ===  (and !== ) are the preferred comparison methods as they compare the types rather than coercing them to be the same. This stack overflow thread has some good descriptions of the problems you can run into.

1622618368

Pro

Sheet Author

API Scripter

I see a potential problem with this approach if you don't also make other changes to the code. To illustrate, lets say your player sets weaponspec_1 to 9 and weaponhand_1 to 1. The modifier will be set to d12. So far so good. Then the player changes weaponspec_1 to 7. The worker above runs, but since modifier is not set and still undefined, setAttrs does not run, and the modifier on the sheet is still d12. Changing weaponspec_1 to any value other than 9, and the modifier will remain d12. If this is not how it should behave, you need to either set a default value, or extend you if statement to account for the other possible weaponspec_1 values.

1622623724

Pro

Why would they change weaponspec_1? The only reason would be that the weapon itself is being changed to a completely different weapon since weaponspec_1 is a trait of the weapon being used. The only thing a the player should be changing is whether they are using the weapon one handed or two handed. So they would have to change the damage code manually if the were changing the weapon anyway. This is for a custom Castles and Crusades sheet and this would only apply to a weapon with the 9 footnote. There is only one such weapon in the game. I know it seems like a lot of work for a bastard sword, but I'm trying to mimic the game as best as possible.

1622631131

Pro

Sheet Author

API Scripter

I guarantee it will happen. A player might decide to reuse the row, and simply change the entries for the weapkn to change it to something else. I wouldn't hammer on about it, except it's such an easy fix. Just change this line let modifier; to let modifier = "1d0"; or let modifier = "0"; and that's it - your code works for the weaponspec_1 9 weapons, and it works for every other weapon too - and it handles players changing the weapon type should they do that.

1622631496

Pro

So... <script type="text/worker"> on("change:weaponspec_1 change:weaponhand_1 change:weapondmg_1 sheet:opened", function() {          getAttrs(["WeaponSpec_1","WeaponHand_1","WeaponDmg_1"], function(values) {     let weaponspec_1 = parseInt(values.WeaponSpec_1)||0;     let weaponhand_1 = parseInt(values.WeaponHand_1)||0;     let modifier = "1d0";     // the scale if (weaponspec_1 === 9 && weaponhand_1 === 1) modifier = "1d12"; else if (weaponspec_1 === 9 && weaponhand_1 === 0) modifier = "1d10";     setAttrs({weapondmg_1 : modifier});  }); }); </script>

1622634822

Pro

Sheet Author

API Scripter