Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Prompt macros aren't working anymore!

October 20 (3 years ago)

I've been using this macro for a year or so, now doesn't work!


@{selected|wtype}&{template:default} {{name=Ability Score for @{selected|character_name}}} {{?{Ability Score
  | Strength, Strength +@{selected|strength_mod}@{selected|jack_bonus}=[[@{selected|d20}+@{selected|strength_mod}@{selected|jack_bonus}]] - [[@{selected|d20}+@{selected|strength_mod}@{selected|jack_bonus}]]
  | Dexterity, Dexterity +@{selected|dexterity_mod}@{selected|jack_bonus}=[[@{selected|d20}+@{selected|dexterity_mod}@{selected|jack_bonus}]] - [[@{selected|d20}+@{selected|dexterity_mod}@{selected|jack_bonus}]]
  | Constitution, Constitution +@{selected|constitution_mod}@{selected|jack_bonus}=[[@{selected|d20}+@{selected|constitution_mod}@{selected|jack_bonus}]] - [[@{selected|d20}+@{selected|constitution_mod}@{selected|jack_bonus}]]
  | Intelligence, Intelligence +@{selected|intelligence_mod}@{selected|jack_bonus}=[[@{selected|d20}+@{selected|intelligence_mod}@{selected|jack_bonus}]] - [[@{selected|d20}+@{selected|intelligence_mod}@{selected|jack_bonus}]]
  | Wisdom, Wisdom +@{selected|wisdom_mod}@{selected|jack_bonus}=[[@{selected|d20}+@{selected|wisdom_mod}@{selected|jack_bonus}]] - [[@{selected|d20}+@{selected|wisdom_mod}@{selected|jack_bonus}]]
  | Charisma, Charisma +@{selected|charisma_mod}@{selected|jack_bonus}=[[@{selected|d20}+@{selected|charisma_mod}@{selected|jack_bonus}]] - [[@{selected|d20}+@{selected|charisma_mod}@{selected|jack_bonus}]]
}}}
October 20 (3 years ago)

Edited October 20 (3 years ago)
Matt
Plus

New update has broken nested prompts and essentially all dropdowns as part of a "bug fix," with absolutely no instructions on how it should now be implemented. Knowing roll20, expect it will never be fixed. Might want to change your macros to a more simple form.

https://help.roll20.net/hc/en-us/articles/360037772613-Change-Log#october-20-2021-0-1

October 20 (3 years ago)

thank you Matt!

Matt said:

New update has broken nested prompts and essentially all dropdowns as part of a "bug fix," with absolutely no instructions on how it should now be implemented. Knowing roll20, expect it will never be fixed. Might want to change your macros to a more simple form.

https://help.roll20.net/hc/en-us/articles/360037772613-Change-Log#october-20-2021-0-1




October 20 (3 years ago)
keithcurtis
Forum Champion
Marketplace Creator
API Scripter

I wouldn't change any macros. This is a huge, breaking change the devs are aware of. I would expect it to be rolled back quickly, fixed and then rolled out again.

October 20 (3 years ago)

Thank you for confirming its not just me. I spent hours setting up my new campaign with extensive use of Token Action Maker, other APIs and DIY Macros. We had our first session tonight with me ready to show off all the awesome droplist macros to make life easier for our more rules-averse players... and all the droplist macros failed. It really took the wind out my sails because I had tested and tested again.

It is a small consolation that this is not a screw up on my part and I really really hope it is rolled back/fixed.

October 20 (3 years ago)

Edited October 20 (3 years ago)

Yes, this update has all but shut my game down. I use tons of custom macro's on sheets I designed myself.  Thanks Keith for keeping us in the loop you have helped me a number of times in the past and it is appreciated. 

October 20 (3 years ago)

I'm furious! i have around 15 or more Macros running from several tables with RecursiveTable, nothing is working!
I payed a lot of money to have a pro sub! Fuck me right?


October 20 (3 years ago)
borings b.
Pro
Marketplace Creator


Daniel W. said:

Thank you for confirming its not just me. I spent hours setting up my new campaign with extensive use of Token Action Maker, other APIs and DIY Macros. We had our first session tonight with me ready to show off all the awesome droplist macros to make life easier for our more rules-averse players... and all the droplist macros failed. It really took the wind out my sails because I had tested and tested again.

It is a small consolation that this is not a screw up on my part and I really really hope it is rolled back/fixed.


i am having the same exact experience, hours spent on setting up the nests, only to have my co-gm show up and me just sitting here saying "i dunno why it isn't working!"



October 20 (3 years ago)

Edited October 20 (3 years ago)


Dario M. said:

I'm furious! i have around 15 or more Macros running from several tables with RecursiveTable, nothing is working!
I payed a lot of money to have a pro sub! Fuck me right?

I understand your anger. I am not best pleased either. I am, however, giving the benefit of the doubt that this was a screw up - and one I hope they will fix. I have submitted a bug report and hopefully others will too as a way of expressing the impact.

October 20 (3 years ago)

Edited October 20 (3 years ago)
Kruc
Pro

No macros work for for 1e AD&D sheet either. Is there a fix in the works or are they going to roll back the update? I am unable to play my game!!!!  I just spent three days updating my games macros and now none of them work. Im running TOEE on 1e AD&D sheets and I i updated 400 character sheets !!! Can you just roll it back please???


October 20 (3 years ago)
borings b.
Pro
Marketplace Creator

Ok so after a bit of testing, what they did was make it so you don't need to use html markup for special characters in the nested macros anymore. but that means everyone that has nested macros written the old way (the way they still tell you to write them on the macro page) now has broken macros. the good news, they work if you go through and replace all your &#125 ; with } and so forth. they might write the code so that special characters are translated properly again, but the code they used to fix this might not work. i'm gonna backup the current versions in case this gets rolled back, but for those of you looking for an immediate solution, yer gonna hafta go in and manually change the special character codes to the actual characters.

October 20 (3 years ago)

Edited October 20 (3 years ago)


borings b. said:

Ok so after a bit of testing, what they did was make it so you don't need to use html markup for special characters in the nested macros anymore. but that means everyone that has nested macros written the old way (the way they still tell you to write them on the macro page) now has broken macros. the good news, they work if you go through and replace all your &#125 ; with } and so forth. they might write the code so that special characters are translated properly again, but the code they used to fix this might not work. i'm gonna backup the current versions in case this gets rolled back, but for those of you looking for an immediate solution, yer gonna hafta go in and manually change the special character codes to the actual characters.

Please could you give an example of what you mean? I am a bit of a Macro n00b and want to be sure I am changing the right thing

Edit: For example, how would you fix: 

&{template:default} {{name=Healing Potion}} {{

 ?{Potion|

 Regular, **Healing Potion Used:** [[2d4+2]]|

 Greater, **Greater Healing Potion Used:** [[4d4+4]]|

 Superior, **Superior Healing Potion Used:** [[8d4+8]]|

 Supreme, **Supreme Healing Potion Used:** [[10d4+20]]

 } 

 HP recovered



October 20 (3 years ago)
keithcurtis
Forum Champion
Marketplace Creator
API Scripter

That macro does not look like it was using any html substitutions or a default value, so is probably unaffected by either the upgrade or the bug. However, if you take out the returns and add closing brackets, it should work just fine:

&{template:default} {{name=Healing Potion}} {{?{Potion|Regular, **Healing Potion Used:** [[2d4+2]]|Greater, **Greater Healing Potion Used:** [[4d4+4]]|Superior, **Superior Healing Potion Used:** [[8d4+8]]|Supreme, **Supreme Healing Potion Used:** [[10d4+20]]}}}
HP recovered


October 20 (3 years ago)
keithcurtis
Forum Champion
Marketplace Creator
API Scripter

This wiki article is what the upgrade is probably intended to address. I wouldn't bother too much with trying to parse it out, though, as it will likely soon be deprecated.

October 20 (3 years ago)

Edited October 20 (3 years ago)
borings b.
Pro
Marketplace Creator


Daniel W. said:


borings b. said:

Ok so after a bit of testing, what they did was make it so you don't need to use html markup for special characters in the nested macros anymore. but that means everyone that has nested macros written the old way (the way they still tell you to write them on the macro page) now has broken macros. the good news, they work if you go through and replace all your &#125 ; with } and so forth. they might write the code so that special characters are translated properly again, but the code they used to fix this might not work. i'm gonna backup the current versions in case this gets rolled back, but for those of you looking for an immediate solution, yer gonna hafta go in and manually change the special character codes to the actual characters.

Please could you give an example of what you mean? I am a bit of a Macro n00b and want to be sure I am changing the right thing

Edit: For example, how would you fix: 

&{template:default} {{name=Healing Potion}} {{

 ?{Potion|

 Regular, **Healing Potion Used:** [[2d4+2]]|

 Greater, **Greater Healing Potion Used:** [[4d4+4]]|

 Superior, **Superior Healing Potion Used:** [[8d4+8]]|

 Supreme, **Supreme Healing Potion Used:** [[10d4+20]]

 } 

 HP recovered



so i assume you want it to actually function like this:

&{template:default} {{name=Healing Potion}} ?{Potion| Regular, {{**Healing Potion Used:** [[2d4+2]]}}| Greater, {{**Greater Healing Potion Used:** [[4d4+4]]}}| Superior, {{**Superior Healing Potion Used:** [[8d4+8]]}}| Supreme, {{**Supreme Healing Potion Used:** [[10d4+20]]}}}

the line breaks were causing prollems so if you tried running it the way you have there it doesn't work. you also had an extra set of opening {{ brackets before running the nested prompt. the Hp recovered thing is also not doing anything, its a bit clunkier but it might look better like this


&{template:default} ?{Potion| Regular, {{name=**Healing Potion Used:**}}  {{HP recovered: [[2d4+2]]}}| Greater, {{name=**Greater Healing Potion Used:**}} {{HP recovered: [[4d4+4]]}}| Superior, {{name=**Superior Potion Used:**}} {{HP recovered: [[8d4+8]]}}| Supreme, {{name=**Supreme Healing Potion Used:**}} {{HP recovered: [[10d4+20]]}}}

EDIT: and obviously keith swoops in with a better formatted answer while i dawdle away thinking about how i would do it

Are preset values also not working? I have a rather long macro I use to roll skill checks and I tried replacing the HTML with the actual characters and it still doesn't work, any ideas why? I can share the macro if interested but it's a bit long and I didn't want to bug people 

October 20 (3 years ago)

It’s good to know it wasn’t just me.

The disappointing thing is that the Devs. appear to either not know how people are using the platform (bad) or don’t particularly care (worse). For such a significant change the least they could have done was announce it… ideally in advance.

I am hoping for a roll-back as I have far too many macros (like many) to adjust (once I even managed to understand what I need to adjust).

October 20 (3 years ago)
borings b.
Pro
Marketplace Creator


Harry S. said:

Are preset values also not working? I have a rather long macro I use to roll skill checks and I tried replacing the HTML with the actual characters and it still doesn't work, any ideas why? I can share the macro if interested but it's a bit long and I didn't want to bug people 


by preset values do you mean like this (i have different preset values for the damage fields here:
&{template:default} ?{Damage Type|Trick,  {{name=Improved Rapier Trick Attack}} {{First Roll=[[1d20+7]]}} {{Second Roll=[[1d20+7]]}} {{Damage=11}}|Maneuver,  {{name=Improved Rapier Maneuver Attack}} {{First Roll=[[1d20+1]]}} {{Second Roll=[[1d20+1]]}} {{Damage=11}}|Spell,  {{name=Improved Rapier Spell Attack}} {{First Roll=[[1d20+1]]}} {{Second Roll=[[1d20+1]]}} {{Damage=8}}}

this is a macro i have in one of my games and it is working for me.

I'll just show the macro, if you can work out what's wrong (It's probably super simple and I'm dumb) that'd be amazing. Sorry that it's just a wall of text XD


@{selected|wtype}&{template:simple} @{selected|rtype}?{Skill

|Acrobatics,+[[(@{selected|acrobatics_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_acrobatics}*@{selected|npc})]][ACRO] ]]}} {{rname=Acrobatics}} {{mod=[[ [[(@{selected|acrobatics_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_acrobatics}*@{selected|npc})]][ACRO] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|acrobatics_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_acrobatics}*@{selected|npc})]][ACRO] ]]|Animal Handling,+[[(@{selected|animal_handling_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_animal_handling}*@{selected|npc})]][ANIM] ]]}} {{rname=Animal Handling}} {{mod=[[ [[(@{selected|animal_handling_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_animal_handling}*@{selected|npc})]][ANIM] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|animal_handling_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_animal_handling}*@{selected|npc})]][ANIM] ]]|Arcana,+[[(@{selected|arcana_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_arcana}*@{selected|npc})]][ARC] ]]}} {{rname=Arcana}} {{mod=[[ [[(@{selected|arcana_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_arcana}*@{selected|npc})]][ARCA] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|arcana_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_arcana}*@{selected|npc})]][ARCA] ]]|Athletics,+[[(@{selected|athletics_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_athletics}*@{selected|npc})]][ARC] ]]}} {{rname=Athletics}} {{mod=[[ [[(@{selected|athletics_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_athletics}*@{selected|npc})]][ATHL] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|athletics_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_athletics}*@{selected|npc})]][ATHL] ]]|Decpetion,+[[(@{selected|deception_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_deception}*@{selected|npc})]][ARC] ]]}} {{rname=Deception}} {{mod=[[ [[(@{selected|deception_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_deception}*@{selected|npc})]][DECE] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|deception_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_deception}*@{selected|npc})]][DECE] ]]|History,+[[(@{selected|history_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_history}*@{selected|npc})]][ARC] ]]}} {{rname=History}} {{mod=[[ [[(@{selected|history_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_history}*@{selected|npc})]][HIST] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|history_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_history}*@{selected|npc})]][HIST] ]]|Insight,+[[(@{selected|insight_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_insight}*@{selected|npc})]][ARC] ]]}} {{rname=Insight}} {{mod=[[ [[(@{selected|insight_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_insight}*@{selected|npc})]][INSI] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|insight_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_insight}*@{selected|npc})]][INSI] ]]|Intimidation,+[[(@{selected|intimidation_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_intimidation}*@{selected|npc})]][ARC] ]]}} {{rname=Intimidation}} {{mod=[[ [[(@{selected|intimidation_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_intimidation}*@{selected|npc})]][INTI] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|intimidation_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_intimidation}*@{selected|npc})]][INTI] ]]|Investigation,+[[(@{selected|investigation_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_investigation}*@{selected|npc})]][ARC] ]]}} {{rname=Investigation}} {{mod=[[ [[(@{selected|investigation_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_investigation}*@{selected|npc})]][INVE] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|investigation_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_investigation}*@{selected|npc})]][INVE] ]]|Medicine,+[[(@{selected|medicine_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_medicine}*@{selected|npc})]][ARC] ]]}} {{rname=Medicine}} {{mod=[[ [[(@{selected|medicine_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_medicine}*@{selected|npc})]][MEDI] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|medicine_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_medicine}*@{selected|npc})]][MEDI] ]]|Nature,+[[(@{selected|nature_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_nature}*@{selected|npc})]][ARC] ]]}} {{rname=Nature}} {{mod=[[ [[(@{selected|nature_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_nature}*@{selected|npc})]][NATU] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|nature_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_nature}*@{selected|npc})]][NATU] ]]|Perception,+[[(@{selected|perception_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_perception}*@{selected|npc})]][ARC] ]]}} {{rname=Perception}} {{mod=[[ [[(@{selected|perception_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_perception}*@{selected|npc})]][PERC] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|perception_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_perception}*@{selected|npc})]][PERC] ]]|Performance,+[[(@{selected|performance_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_performance}*@{selected|npc})]][ARC] ]]}} {{rname=Performance}} {{mod=[[ [[(@{selected|performance_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_performance}*@{selected|npc})]][PERF] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|performance_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_performance}*@{selected|npc})]][PERF] ]]|Persuasion,+[[(@{selected|persuasion_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_persuasion}*@{selected|npc})]][ARC] ]]}} {{rname=Persuasion}} {{mod=[[ [[(@{selected|persuasion_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_persuasion}*@{selected|npc})]][PERS] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|persuasion_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_persuasion}*@{selected|npc})]][PERS] ]]|Religion,+[[(@{selected|religion_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_religion}*@{selected|npc})]][ARC] ]]}} {{rname=Religion}} {{mod=[[ [[(@{selected|religion_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_religion}*@{selected|npc})]][RELI] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|religion_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_religion}*@{selected|npc})]][RELI] ]]|Sleight of Hand,+[[(@{selected|sleight_of_hand_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_sleight_of_hand}*@{selected|npc})]][ARC] ]]}} {{rname=Sleight Of Hand}} {{mod=[[ [[(@{selected|sleight_of_hand_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_sleight_of_hand}*@{selected|npc})]][SLEI] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|sleight_of_hand_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_sleight_of_hand}*@{selected|npc})]][SLEI] ]]|Stealth,+[[(@{selected|stealth_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_stealth}*@{selected|npc})]][ARC] ]]}} {{rname=Stealth}} {{mod=[[ [[(@{selected|stealth_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_stealth}*@{selected|npc})]][STEA] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|stealth_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_stealth}*@{selected|npc})]][STEA] ]]|Survival,+[[(@{selected|survival_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_survival}*@{selected|npc})]][ARC] ]]}} {{rname=Survival}} {{mod=[[ [[(@{selected|survival_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_survival}*@{selected|npc})]][SURV] ]]}} {{r1=[[@{selected|d20}+[[(@{selected|survival_bonus}@{selected|pbd_safe}*(1-ceil((@{selected|npc})*0.00001)))+(@{selected|npc_survival}*@{selected|npc})]][SURV] ]]

}}} {{global=@{selected|global_skill_mod}}} @{selected|charname_output}

October 20 (3 years ago)

Edited October 20 (3 years ago)
borings b.
Pro
Marketplace Creator

harry, it looks like you have too many closing ] and } in there. i am looking at it in notepad++, i would suggest copying it into there, as there is a nice function to check your brackets.

October 20 (3 years ago)
Juniper L.
Roll20 Team

Hi folks, thank you for making us aware of the issue. We're investigating it now, and I'll update here once I have more to report back to y'all. Apologies for the inconvenience!

October 20 (3 years ago)

Edited October 20 (3 years ago)
borings b.
Pro
Marketplace Creator


Juniper L. said:

Hi folks, thank you for making us aware of the issue. We're investigating it now, and I'll update here once I have more to report back to y'all. Apologies for the inconvenience!

so one thing i think is common, before the code would let extra closing brackets slide and continue on, but now it is being more precise and macros with extra brackets are getting messed up

Edit: after futzing with some of my nested macros that weren't working, i realized i was missing a couple closing brackets as well. so having too few, which also worked before, no longer works



borings b. said:

harry, it looks like you have too many closing ] and } in there. i am looking at it in notepad++, i would suggest copying it into there, as there is a nice function to check your brackets.


I was assuming as much, I just wasn't sure if it was that or the update because it worked before that, thanks for confirming 

I copied a macro from somewhere that dumps the info about various conditions to the chat.  It looks like it no longer works and that the newlines are the problem.  If I stick this all on one line it's happier but that's not ideal.


&{template:default} {{note= ?{Which Condition?| Blinded, **Blinded:**

* A blinded creature can't see and automatically fails and ability check that requires sight.

* Attack rolls against the creature have advantage and the creature's attack rolls have disadvantage.| Charmed, **Charmed:**

* A charmed creature can't attack the charmer or target the charmer with harmful abilities or magical effects.

* The charmer has advantage on any ability check to interact socially with the creature.| <OTHER CONDITIONS REMOVED FOR BREVITY> |} }}
October 21 (3 years ago)
Juniper L.
Roll20 Team

Hey again folks, sorry about that. We should be good!

What We Investigated:
Users were seeing failures in roll queries. The two symptoms were:
Default values were not being correctly filled, leading to issues with character sheets and APIs
Line breaks were causing entire rolls to be swallowed by the parser.
What Went Wrong:
When resolving a long standing issue with roll parsing, we deployed code that broke this functionality.
Resolution:
We released a hotfix that addressed these two issues. Roll Queries should now correctly parse without the need for HTML escape codes. Default values and line-breaks should now be parsing correctly.

October 21 (3 years ago)

Edited October 21 (3 years ago)
Kruc
Pro

Mine still are not working properly.   Using the 1e AD&D sheet ..   The Gif is not showing up and the second attack is also not showing up.


Everything in bold is NOT showing up... please help !!!


&{template:attacks} {{color=@{selected|color_option}}} {{name=@{selected|character_name}}} {{subtag=@{selected|repeating_weapon_$0_weapon_Name}}} {{AC Hit=[[@{THAC00}-(1d20 + @{selected|repeating_weapon_$0_weapon_ToHitBonus}[BON] + @{selected|repeating_weapon_$0_weapon_MagicBonus}[MAG] + ?{To Hit Modifier?|0}[MOD]) ]]}} {{damage1vsSM=[[@{selected|repeating_weapon_$0_weapon_DamageSmallMedium} + @{selected|repeating_weapon_$0_weapon_AttackDmgBonus}[BON] + @{selected|repeating_weapon_$0_weapon_MagicBonus}[MAG] + ?{Damage Modifier?|0}[MOD] ]]}} {{damage1vsL=[[@{selected|repeating_weapon_$0_weapon_DamageLarge} + @{selected|repeating_weapon_$0_weapon_AttackDmgBonus}[BON] + @{selected|repeating_weapon_$0_weapon_MagicBonus}[MAG] + ?{Damage Modifier?|0}[MOD] )]]}}

&{template:general} {{color=darkgrey}} {{name=

Two Attacks


}}

&{template:attacks} {{color=@{selected|color_option}}} {{name=@{selected|character_name}}} {{subtag=@{selected|repeating_weapon_$0_weapon_Name}}} {{AC Hit=[[@{THAC00}-(1d20 + @{selected|repeating_weapon_$0_weapon_ToHitBonus}[BON] + @{selected|repeating_weapon_$0_weapon_MagicBonus}[MAG] + ?{To Hit Modifier?|0}[MOD]) ]]}} {{damage1vsSM=[[@{selected|repeating_weapon_$0_weapon_DamageSmallMedium} + @{selected|repeating_weapon_$0_weapon_AttackDmgBonus}[BON] + @{selected|repeating_weapon_$0_weapon_MagicBonus}[MAG] + ?{Damage Modifier?|0}[MOD] ]]}} {{damage1vsL=[[@{selected|repeating_weapon_$0_weapon_DamageLarge} + @{selected|repeating_weapon_$0_weapon_AttackDmgBonus}[BON] + @{selected|repeating_weapon_$0_weapon_MagicBonus}[MAG] + ?{Damage Modifier?|0}[MOD] )]]}} 


&{template:general} {{color=darkgrey}} {{name=3 Attacks Every 2 Rounds

}}

[gg](https://media.giphy.com/media/mgys5u4CCrFGaJyv2A/giphy.gif)


October 21 (3 years ago)

Edited October 21 (3 years ago)

Using a custom text macro, no sheet aside from one I made from attributes

?{Move|

AW Slip Through the Light (Ethereal Sidestep),/me Slips Through the Light [Ethereal Sidestep]

At-Will ✦ Move Action ✦ Arcane&#44; Teleportation

Personal

**Effect:** Eve teleports [[4]] square.|

D Relocate (Rubicant Blade),/me Relocates Her Allies [Rubicant Blade]

Daily ✦ Move Action

**Effect:** Eve teleports [[8]] squares. Two allies within 5 squares of where she started can teleport [[5]] squares.}

worked normally before the update, after the update it has the following output

https://gyazo.com/d31bbe4f584a89742560931e1e6092ad

It now runs, but as you can see, the line breaks are simply being removed.

October 21 (3 years ago)

Edited October 21 (3 years ago)

Is it possible this fix broke line breaks in chat? None of us can input multi-line text now, such as a series of die rolls or even separating an emote from regular text.

The example in the wiki (https://help.roll20.net/hc/en-us/articles/360039675093-Text-Chat) doesn't work for us, it just comes out as one big emote:

/me strikes a valiant pose.
Evil doer, beware, I am on your trail!
/w gm This is the signal that the thugs I paid are waiting for.


October 21 (3 years ago)
The Aaron
Roll20 Production Team
API Scripter


camelotcrusade said:

Is it possible this fix broke line breaks in chat? None of us can input multi-line text now, such as a series of die rolls or even separating an emote from regular text.

The example in the wiki (https://help.roll20.net/hc/en-us/articles/360039675093-Text-Chat) doesn't work for us, it just comes out as one big emote:

/me strikes a valiant pose.
Evil doer, beware, I am on your trail!
/w gm This is the signal that the thugs I paid are waiting for.



I can confirm that is the case.  It is definitely concatenating multiple lines into a single line.



Line breaks on chat are not working, and macros that use line breaks to execute can't.


[*name button*](!
#name macro)


This chat macro button doesn't work, and because all line-breaks have stopped working for me, I assume this chat button isn't working because line-breaks are broken, like non existent.

October 21 (3 years ago)

Edited October 21 (3 years ago)

Thanks for confirming guys. I made a post in the bug forum about line breaks but a moderator deleted it within 5 minutes. I don't know why. Hopefully it sticks here, at least, so others worried about this behavior know it's acknowledged.

I am also having some issues, but it's currently just aesthetic. We tend to start our macros with emotes to help split them up a bit, so currently it just displays everything as part of the emote instead of doing line breaks properly. It's still busted. 

October 21 (3 years ago)
Juniper L.
Roll20 Team
Hi again, sorry y'all - we're looking into this again. Thank you for your patience.
October 21 (3 years ago)

For my macros, my line breaks seem like they are getting ignored. Everything is like a run on sentence and if an emote starts the macro, it's all emoted. My game starts Sunday with all my macros ruined. Hopefully they undo it.

October 21 (3 years ago)

Hiya, I see Juniper's post and thanks for your efforts! My rollable table links to macros not working. Just posting it here to let yall know. 

October 21 (3 years ago)
Juniper L.
Roll20 Team

Hi folks, we SHOULD be good to go now, we rolled back a small subset of changes made earlier today.

October 21 (3 years ago)
The Aaron
Roll20 Production Team
API Scripter

I can confirm that after refreshing my game, things are back to normal and working for me!  Thanks!

October 21 (3 years ago)

Having just loaded up my game, mine are still not working

This macro

?{Proc|

Clinging Slime [Astral Wasp] (Effect),/me ‘s Clinging Ooze takes a piece: [[@{CON} + ?{Damage Modifiers 1?|0}]] lightning damage|

Rebounding Slime [Shock Beetle Swarm] (Hit),/me ‘s Rebounding Ooze bounces around dealing [[@{CON} + ?{Damage Modifiers 1?|0}]] lightning damage.}

Gives no prompts and outputs the following

https://cdn.discordapp.com/attachments/466545432626200577/900593729222619166/Macro_Output.PNG

This is that state my macros were in after the initial update, before any of the rollbacks.

Line breaks are working for me now. Thanks for fixing it so quickly!

October 21 (3 years ago)
Elfonochasis
Sheet Author
Hello,

We're still having rolls problem in our games using Ragnarok 3ed. Sheet was working perfectly but now it's not showing/rendering roll results in chat.
October 21 (3 years ago)

Edited October 21 (3 years ago)

I have numerous query macros failing in my live sessions.  Can someone link to the new syntax we're suppose to be using and why on earth did they change all of this without warning us before hand or giving us time on dev to remake all of our sheets and macros?  This is going to cause 2 of my weekly sessions to miss a week cause of this mess.  Its still not fixed after leaving this for a whole day assuming they would patch it but it looks like in this thread they think the problem is gone when it is infact still present.  I seem to be missing the new instructions on how to do a nested query.  what is the new way of writing them please?

A noteable mainstay script we all use for 5e is that hard to find "Apply damage" and Group check script and that specifically is broken with the current...whatever they did.  It no longer applies damage and instead spits out the main menu of group check instead.  

October 21 (3 years ago)

as with all bugs, they didn't see it coming. They will get it fixed ASAP. Right now, someone is probably drinking coffee and floating in the sea of inner rage caused by finding all the issues the complier found the last time they ran it, and having ten times that number pop up from nowhere. You know, the normal programing process. I would be surprised if it wasn't fixed by this time tomorrow.

October 21 (3 years ago)

My drop down option macros are still it working. They were fine before latest changes. !!! So now not only can my I not play with the iPad, right click still broken! Over 1 month now. But games are unplayable as macros not working . I can’t even change macros if I wanted to as can’t edit macros on iPad. 

October 21 (3 years ago)
GiGs
Pro
Sheet Author
API Scripter


Chris said:

My drop down option macros are still it working. They were fine before latest changes. !!! So now not only can my I not play with the iPad, right click still broken! Over 1 month now. But games are unplayable as macros not working . I can’t even change macros if I wanted to as can’t edit macros on iPad. 


You'll need to post the text of one or two of those macros who we can see what is not working.


GiGs said:


Chris said:

My drop down option macros are still it working. They were fine before latest changes. !!! So now not only can my I not play with the iPad, right click still broken! Over 1 month now. But games are unplayable as macros not working . I can’t even change macros if I wanted to as can’t edit macros on iPad. 


You'll need to post the text of one or two of those macros who we can see what is not working.



I'll bite:

!group-check {{
	--?{What save?||
		Str,Strength Save|
		Dex,Dexterity Save|
		Con,Constitution Save|
		Int,Intelligence Save|
		Wis,Wisdom Save|
		Cha,Charisma Save
	} --hidename 
	--process
	--ro roll2
	--subheader vs DC ?{DC}
	--button ApplyDamage !apply-damage
	~dmg [[?{Damage}]]
	~type ?{Damage on Save|Half,half|None,none}
	~DC ?{DC}
	~saves RESULTS(,)
	~ids IDS(,)
}}

Oh and unironically they broke LDL in my sessions by making this macro not work lol:

?{On or Off?||On,!flicker-on ?{What lightsource?&#124;&#124;Candle&#44;10 5 yes 360&#124;Lamp&#44;45 15 yes 360&#124;Moontouched&#44;30 15 yes 360&#124;Light Spell&#44;40 20 yes 360&#124;Torch&#44;40 20 yes 360&#124;Hooded Lantern&#44;60 30 yes 360&#124;Flametongue&#44;80 40 yes 360&#124;Daylight&#44;120 60 yes 360&#124;Bullseye Lantern&#44;120 60 53&#124;Produce Flame&#44;20 10 yes 360&#125;
!token-mod --set statusmarkers&#124;+half-haze
/em begins to emit light.|
Off,!flicker-off
!token-mod --set statusmarkers&#124;-half-haze
/em snuffs out their lightsource.
}

October 21 (3 years ago)

I would love to but as I can’t select macros on iPad, previous bug still not fixed ,  it’s not possible to. But similar to DM Eddie’s only mine calls roll tables 


October 21 (3 years ago)
GiGs
Pro
Sheet Author
API Scripter


Juniper L. said:

Hi folks, we SHOULD be good to go now, we rolled back a small subset of changes made earlier today.


What's been rolled back, and what is still live?

I'm curious if this means I will eventually have to rewrite most of my macros to fit into a new scheme. Like is this rollback temporary or is it coming back?

I already have to use a bunch of API and a custom.sheet just to make running Castles and Crusades worthwhile on roll20 but if I have to spend days or weeks rewriting macros then it might be time to relook at Fantasy Grounds.


Do will [button](!&#13;#macro) be obsolete and if so what should it look like?

October 21 (3 years ago)

I'm still having trouble with default values for roll queries as well as with line breaks. For about a year I've been using the following macro pair without issue.

Firstly:

//?{Advantage| Normal,1d20|Advantage,2d20kh1|Disadvantage,2d20dh1}
//?{Bless| Yes, +1d4|No, &nbsp;}
?{Number of Beams| 
1, %{CharacterName|ebr} |
2, %{CharacterName|ebr} %{CharacterName|ebr} |
3, %{CharacterName|ebr} %{CharacterName|ebr} %{CharacterName|ebr} |
4, %{CharacterName|ebr} %{CharacterName|ebr} %{CharacterName|ebr} %{CharacterName|ebr} | }

Which calls a second ability on the character sheet:

[[?{Advantage&#125; +@{spell_attack_bonus} ?{Bless&#125;]]

What is supposed to happen is, the conditions for the roll are specified, then the number of rolls are specified and those conditions are rolled the selected number of times.

What happens currently is when the first macro is rolled currently the query for the advantage state and bless work correctly but the call for the number of beams is skipped entirely. This part of the problem can be fixed by putting everything on a single line.

The second part of the issue is seemingly with the roll query default values. When the second macro is called as part of a roll query, the values given for the advantage and bless section are not passed along as they used to be. Instead the second macro requests that they be defined again. However, the values are passed along when the second macro is called directly in the form:

//?{Advantage| Normal,1d20|Advantage,2d20kh1|Disadvantage,2d20dh1}
//?{Bless| Yes, +1d4|No, &nbsp;}

%{CharacterName|ebr}