[CombatMaster]Issue

The latest version as of yesterday had made it virtually impossible to edit peoples initiatives as every tick that the API fires everyones focus changes to their tokens or nothing.  So I have to pause the api and edit initiatives then unpause combatmaster.  Not a problem when initiatives are taken as they are rolled by I have a table where people roll real dice and a table with someone who constantly double clicks initiative by accident and I had to constantly pause to get initiative working.  

That feels not right, I try to visualize what happens here, but its not clear to me. I cannot reproduce the behaviour you are describing. What is 'every tick'? 4 times a second or when the turnorder is changed. On the API page tab for CombatMaster you can revert to an older version for now - version 2.4.1 (as i created two versions with the last commit).

When you go to edit the initiative it immediately exits out of edit mode and you can't edit the number, if you can click the edit and have your fingers hovering over the numbers on your keyboard sometimes you can squeeze in the entries.  It seems to be corresponding to the ticks of the rotating circle of the current turn.  

A few additional details: I definitely got this to work normally also, but the only way to trigger it to happen manually alone in session was to select tokens and hit the play key in the combatmaster menu.&nbsp;&nbsp; <a href="https://youtu.be/L20GBxv-p2c" rel="nofollow">https://youtu.be/L20GBxv-p2c</a> To be 1000% clear, this was happening to 9 people's browsers across multiple locations on planet earth using 3 different browsers throughout the entire night so this is not MY machine, my extensions, or the scripts.&nbsp; Its something in combatmaster or something roll20 did with yesterdays patch.&nbsp;&nbsp;

Thank you for taking the time to provide these details. The behavior could be replicated, it is an interaction between CombatMaster and Roll20 Audio Master. If you turn off the animation in the TurnOrder Setup with the 'Animate Marker' setting, the issue is resolved. I will update CombatMaster so animation is Off by default, though everybody that experience this issue can only fix it by turning it off in the settings. It will take some time before this update is available in the OneClick repositiory.

Whoa, well first issue is the 30+ api you are running.&nbsp; At this point I have no idea what's going on.&nbsp; I can tell you in an &lt; 10 api environment, what you are experiencing does not happen at all.&nbsp; No one using CM has encountered this, so please don't assume it's CM.&nbsp; Roll20AM is also running in all my games and has absolutely no relation to CM.&nbsp;&nbsp; You need to shut everything OFF.&nbsp; You've gone API overboard and they can bounce up against each other because there are absolutely no standards in this environment and no controls.&nbsp; Roll20 is very derelict in this.&nbsp; The worst aspects of shareware combined.&nbsp; They should have a checker to make sure that one command won't conflict with another but since we are all contributing for free?&nbsp; Why worry? Not our problem. Start introducing back, starting with CM, and you'll see it's working. Keep doing this, one API at a time, until it fails.&nbsp; Then look at the API causing the failure.&nbsp;&nbsp; There *could* be an issue with your init roller?&nbsp; Are you rolling every round, what are you rolling every round?&nbsp; Perhaps that's causing and issue but that's all I can see that might cause a CM issue.&nbsp;&nbsp; Shut everything off and start introducing back in.&nbsp; You might notice that some of these APIs are issuing the same command, which would cause one to step on the other.&nbsp;&nbsp;

Martin's changes to the script so far have been nothing but URL based.&nbsp; Icon based. Unless something else was changed that might be causing your issue, start with disabling all APIs.&nbsp; If the problem still exists, then something new has caused this issue

@DM Eddie, I've started up a game with latest CM.&nbsp; No, you can change init.&nbsp; Not sure what "the API fires everyones focus changes to their tokens or nothing."&nbsp; means.&nbsp; Have no idea there.&nbsp; CM is working fine, latest version for me.&nbsp; Yes you can change INIT.&nbsp; Yes it's stepping through fine.&nbsp; So disable your APIs and find out where the problem is.&nbsp; Again, there's no standards and no control here.&nbsp; One thing is stepping on the other.&nbsp;&nbsp;

Victor B. said: Whoa, well first issue is the 30+ api you are running.&nbsp; At this point I have no idea what's going on.&nbsp; I can tell you in an &lt; 10 api environment, what you are experiencing does not happen at all.&nbsp; No one using CM has encountered this, so please don't assume it's CM.&nbsp; Roll20AM is also running in all my games and has absolutely no relation to CM.&nbsp;&nbsp; You need to shut everything OFF.&nbsp; You've gone API overboard and they can bounce up against each other because there are absolutely no standards in this environment and no controls.&nbsp; Roll20 is very derelict in this.&nbsp; The worst aspects of shareware combined.&nbsp; They should have a checker to make sure that one command won't conflict with another but since we are all contributing for free?&nbsp; Why worry? Not our problem. Start introducing back, starting with CM, and you'll see it's working. Keep doing this, one API at a time, until it fails.&nbsp; Then look at the API causing the failure.&nbsp;&nbsp; There *could* be an issue with your init roller?&nbsp; Are you rolling every round, what are you rolling every round?&nbsp; Perhaps that's causing and issue but that's all I can see that might cause a CM issue.&nbsp;&nbsp; Shut everything off and start introducing back in.&nbsp; You might notice that some of these APIs are issuing the same command, which would cause one to step on the other.&nbsp;&nbsp; I appreciate your work immensely, but for the sake of getting it fixed: <a href="https://youtu.be/aWXb0WCs9v0" rel="nofollow">https://youtu.be/aWXb0WCs9v0</a> You will see when the error is occuring the rotating graphic is not rotating either even though its set to.&nbsp; Indeed turning off that setting fixes the problem so pushing a change to your script to disable that by default will indeed fix the problem for people like me.&nbsp; However, I think that the culprit of this problem started from something done THIS tuesday.&nbsp; Your change to the script to have rotating turn orders on by default was last tuesday as I never had it on myself till you changed the default state.&nbsp; It did not do this last week.&nbsp; I have people with physical dice, so when initiative is rolled they roll to get a turn set, then edit in manually every time.&nbsp; this never happened last week.&nbsp; It only started with this tuesdays patch.&nbsp; We had a full session where the rotation was happening and we could edit just fine.&nbsp;&nbsp; There are times where this bug does not replicate and its usually the very first time the turn order opens from a fresh api spin up.&nbsp; After that it begins to consistently fail.&nbsp;&nbsp; EDIT:&nbsp; As the above video shows, it infact is not a problem with too many scripts or an interaction between roll20AM and Cmaster.&nbsp; It is either a bug with roll20 or a bug with combat master at this point as the only script installed is combatmaster above and there are no extensions, and again, all 9 players reported having the inability to edit their initiatives when this was active in a live session.&nbsp;&nbsp;

If this is impossible to fix, might I suggest getting someone to turn your turn order graphic into an animated gif.&nbsp; Then instead of pulsing rotations on the art graphic its as simple as pulsing a start/stop on timer pauses.&nbsp;&nbsp;

It took me a few hours, but i have managed to reproduce this behaviour twice. Only seems to be able to happens the first you press play and the API was restarterd. But when it happened, the roll20 client (ie the browser) started to reload assets forever, spamming the browser developer console with image related CORS errors and never stopping while no markers are seen rotating. It feels like a nasty timing issue. After quite some testing I have used this version in three sessions and it never happened. Will try to find the root cause and either fix it or remove it.

Martijn S. said: It took me a few hours, but i have managed to reproduce this behaviour twice. Only seems to be able to happens the first you press play and the API was restarterd. But when it happened, the roll20 client (ie the browser) started to reload assets forever, spamming the browser developer console with image related CORS errors and never stopping while no markers are seen rotating. It feels like a nasty timing issue. After quite some testing I have used this version in three sessions and it never happened. Will try to find the root cause and either fix it or remove it. It actually can happen before the 2 circles are even displayed and a turn is set as first in combatmaster.&nbsp; My default start to every encounter is I ask the players to roll initiative, they roll, and combat tracker pops up for them with their turns all out of order, then I select all my encounters creatures and hit my group-init key.&nbsp; The 2 circles for combatmaster at this point are no where to be found.&nbsp; They only appear after I sort and advance past the first turn, and the players are editing their initiative before then.&nbsp; The only way to get those circles to show up for the first turn is to pause the encounter with the button to the right of the stop key, then hit the yellow play key again.&nbsp; But again, the inability to edit is well before those turn icons show up on the map, but it is solved by disabling rotating turn icons.&nbsp;&nbsp;

1) I would have opted for animated graphic if it would be possible to start/stop animation from the API (which AFAIK is not possible). 2) Afraid that the timing of the first rotation is such that it really confused the browser code, when i saw the developer console when i reproduced it, this clearly brings the roll20 client in a very bad place. As i would not want that to happen, i will find the root cause or remove it.

@DM Eddie, this is working now.&nbsp; Pull in script from my Github and I'll get it into Roll20 next Tuesday.&nbsp;&nbsp; Version 2.45 <a href="https://github.com/vicberg/CombatMaster" rel="nofollow">https://github.com/vicberg/CombatMaster</a>

The pull request for version 2.45 has been accepted and is available in the roll20 github. <a href="https://github.com/Roll20/roll20-api-scripts/blob/master/CombatMaster/2.45/CombatMaster.js" rel="nofollow">https://github.com/Roll20/roll20-api-scripts/blob/master/CombatMaster/2.45/CombatMaster.js</a> it should be in Roll20 One-Click shortly.

I just installed it, preliminary run seems to work fine, but I have session with 8 players in 3 hours from now and will let you know if theres an issues probably in about 8-10 hours from now or tomorrow morning.&nbsp;&nbsp;

At this very moment there is an issue with the API console in general, it had a clear impact during my session (which just finished). i hope it is resolved before your sessions starts

I saw the issue but doing prep work now and haven't seen any problems yet myself, I typically do well on patch day, I think I'm on their first shard they start patching since I live near their HQ.&nbsp;&nbsp;

Let me know if your problem comes back.&nbsp; I banged on it for a bit and didn't encounter any issues.&nbsp;&nbsp;

Everything ran smoothly.&nbsp;&nbsp;