AD&D 2ed revised sheet

Hello all, I'm using the AD&D 2ed Character Sheet and am trying to use the HIT button with the 2Eattack template, I saw many other places where this happens with there corresponding templates like Checks and Spells.  So I've tried a few different things changing the value of the roll to "&{template:2Eattack}{{title=@{selected|token_name} attacks}} {{subtitle=@{target|token_name} with}} {{weapon_used=@{weaponname} }} {{ac_hit=[[@{ThAC0}-(1d20+(@{attackadj})+(@{prof-level})+(@{strengthhit})+(@{misc-mod}))]]}} {{dmg_s=[[@{weapons-damage}damsm}+(@{repeating_weapons-damage|damadj}+(@{repeating_weapons-damage|specialist-damage})+(?{Damage Mod?|0})]]}}{{dmg_l=[[@{repeating_weapons-damage|damsm}+(@{repeating_weapons-damage|damadj}+(@{repeating_weapons-damage|specialist-damage})+(?{Damage Mod?|0})]]}}" now it works to get to the attack roll but come time for damage I get errors or nothing or the entire macro fails, so I believe its because the damage portion is in a different section.  Any help would be great

Hi Mezz. I've had a look at your macro, and discovered quite a lot of problems with it. I've done my best to fix it all up , and it does now work. I adjusted almost every attribute so they now point at the right sheet attribute. Please review and update accordingly.  One thing I simply could not locate on the character sheet was "prof-level", so I've had to leave this out for now. NB: If you want to add a value from a list of repeating values, you must reference it as I've done in the below macro code. The first list element is $0, the second list element would be $1 etc. The macro below is an example attack macro for a strength-based weapon. If you want to make a macro for a dexterity-based weapon, you will have to amend the attack and damage adjustments accordingly.  &{template:2Eattack} {{title=@{selected|token_name} attacks}} {{subtitle=@{target|token_name} with}} {{weapon_used=@{selected|repeating_weapons_$0_weaponname} }} {{ac_hit=[[@{selected|thAC0-base-calc}-(1d20+(@{selected|repeating_weapons_$0_attackadj})+(@{selected|strengthhit})+(?{to-hit mod ?|0}))]]}} {{dmg_s=[[ @{selected|repeating_weapons-damage_$0_damsm} + @{selected|repeating_weapons-damage_$0_damadj} + @{selected|strengthdmg} + @{selected|repeating_weapons-damage_$0_specialist-damage} + (?{Damage Mod?|0}) ]] }} {{dmg_l=[[ @{selected|repeating_weapons-damage_$0_daml} + @{selected|repeating_weapons-damage_$0_damadj} + @{selected|strengthdmg} + @{selected|repeating_weapons-damage_$0_specialist-damage} + (?{Damage Mod?|0}) ]] }} I setup a Battleaxe as my first weapon ($0) to use for the testing, and it does seem to work fine: I do hope that's of some help to you, and good luck!

Hi Mezz, You are right, you need to fill some specific fields in the character sheet for the rolltemplate to display correctly. Depending on which element is part of your macro, you must fill the corresponding field on the character sheet. (see last picture below) I would suggest a few improvements to Manny's macro: - add comments inside the inline rolls to inform the players what all these different numbers do - add the proficiency level of the weapon to both hit and damage calculation - add the temporary buff to both hit and damage calculation (like clerical Bless,  bardic Motivation, ...) - add a "switch" to the STR bonus in case the weapon used does not rely on Strength (if the STR checkbox is checked on the character sheet, the bonus is added to the roll, otherwise it is not) - sort the numbers to be in line with the character sheet (strength bonus first, then proficiency level, then adjustment, ...) &{template:2Eattack}{{title=@{selected|token_name} attacks}}{{subtitle=@{target|token_name} with}}{{weapon_used=@{selected|repeating_weapons_$0_weaponname}}}{{ac_hit=[[ @{selected|thac0-base-calc}[ThAC0] - (1d20[ROLL] + (@{selected|strengthhit}*@{selected|repeating_weapons_$0_strbonus}[STR BONUS]) + (@{selected|repeating_weapons_$0_prof-level}[PROF. LEVEL]) + (@{selected|repeating_weapons_$0_attackadj}[ATK ADJ.]) + (@{selected|temp-attackadj}[TEMP. BUFF]) + (?{Misc. Attack Roll Modifier|+0}[HIT MOD.]))]] }}{{dmg_s=[[ @{selected|repeating_weapons-damage_$0_damsm}[DMG SM] + (@{selected|strengthdmg}*@{selected|repeating_weapons_$0_strbonus}[STR BONUS]) + (@{selected|repeating_weapons-damage_$0_specialist-damage}*1)[PROF. DMG] + (@{selected|repeating_weapons-damage_$0_damadj}[DMG ADJ.]) + (@{selected|temp-damadj}[TEMP. BUFF]) + (?{Damage Roll Modifier|+0}[DMG MOD.]) ]] }}{{dmg_l=[[ @{selected|repeating_weapons-damage_$0_daml}[DMG L] + (@{selected|strengthdmg}*@{selected|repeating_weapons_$0_strbonus}[STR BONUS]) + (@{selected|repeating_weapons-damage_$0_specialist-damage}*1)[PROF. DMG] + (@{selected|repeating_weapons-damage_$0_damadj}[DMG ADJ.]) + (@{selected|temp-damadj}[TEMP. BUFF]) + (?{Damage Roll Modifier|+0}[DMG MOD.])]] }} Below is the expected display of the macro above: And the 12 fields needed for the rolltemplate to work as intended: Feel free to modify the macro to suit your needs.

Thanks for that, but I guess my question was badly worded, I'm doing it in the sheet itself not a macro, I have those macros for some attacks, but I have really new players and I don't have time to make them for everyone :(, so I figured to try and do it in the sheet because they have just discovered that its possible. But here is the code for the entire standard-melee weapons section: <div class="sheet-tab-content sheet-section-weapon-standard-melee">     <table>         <thead class="sheet-default-header">         <tr>             <th class="sheet-centering-padding-2" rowspan="2" title="Strength attack adjustment">Str</th>             <th rowspan="2" title="Weapon name">Weapon</th>             <th rowspan="2" title="Proficiency level with weapon">Proficiency</th>             <th rowspan="2" title="Number of attacks per round"># of<br>Attack</th>             <th rowspan="2" title="Attack adjustment">Attack<br>Adj.</th>             <th rowspan="2" colspan="2" title="To Hit Armor Class 0">THAC0</th>             <th rowspan="2" title="Natural roll Crit">Crit</th>             <th rowspan="2" title="Ranges for Short, Medium, and Long">Range</th>             <th rowspan="2" title="Size ie. S/M/L">Size</th>             <th class="sheet-centering" colspan="3" title="Type ie. Slashing, Piercing, or Bludgeoning">Type</th>             <th rowspan="2" colspan="2" title="Speed factor">Speed</th>         </tr>         <tr class="sheet-centering">             <th title="Slashing">S</th>             <th title="Piercing">P</th>             <th title="Bludgeoning">B</th>         </tr>         </thead>         <tr class="sheet-collapse">             <td><label><input type='checkbox' title="@{strbonus}" value='1' checked/><span></span></label></td>             <td><input type="text" title="@{weaponname}" class="sheet-middle"></td>             <td>                 <select title="@{prof-level}" class="sheet-table-dynamic">                     <option value="@{nonprof-penalty}">Nonproficient</option>                     <option value="@{famil-penalty}">Related Weapon</option>                     <option value="0" selected="selected">Proficient</option>                     <option value="1">Specialist</option>                 </select>             </td>             <td><input type="text" title="@{attacknum}" class="sheet-table-dynamic"></td>             <td><input type="text" title="@{attackadj}" class="sheet-table-dynamic" value="0"></td>             <td><input type="text" title="@{ThAC0}" class="sheet-small" value="20"></td>             <td><button type="roll" title="%{hit1}" >Hit</button></td>             <td><input type="text" title="@{crit-thresh}" class="sheet-small" value="20"></td>             <td><input type="text" title="@{range}" class="sheet-short"></td>             <td><input type="text" title="@{size}" class="sheet-table-dynamic"></td>             <td><label><input type="checkbox" title="@{weaptype-slash}" value="1"/><span></span></label></td>             <td><label><input type="checkbox" title="@{weaptype-pierce}" value="1"/><span></span></label></td>             <td><label><input type="checkbox" title="@{weaptype-blunt}" value="1"/><span></span></label></td>             <td><input type="text" title="@{weapspeed}" class="sheet-small"></td>             <td><button type="roll" title="%{init}" >Initiative</button></td>         </tr>     </table>     <fieldset name="repeating_weapons" title="@{weapons}" class="repeating_weapons">     <table>         <!--  Invisible header row to keep the spacing of all the cells  -->         <thead class="sheet-default-header" style="visibility: collapse;">         <tr>             <th class="sheet-centering-padding-2" rowspan="2" title="Strength attack adjustment">Str</th>             <th rowspan="2" title="Weapon name">Weapon</th>             <th rowspan="2" title="Proficiency level with weapon">Proficiency</th>             <th rowspan="2" title="Number of attacks per round"># of<br>Attack</th>             <th rowspan="2" title="Attack adjustment">Attack<br>Adj.</th>             <th rowspan="2" colspan="2" title="To Hit Armor Class 0">THAC0</th>             <th rowspan="2" title="Natural roll Crit">Crit</th>             <th rowspan="2" title="Ranges for Short, Medium, and Long">Range</th>             <th rowspan="2" title="Size ie. S/M/L">Size</th>             <th class="sheet-centering" colspan="3" title="Type ie. Slashing, Piercing, or Bludgeoning">Type</th>             <th rowspan="2" colspan="2" title="Speed factor">Speed</th>         </tr>         <tr class="sheet-centering">             <th title="Slashing">S</th>             <th title="Piercing">P</th>             <th title="Bludgeoning">B</th>         </tr>         </thead>         <tr class="sheet-centering">             <td><label><input type='checkbox' name='attr_strbonus' title="@{repeating_weapons_$X_strbonus}" value='1' checked/><span></span></label></td>             <td>                 <input type="text" name="attr_weaponname" title="@{repeating_weapons_$X_weaponname}" class="sheet-middle sheet-chrome" list="melee-weapons">                 <input type="text" name="attr_weaponname" title="@{repeating_weapons_$X_weaponname}" class="sheet-middle sheet-firefox" list="melee-weapons-ff"><span></span>             </td>             <td>                 <select name="attr_prof-level" title="@{repeating_weapons_$X_prof-level}" class="sheet-table-dynamic">                     <option value="@{nonprof-penalty}">Nonproficient</option>                     <option value="@{famil-penalty}">Related Weapon</option>                     <option value="0" selected="selected">Proficient</option>                     <option value="1">Specialist</option>                 </select>             </td>             <td><input type="text" name="attr_attacknum" title="@{repeating_weapons_$X_attacknum}" class="sheet-table-dynamic" value="1"></td>             <td><input type="text" name="attr_attackadj" title="@{repeating_weapons_$X_attackadj}" class="sheet-table-dynamic" value="0"></td>             <td><input type="text" name="attr_ThAC0" title="@{repeating_weapons_$X_ThAC0}" class="sheet-small" value="20"></td>             <td><button type="roll" name="roll_hit1" title="%{repeating_weapons_$X_hit1}" value="&{template:2Eattack}{{title=@{selected|token_name} attacks}} {{subtitle=@{target|token_name} with}} {{weapon_used=@{weaponname} }} {{ac_hit=[[@{ThAC0}-(1d20+(@{attackadj})+(@{prof-level})+(@{strengthhit})+(@{misc-mod}))]] }} {{dam_s=}}{{dam_l=}})">Hit</button></td>             <td><input type="text" name="attr_crit-thresh" title="@{repeating_weapons_$X_crit-thresh}" class="sheet-small" value="20"></td>}             <td><input type="text" name="attr_range" title="@{repeating_weapons_$X_range}" class="sheet-short"></td>             <td><input type="text" name="attr_size" title="@{repeating_weapons_$X_size}" class="sheet-table-dynamic"></td>             <td><label><input type="checkbox" name="attr_weaptype-slash" title="@{repeating_weapons_$X_weaptype-slash}" value="1"/><span></span></label></td>             <td><label><input type="checkbox" name="attr_weaptype-pierce" title="@{repeating_weapons_$X_weaptype-pierce}" value="1"/><span></span></label></td>             <td><label><input type="checkbox" name="attr_weaptype-blunt" title="@{repeating_weapons_$X_weaptype-blunt}" value="1"/><span></span></label></td>             <td><input type="text" name="attr_weapspeed" title="@{repeating_weapons_$X_weapspeed}" class="sheet-small"></td>             <td><button type="roll" name="roll_init" title="%{repeating_weapons_$X_init}" value="!group-init --bonus [[0+@{weapspeed}-(@{dexreact})-(@{misc-mod})]], [Initiative (@{weaponname})]">Initiative</button></td>         </tr>     </table>     </fieldset>     <br>     <h4>Melee Damage</h4>     <table>         <tr class="sheet-default-header">             <th class="sheet-centering-padding-2" title="Strength damage adjustment">Str</th>             <th title="Weapon name">Weapon</th>             <th class="sheet-centering-padding-2" title="Specialist: +2">Spec</th>             <th title="Damage adjustment">Damage<br>Adj.</th>             <th colspan="3" title="Damage Small/Medium">Damage S/M</th>             <th colspan="3" title="Damage Large">Damage L</th>         </tr>         <tr class="sheet-centering sheet-collapse">             <td><label><input type='checkbox' title="@{strbonus1}" value='1' checked/><span></span></label></td>             <td><input type="text" title="@{weaponname1}" class="sheet-middle"></td>             <td><label><input type="checkbox" title="@{specialist-damage}" value="2"/><span></span></label></td>             <td><input type="text" title="@{damadj}" class="sheet-table-dynamic" value="0"></td>             <td><input type="text" title="@{damsm}" class="sheet-short"></td>             <td><button type="roll" title="%{attacksm}"></button></td>             <td><button type="roll" title="%{critsm}">Crit</button></td>             <td><input type="text" title="@{daml}" class="sheet-short"></td>             <td><button type="roll" title="%{attackl}"></button></td>             <td><button type="roll" title="%{critl}">Crit</button></td>         </tr>     </table>     <fieldset name="repeating_weapons-damage" title="@{weapons-damage}" class="repeating_weapons-damage">     <table>         <!--  Invisible header row to keep the spacing of all the cells  -->         <tr class="sheet-default-header" style="visibility: collapse;">             <th class="sheet-centering-padding-2">Str</th>             <th>Weapon</th>             <th class="sheet-centering-padding-2">Spec</th>             <th>Damage<br>Adj.</th>             <th colspan="3">Damage S/M</th>             <th colspan="3">Damage L</th>         </tr>         <tr class="sheet-centering">             <td><label><input type='checkbox' name='attr_strbonus1' title="@{repeating_weapons-damage_$X_strbonus1}" value='1' checked/><span></span></label></td>             <td>                 <input type="text" name="attr_weaponname1" title="@{repeating_weapons-damage_$X_weaponname1}" class="sheet-middle sheet-chrome" list="melee-weapons">                 <input type="text" name="attr_weaponname1" title="@{repeating_weapons-damage_$X_weaponname1}" class="sheet-middle sheet-firefox" list="melee-weapons-ff"><span></span>             </td>             <td><label><input type="checkbox" name="attr_specialist-damage" title="@{repeating_weapons-damage_$X_specialist-damage}" value="2"/><span></span></label></td>             <td><input type="text" name="attr_damadj" title="@{repeating_weapons-damage_$X_damadj}" class="sheet-table-dynamic" value="0"></td>             <td><input type="text" name="attr_damsm" title="@{repeating_weapons-damage_$X_damsm}" class="sheet-short"></td>             <td><button type="roll" name="roll_attacksm" title="%{repeating_weapons-damage_$X_attacksm}" value="[[@{damsm}+([[(@{damadj})+(@{specialist-damage})+((@{strengthdmg})*@{strbonus1})+(@{temp-damadj})+(@{misc-mod})]])]]"></button></td>             <td><button type="roll" name="roll_critsm" title="%{repeating_weapons-damage_$X_critsm}" value="/em rolls [[(@{damsm})+(@{damsm})+([[(@{damadj})+(@{specialist-damage})+((@{strengthdmg})*@{strbonus1})+(@{temp-damadj})+(@{misc-mod})]])]] critical damage using their @{weaponname1}! (vs. Small/Medium)">Crit</button></td>             <td><input type="text" name="attr_daml" title="@{repeating_weapons-damage_$X_daml}" class="sheet-short"></td>             <td><button type="roll" name="roll_attackl" title="%{repeating_weapons-damage_$X_attackl}" value="/em rolls [[@{daml}+([[(@{damadj})+(@{specialist-damage})+((@{strengthdmg})*@{strbonus1})+(@{temp-damadj})+(@{misc-mod})]])]] damage using their @{weaponname1}! (vs. Large)"></button></td>             <td><button type="roll" name="roll_critl" title="%{repeating_weapons-damage_$X_critl}" value="/em rolls [[(@{daml})+(@{daml})+([[(@{damadj})+(@{specialist-damage})+((@{strengthdmg})*@{strbonus1})+(@{temp-damadj})+(@{misc-mod})]])]] critical damage using their @{weaponname1}! (vs. Large)">Crit</button></td>         </tr>     </table>     </fieldset>     <br>     <h4>Special Abilities and Attacks</h4>     <textarea name="attr_abilitiesnotes" title="@{abilitiesnotes}" placeholder=""></textarea>     <br>     <h4>Weapon Notes</h4>     <textarea name="attr_weaponnotes" title="@{weaponnotes}" placeholder="Specializing in a melee weapon grants: +1/+2 and extra attacks"></textarea> </div> The Bold text is what I changed to attempt this, so leaving the dmg_s and dmg_l blank it will complete the template just no dmg will obviously be rolled, but if I make {{dmg_s=[ROLL](~{attacksm})}} I get the error that **** has no attrib attacksm.  And this is true if I try to use any @ values from the repeating_weapons-damage fieldset, I'm thinkinhg probably because it hasn't been set yet.  So Ive tried putting the roll code into the weapons-damage set and the opposite happens it gives error on ThAC0, attackadj, etc....and that prevents chat output.  So how do I get all these values together so I can have a HIT button that uses the 2Eattack template?

Apologies Mezz, this isn't something I can assist with (yet!).  @Erik H: fantastic, thanks for that. I spent quite a bit of time just getting it working but you've taken the marco to the next level!

Unless you perfectly know what you are doing, modifying the HTML code is not advised. Your best bet would be to ask Peter B., the actual and skillful maintainer of the ADnD 2 Revised sheet, to modify the buttons of the Weapons tab to use the 2Eattack rolltemplate on the official thread: Official [AD&D 2E Revised] Update thread That being said, and absolutely without any confidence, you may try to replace the value with the following code and test if it works (but I doubt): &{template:2Eattack}{{title=@{selected|token_name} attacks}}{{subtitle=@{target|token_name} with}}{{weapon_used=@{repeating_weapons_$X_weaponname}}}{{ac_hit=[[ @{thac0-base-calc}[ThAC0] - (1d20[ROLL] + (@{strengthhit}*@{repeating_weapons_$X_strbonus}[STR BONUS]) + (@{repeating_weapons_$X_prof-level}[PROF. LEVEL]) + (@{repeating_weapons_$X_attackadj}[ATK ADJ.]) + (@{temp-attackadj}[TEMP. BUFF]) + (?{Misc. Attack Roll Modifier|+0}[HIT MOD.]))]] }}{{dmg_s=[[ @{repeating_weapons-damage_$X_damsm}[DMG SM] + (@{strengthdmg}*@{repeating_weapons_$X_strbonus}[STR BONUS]) + (@{repeating_weapons-damage_$X_specialist-damage}*1)[PROF. DMG] + (@{repeating_weapons-damage_$X_damadj}[DMG ADJ.]) + (@{temp-damadj}[TEMP. BUFF]) + (?{Damage Roll Modifier|+0}[DMG MOD.]) ]] }}{{dmg_l=[[ @{repeating_weapons-damage_$X_daml}[DMG L] + (@{strengthdmg}*@{repeating_weapons_$X_strbonus}[STR BONUS]) + (@{repeating_weapons-damage_$X_specialist-damage}*1)[PROF. DMG] + (@{repeating_weapons-damage_$X_damadj}[DMG ADJ.]) + (@{temp-damadj}[TEMP. BUFF]) + (?{Damage Roll Modifier|+0}[DMG MOD.])]] }} - don't forget to add the " at both end - every attributes (i.e. every @{whatever} ) referenced in the macro above must be filled accordingly in the character sheet - this should only affect the [Hit] buttons located in the repeating_weapons section of the Weapons tab. Using any other button will display the usual text in chat edit: seems I cannot post any link, clicking on 'Submit Post' brings me back to the top of the thread without my answer being posted...

Mezz &nbsp;said: Hello all, I'm using the AD&amp;D 2ed Character Sheet and am trying to use the HIT button with the 2Eattack template, I saw many other places where this happens with there corresponding templates like Checks and Spells. Any help would be great Hello Mezz, Peter B. here, the author maintaining the 2E sheet. I have looked into using the 2Eattack template myself and have discovered several issues. The biggest issue blocking the full usage of the template is the fact that weapon hit and weapon damage is splint into two separate repeating sections.&nbsp; This makes it difficult to ensure any macro has the correct values as you need to ensure the order of elements in both sections, i.e. if your first weapon is a long sword, then you also need the first damage to be that long sword. If you have a weapon with multiple attack modes, such as a Sword of Orc slaying, that deals double damage to orcs, then you need multiple damages for the same weapon, which makes it even harder to keep the correct reference between attack and damage. A bigger problem still is that the damage section for melee weapons create&nbsp; ghost rows &nbsp;for the attack section, which makes it even harder still to keep the reference between attack and damage the same. The only real solution to achieve what you want, is to create a new weapon section that handles both attack and damage, while removing the the ghost rows. If that was made then the template could be used. One section on the sheet where the template can be used is for the monster attacks as they have both attack and damage in a single repeating section. If you have more questions or suggestions for the 2E character sheet feel free to write a post her&nbsp; <a href="https://app.roll20.net/forum/post/9311682/official-ad-and-d-2e-revised-update-thread" rel="nofollow">https://app.roll20.net/forum/post/9311682/official-ad-and-d-2e-revised-update-thread</a> . That way I will get notified and can answer you directly.

Erik H. said: Your best bet would be to ask Peter B., the actual and skillful maintainer of the ADnD 2 Revised sheet Thank you Erik H, for the kind words. I really appreciate them! &lt;3