Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Character Sheet Code In Roll20 Different From That Submitted To GitHub

1693377590

Edited 1693377663
Coryphon
Pro
Sheet Author
Compendium Curator
Hiya, Not sure where to submit this, I have also raised a support ticket. I've ended up with an odd situation. In GitHub I have a line of code: &lt;div style="margin-left: auto;display: flex;align-items: center;margin-right:0;"&gt; However in-game the code is changed to: &lt;div style="margin-left: auto ; display:&nbsp; ; margin-right: 0"&gt; The display setting of flex has been deleted and the following align-items attribute, so there are wrapping issues... It is line 4443 of the Mongoose Traveller Sheet 2E:&nbsp; <a href="https://github.com/brookesi/roll20-character-sheets/blob/master/Mongoose_Traveller2e/MongooseTraveller.html" rel="nofollow">https://github.com/brookesi/roll20-character-sheets/blob/master/Mongoose_Traveller2e/MongooseTraveller.html</a> Obviously it all worked in testing so I don't think there are any e.g. weird unprintable characters or something... Anyone know who I can escalate this to? Regards, Coryphon PS I know it's an inline style, I am stripping them out! However code submitted and merged to GitHub should be what ends up in-game...
1693410770
GiGs
Pro
Sheet Author
API Scripter
Coryphon said: Obviously it all worked in testing How were you testing it?
1693413232

Edited 1693413620
vÍnce
Pro
Sheet Author
I've seen where the vtt may "temporarily" allow some inline css in the inspector(injecting code), but gets sanitized by the vtt after reloading.&nbsp; I don't think github has anything but the most basic code submission checks.&nbsp; Maybe nothing in regards to the code itself.&nbsp; (perhaps it checks for malicious code? IDK ) I wouldn't rely on github as a roll20 "linter". That said, I would hope that our Dev sandbox matches the Prod servers handling of the sheet code.
1693414939
Coryphon
Pro
Sheet Author
Compendium Curator
GiGs said: Coryphon said: Obviously it all worked in testing How were you testing it? Just by pasting the html and css as a custom character sheet…
1693415028
Coryphon
Pro
Sheet Author
Compendium Curator
vÍnce said: I've seen where the vtt may "temporarily" allow some inline css in the inspector(injecting code), but gets sanitized by the vtt after reloading.&nbsp; I don't think github has anything but the most basic code submission checks.&nbsp; Maybe nothing in regards to the code itself.&nbsp; (perhaps it checks for malicious code? IDK ) I wouldn't rely on github as a roll20 "linter". That said, I would hope that our Dev sandbox matches the Prod servers handling of the sheet code. Yes, I imagine it’s a one-off oddity, and all the inline styles will be classes for next release…
1693416101
GiGs
Pro
Sheet Author
API Scripter
Coryphon said: GiGs said: Coryphon said: Obviously it all worked in testing How were you testing it? Just by pasting the html and css as a custom character sheet… I as wondering if you were testing it outside Roll20 somehow, but that doesn't seem to be the case. This isn't related to your question, but I'd urge you to look into the custom sheet sandbox. If you normally use the custom character sheet for testing this will change your life for the better.
1693417270
Coryphon
Pro
Sheet Author
Compendium Curator
GiGs said: Coryphon said: GiGs said: Coryphon said: Obviously it all worked in testing How were you testing it? Just by pasting the html and css as a custom character sheet… I as wondering if you were testing it outside Roll20 somehow, but that doesn't seem to be the case. This isn't related to your question, but I'd urge you to look into the custom sheet sandbox. If you normally use the custom character sheet for testing this will change your life for the better. I will certainly do that, thanks GiGs !