Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

My macro is broken and I can't figure out why. dnd3.5

Title says it all. I couldn't find the problem and neither could the group macro guy. I'm sorry if this isn't the forum preferred formatting for a post, first post here. &{template:DnD35StdRoll} {{skillflag=true}} {{name=@{character_name} }} {{subtags=Full Attack}} {{MH [[1]]: [[1d20cs>19 +@{bab} +1 + 2 + ?{Haste?|No, 0|Yes, 1} + ?{Divine Power?|No, 0|Yes, 4} + ?{Twf?|No, 0|Yes, 1}*-2 + ?{Slippers?|Yes, @{chamod}|No, @{strmod} } + ?{Wardance?|No, 0|Yes, @{chamod} } + ?{Knowledge Devotion?|0} + ?{Charge?|No, 0|Yes, 2} + ?{Flank?|No, 0|Yes, 2} + ?{Misc Attack Mod?|0}]] Damage: [[1d4 + 2 + ?{Slippers?} + ?{Knowledge Devotion?|0}+ ?{Iajutsu?|No, 0|Yes, 9d6} + ?{Misc Damage Mod?|0} + ?{Misc Damage Dice?|0}]] }} {{EX [[?{Haste?}]]: [[1d20cs>19 +@{bab} +1 + 2 + ?{Haste?} + ?{Divine Power?} + ?{Twf?}*-2 + ?{Slippers?} + ?{Wardance?} + ?{Knowledge Devotion?} + ?{Charge?} + ?{Flank?} + ?{Misc Attack Mod?}]] Damage: [[1d4 + 2 + ?{Slippers?} + ?{Knowledge Devotion?}+ ?{Iajutsu?|No, 0|Yes, 9d6} + ?{Misc Damage Mod?} + ?{Misc Damage Dice?}]] }} {{OH [[?{Twf?}]]: [[1d20cs>19 +@{bab} +1 + 2 + ?{Haste?} + ?{Divine Power?} + ?{Twf?}*-2 + ?{Slippers?} + ?{Wardance?} + ?{Knowledge Devotion?} + ?{Charge?} + ?{Flank?} + ?{Misc Attack Mod?}]] Damage: [[1d4 + 2 + ?{Slippers?}*.5 + ?{Knowledge Devotion?}+ ?{Iajutsu?|No, 0|Yes, 9d6} + ?{Misc Damage Mod?} + ?{Misc Damage Dice?}]] }} {{MH [[2]]: [[1d20cs>19 +@{bab} - 5 +1 + 2 + ?{Haste?} + ?{Divine Power?} + ?{Twf?}*-2 + ?{Slippers?} + ?{Wardance?} + ?{Knowledge Devotion?} + ?{Charge?} + ?{Flank?} + ?{Misc Attack Mod?}]] Damage: [[1d4 + 2 + ?{Slippers?} + ?{Knowledge Devotion?}+ ?{Iajutsu?|No, 0|Yes, 9d6} + ?{Misc Damage Mod?} + ?{Misc Damage Dice?}]] }} {{OH [[2*?{Twf?}]]: [[1d20cs>19 +@{bab} - 5 +1 + 2 + ?{Haste?} + ?{Divine Power?} + ?{Twf?}*-2 + ?{Slippers?} + ?{Wardance?} + ?{Knowledge Devotion?} + ?{Charge?} + ?{Flank?} + ?{Misc Attack Mod?}]] Damage: [[1d4 + 2 + ?{Slippers?}*.5 + ?{Knowledge Devotion?}+ ?{Iajutsu?|No, 0|Yes, 9d6} + ?{Misc Damage Mod?} + ?{Misc Damage Dice?}]] }} {{MH [[3]] : [[1d20cs>19 +@{bab} - 10 +1 + 2 + ?{Haste?} + ?{Divine Power?} + ?{Twf?}*-2 + ?{Slippers?} + ?{Wardance?} + ?{Knowledge Devotion?} + ?{Charge?} + ?{Flank?} + ?{Misc Attack Mod?}]] Damage: [[1d4 + 2 + ?{Slippers?} + ?{Knowledge Devotion?}+ ?{Iajutsu?|No, 0|Yes, 9d6} + ?{Misc Damage Mod?} + ?{Misc Damage Dice?}]] }} {{OH [[3*?{Twf?}]]: [[1d20cs>19 +@{bab} - 10 +1 + 2 + ?{Haste?} + ?{Divine Power?} + ?{Twf?}*-2 + ?{Slippers?} + ?{Wardance?} + ?{Knowledge Devotion?} + ?{Charge?} + ?{Flank?} + ?{Misc Attack Mod?}]] Damage: [[1d4 + 2 + ?{Slippers?}*.5 + ?{Knowledge Devotion?}+ ?{Iajutsu?|No, 0|Yes, 9d6} + ?{Misc Damage Mod?} + ?{Misc Damage Dice?}]] }} {{MH [[?{Divine Power?}]] : [[1d20cs>19 +@{bab} - 15 +1 + 2 + ?{Haste?} + ?{Divine Power?} + ?{Twf?}*-2 + ?{Slippers?} + ?{Wardance?} + ?{Knowledge Devotion?} + ?{Charge?} + ?{Flank?} + ?{Misc Attack Mod?}]] Damage: [[1d4 + 2 + ?{Slippers?} + ?{Knowledge Devotion?}+ ?{Iajutsu?|No, 0|Yes, 9d6} + ?{Misc Damage Mod?} + ?{Misc Damage Dice?}]] }} The additional line breaks are just for readability and I know to take them out. Our Macro Guy responded with some notes " Well , I can tell you what is happening , but not why it 's happening . First of all , in MH 3 you have an extra } after the 3((OP: already corrected)) , but that 's not what 's crashing your macro (but it should crash your macro I think , which is weird ) . What is actually crashing your macro is that all queries starting with ? {Misc Damage Mod ? } in OH 3 are just failing . As in they are not being correctly replaced from the previously queried values . This crashes the macro because in MH 4 the [ [ ? {Divine Power ? } ] ] isn 't a number and the roll fails quietly (for your convenience of course ) . You can avert the hard crash by doing something like [ [1 * ? {Divine Power ? } ] ] but the query still isn 't a number , so this just reports 1 every time . Also then OH 3 damage and both MH 4 attack and damage are just broken . That would suggest to me that the issue is either the Iajutsu query or the Misc Damage Mod query in OH 3 , but I text compared them with the previous known working queries and they seem identical , likely because they were copy -pasted . I 'm not sure why this macro doesn 't work , hopefully this was helpful figuring it out . Maybe make a post on the forums ?" Any insights from those who know this programming language much better than we do would be appreciated.
1695938599
Gauss
Forum Champion
Hi Joe, Lets start with that basics, what works, what doesn't work.  Please put this into your game, see if this works (this is just a copy paste of your first two sections):  &{template:DnD35StdRoll} {{skillflag=true}} {{name=@{character_name} }} {{subtags=Full Attack}} {{MH [[1]]: [[1d20cs>19 +@{bab} +1 + 2 + ?{Haste?|No, 0|Yes, 1} + ?{Divine Power?|No, 0|Yes, 4} + ?{Twf?|No, 0|Yes, 1}*-2 + ?{Slippers?|Yes, @{chamod}|No, @{strmod} } + ?{Wardance?|No, 0|Yes, @{chamod} } + ?{Knowledge Devotion?|0} + ?{Charge?|No, 0|Yes, 2} + ?{Flank?|No, 0|Yes, 2} + ?{Misc Attack Mod?|0}]] Damage: [[1d4 + 2 + ?{Slippers?} + ?{Knowledge Devotion?|0}+ ?{Iajutsu?|No, 0|Yes, 9d6} + ?{Misc Damage Mod?|0} + ?{Misc Damage Dice?|0}]] }} If that doesn't work, then we take apart that section and rebuild it until it does. Always assemble macros a piece at a time, to see what exactly causes it to break. 
1695940881
Manny L.
Pro
Marketplace Creator
In case it is of help, I tried your macro the following ways: 1. remove the last block => macro works 2. remove the second block => macro works (had to leave the first block in as it has all the query placeholders) This suggests to me you may have hit a limit of what the roll template can handle, but I don't know much (anything) about roll templates, sorry!
Gauss: Yea I have a single attack version that I use to verify, and for making single attacks, and it works perfectly Manny: That could be, the one it is replacing is more complicated though...It does have one fewer attack ...but our group also has a guy that macros 11 attacks...so maybe but I'm skeptical
1695945400

Edited 1695945456
Gauss
Forum Champion
If there is a user with an 11attack macro you may want to examine that macro and see how it works, perhaps there is a trick to getting the template to accept it.
So after consulting said player they had more attacks but each one called far fewer things and with that in mind I removed 3 queries from each block and now it works. It seems like the problem was in fact hitting the limit of queries and taking these 24 out dropped the total number to below 100 I think, but if so only but a couple and I'm not counting.