how do i allow players to edit the macros ive made for them

i have several macros i made for players, how i allow them to edit them?

I am guessing you made the macros in the Collections tab? Short version: don't do that :) Use the player's Character, put them into Ability macros on the Attributes and Abilities tab. They can edit those. 

i did already do that, is there a way to let them edit one many ive already made for them?

Players can edit Abilities anytime if they have control over their character.  To assign control over the character click Edit.  Then click on In Player's Journals and assign the player(s) Then Click on Can Be Edited & Controlled By and assign the player(s) Now players can go to the Attributes & Abilities tab, hover over the Ability, click the pencil and edit the macro. 

Macros in the Collections tab can only be modified by the player who created them. If that player is a GM then they can set the ‘Visible to’ settings to other players. But they still won’t be able to change them.  Even if you have a Co-GM, they can create Collections Macros that are visible to the Game Creator, who still can’t change the macros.  Instead, copy and paste the same macros into a shared ‘Macro Mule’ character, and give Edit and Control access of that character to all players. Then create Collections Macros to call the macros from the shared character.  Example: create a character named ‘Player Macros’ and give control of that character to your players. Then create an Ability called ‘RollQuery’: [[?{What die roll?|1d20}]] Then create a Collections macro named ‘Roll’: %{Player Macros|RollQuery} &{noerror} Your players will be able to modify the ‘RollQuery’ on the shared character, but they won’t be able to modify the ‘Roll’ Collection macro.