Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

how did yall mess up the MASKS CS?

What in the world did yall do to the Masks CS? it was  practically perfect (except it would be nice if the Playbooks had their moves), and now its all janked up. WTF???
1715292394
keithcurtis
Forum Champion
Marketplace Creator
API Scripter
Hi The Infamous RPG Group, Acct 8 - Superhero! The last person to make a change on that was last week, a sheet designer named  akibi90 . You might want to shoot them a polite inquiry describing the issue. Note that this is a community-generated sheet, not a Roll20 sheet. Also, the last PR I see was a request to roll something back, so you might want to clear cache and cookies, log out and back in again for good measure, and make sure you are not seeing cached data.
Hello, I'm terribly sorry about that. I just wanted to add a black color in the roll dice (to remove gray color in dark mode) I tried to remove my modifications but nothing change. I contacted the creator of the sheet to help me correct this. Sorry for the inconvenience.
1716067485

Edited 1716067595
Stephen C.
Pro
Sheet Author
This is a very curious case. In the version of the sheet that is live right now, there are a number of checkboxes which are visible which shouldn't be. However, going into the HTML reveals that they do have the style="display: none;" attribute properly listed in each one of those elements. Furthermore, loading up the sheet into the custom sheet sandbox properly hides those checkboxes. It also does this in a game with a custom sheet. Using the exact same code, there are different results, depending on what is being used to view the sheet. That is very abnormal, and I didn't even know it was possible. The only thing that I can think of which would cause this is the way in which those attributes are used in the HTML elements. <input type='checkbox' name='attr_lock_playbook' class='sheet-lock' style="display: none;"> Both single quotes and double quotes should be acceptable, but perhaps there's something wonky going on when double quotes are used after single quotes? The reverse doesn't seem to be true, because in this checkbox, the value works properly (and shows up in the browser's Inspect tool, unlike the style). <input type="checkbox" name="attr_playbook" class="sheet-issoldier" value='Soldier' style="display: none;" /> This is rather insidious because you can't actually test out the fix, since everything looks fine in the custom sheet sandbox. But it may be worth a shot. Also, I can't see any reason why Akibi's changes would have led to this issue.
1716067776

Edited 1716068030
vÍnce
Pro
Sheet Author
Stephen C. said: This is a very curious case. In the version of the sheet that is live right now, there are a number of checkboxes which are visible which shouldn't be. However, going into the HTML reveals that they do have the style="display: none;" attribute properly listed in each one of those elements. Furthermore, loading up the sheet into the custom sheet sandbox properly hides those checkboxes. It also does this in a game with a custom sheet. Using the exact same code, there are different results, depending on what is being used to view the sheet. That is very abnormal, and I didn't even know it was possible. The only thing that I can think of which would cause this is the way in which those attributes are used in the HTML elements. &lt;input type='checkbox' name='attr_lock_playbook' class='sheet-lock' style="display: none;"&gt; Both single quotes and double quotes should be acceptable, but perhaps there's something wonky going on when double quotes are used after single quotes? The reverse doesn't seem to be true, because in this checkbox, the value works properly (and shows up in the browser's Inspect tool, unlike the style). &lt;input type="checkbox" name="attr_playbook" class="sheet-issoldier" value='Soldier' style="display: none;" /&gt; This is rather insidious because you can't actually test out the fix, since everything looks fine in the custom sheet sandbox. But it may be worth a shot. Also, I can't see any reason why Akibi's changes would have led to this issue. Seems like sheet author StéphaneD also noticed inline styles being removed on the Live servers (specifically display: none) as well. <a href="https://app.roll20.net/forum/post/11906410/inline-styles-removed" rel="nofollow">https://app.roll20.net/forum/post/11906410/inline-styles-removed</a> Must have been a change by roll20. Might try adding class="hidden" instead of style="display: none;" I believe "hidden" is a system recognized class.
1716069884
StéphaneD
Pro
Sheet Author
API Scripter
Hi Thanks but as I said in my post, all kind of inline styles are sanitized where they shouldn’t Adding a hidden class won’t help with the style="width: 70%; height: 90%" that is removed from the img containing a sheet logo resulting in a messed layout. I have no time to spend changing inline styles to classes. I want Roll20 to answer my support request in a satisfying manner and reverse whatever bug they introduced. That’s one of the reason I’ll use Jumpgate only when there won’t be no other alternative left. I’m not paying 99 bucks a year to do their QA.
1716089696
GiGs
Pro
Sheet Author
API Scripter
Just a clarification: inline styles are different to classes, so Vince's suggestion should work for this - or every style for every sheet would stop working, and the lack of complaints about this tell us this hasn't happened.
1716508567
Stephen C.
Pro
Sheet Author
It looks as though things are back to normal. I've noticed Akibi90 struggling a bit (a lot?) with making a particular change with the rolltemplate, so I took care of that change, and a couple of other minor things as well.
Hey Folks, Sorry about this. Sheet styling was getting sanitized but we've fixed that now. It was a change to something else in the system that was unrelated. This should be working as Stephen C. reported. Sorry for the delay on this. The Infamous RPG Group, Acct 8 - Superhero said: What in the world did yall do to the Masks CS? it was&nbsp; practically perfect (except it would be nice if the Playbooks had their moves), and now its all janked up. WTF??? vÍnce said: Stephen C. said: This is a very curious case. In the version of the sheet that is live right now, there are a number of checkboxes which are visible which shouldn't be. However, going into the HTML reveals that they do have the style="display: none;" attribute properly listed in each one of those elements. Furthermore, loading up the sheet into the custom sheet sandbox properly hides those checkboxes. It also does this in a game with a custom sheet. Using the exact same code, there are different results, depending on what is being used to view the sheet. That is very abnormal, and I didn't even know it was possible. The only thing that I can think of which would cause this is the way in which those attributes are used in the HTML elements. &lt;input type='checkbox' name='attr_lock_playbook' class='sheet-lock' style="display: none;"&gt; Both single quotes and double quotes should be acceptable, but perhaps there's something wonky going on when double quotes are used after single quotes? The reverse doesn't seem to be true, because in this checkbox, the value works properly (and shows up in the browser's Inspect tool, unlike the style). &lt;input type="checkbox" name="attr_playbook" class="sheet-issoldier" value='Soldier' style="display: none;" /&gt; This is rather insidious because you can't actually test out the fix, since everything looks fine in the custom sheet sandbox. But it may be worth a shot. Also, I can't see any reason why Akibi's changes would have led to this issue. Seems like sheet author StéphaneD also noticed inline styles being removed on the Live servers (specifically display: none) as well. <a href="https://app.roll20.net/forum/post/11906410/inline-styles-removed" rel="nofollow">https://app.roll20.net/forum/post/11906410/inline-styles-removed</a> Must have been a change by roll20. Might try adding class="hidden" instead of style="display: none;" I believe "hidden" is a system recognized class.