Unwanted Inline Styles sanitization

Hi All

There is an issue with inline style attributes being removed from legacy community character sheets

The two following threads have reports of the issue :

https://app.roll20.net/forum/post/11896854/how-did-yall-mess-up-the-masks-cs

https://app.roll20.net/forum/post/11906410/inline-styles-removed

To sum it up :

• These two sheets were updated a couple of weeks ago (end of April for the Masks sheet, 1st of May for my ChroniquesGalactiques and ChroniquesOublieesContemporain sheets)
• When rendered on the live server, we see some style="..." attributes being removed, resulting in messed up sheet layouts
• When loaded in the sheet sandbox or when using a "Custom" sheet and pasting the exact same HTML and CSS, the inline styles removal does not happen
• FWIW, both the Masks sheet and my two sheets use the legacy sanitization ("legacy": true in sheet.json)
• Also FWIW, Vince's AD&D1e sheet also uses inline styles, also uses the legacy sanitization, and does not show the issue. But it hasn't been updated and re-deployed to the live server for about a year

Has anyone else seen this behavior lately ?

The old 1e sheet is now effected by this as well.  While the sheet appeared fine last week when this was brought up by StéphaneD, it's now suffering the same issues StéphaneD mentioned. I simply made a small text addition to the sheet last night in the sheet's announcements section
https://github.com/Roll20/roll20-character-sheets/pull/12919/files

But after the pr was merged today, the sheet is now experiencing breaking issues with the layout that were not there before merging.

It looks like all the inline styles are all being ignored. There are tons inline styles on this sheet... Many of these are for hidden inputs for sheet navigation, hide/show, etc. The sheet is only partially functional now. Please figure out and fix why the inline styles are being ignored and why does it only seem to be triggered after updating a sheet?

example(sandbox game on the left, live on the right. Same code base for both...);

I'll submit ticket next...
DONE: [#226710]

Hi Vince,

Got an email update from support.

As an update, this has been more formally reviewed and brought in as a bug that is on our roadmap to improve and address.
I don't have an ETA as of yet for a full fix but I wanted to ensure that you were aware as you helped bring this forward and as a result we are moving this in a positive direction.

At least it has been acknowledged.  That's a plus.  Hopefully it gets figured out soon.

Thank you for the update.

i was wondering if non-legacy sheets (CS enhanced, etc.) are affected or is just the legacy ones?

I'm seeing discrepancies between what we see in the sandbox and what is rendering live.  This is even with a non-legacy sheet that was just merged today. ;-(

I'll need to verify that... I'll post back.
This looks like it was only affecting legacy sheets.

@Mago

There is another Chroniques Oubliees Fantasy character sheet that is maintained by my friend Ulti. He understood what needed to be changed in the HTML and the CSS when CSE came out (I didn’t) and this sheet is defined with legacy set to false in sheet.json. The sheet still has inline styles but doesn’t suffer from the issue. 

StéphaneD said:

@Mago

There is another Chroniques Oubliees Fantasy character sheet that is maintained by my friend Ulti. He understood what needed to be changed in the HTML and the CSS when CSE came out (I didn’t) and this sheet is defined with legacy set to false in sheet.json. The sheet still has inline styles but doesn’t suffer from the issue. 

good to know! i will consider a full conversion to CSE, i believe Roll20 will eventually decide to not support legacy sheets, if they havent done so already