Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

[Query] Pull Request pile-up

Dear Devs, I recently made some modifications to a character sheet and made a pull request with said modifications on the Roll20/roll20-character-sheets repo. I noticed that there's been a growing backlog of pull requests going back to nearly a month now. Is there an issue with the repo or has everyone just been extremely busy for most of October? Sincerely, Brian Q.
1446670950
Lithl
Pro
Sheet Author
API Scripter
I would expect they're busy. They did after all put up two new job openings, so there has probably been considerable time recently devoted to that effort
1446680336
vÍnce
Pro
Sheet Author
I hear you both.  I have changes that came over from a beta version of the PF sheet over 6 weeks ago.  Can't wait to see what that next system update is going to entail though.
1446761612
Kevin
Pro
Sheet Author
API Scripter
The problem is that letting the PRs build up like this causes a more difficult job of merging them. It would be nice to get some kind of movement on at least the oldest ones.
The problem with going so long between updates is that if there is a problem with the sheet, people may just stop playing instead of playing with a gimped out version - sometimes sheets bugs are really frustrating (especially if you accidentally did the bug yourself!).  I think that a certain amount of time needs to be devoted each week for pull requests/merges - like every Friday from 3-6 or something.
1446771127
Lithl
Pro
Sheet Author
API Scripter
Kevin the Barbarian said: The problem is that letting the PRs build up like this causes a more difficult job of merging them. Only if two pull requests contain commits changing the same line in a file. Commits in the same pull request aren't going to trample over each other like that, and if a commit is added to the same repo branch that the request originally came from, it's automatically incorporated into the original pull.
1446832597

Edited 1446832608
Kevin
Pro
Sheet Author
API Scripter
I feel like you're trying to school me on every post I make.
1446872410
Lithl
Pro
Sheet Author
API Scripter
A bunch of the waiting pull requests have been merged in today.