Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

[GitHub] How to change the content of a push request ?

1449830237
sioc
Sheet Author
Hello, I pulled around a month ago a sheet that is not yet validated, since I found a fix to do and an improvement... How can I change the submit without losing the pull request ? I tried to read some support document on Internet and I don't see how to ... Thanks in advance for the help.
1449831229
Lithl
Pro
Sheet Author
API Scripter
Any changes you make to the branch that's going to be pulled will automatically be part of the pull. When you make a request, you're not saying "please pull these changes", you're saying "please pull this branch".
1449847597
vÍnce
Pro
Sheet Author
sioc said: Hello, I pulled around a month ago a sheet that is not yet validated, since I found a fix to do and an improvement... How can I change the submit without losing the pull request ? I tried to read some support document on Internet and I don't see how to ... Thanks in advance for the help. You can submit new commits to your PR with your corrections.  The latest "version" of your PR code(with commit) is what will be merged.  You can also close your PR and submit a new one.  As long as the PR is submitted before the next merge you're new code will get pulled.  If you haven't been merged in over a month, you might want to check to see if there are any issues (AKA merge conflicts).
1449883281
Lithl
Pro
Sheet Author
API Scripter
Vince said: If you haven't been merged in over a month, you might want to check to see if there are any issues (AKA merge conflicts). As I understand it, there's currently a hold on merging character sheets while the sheet worker stuff on dev is being worked on, so that sheet authors don't need to maintain two versions of the sheet.
1449889751
vÍnce
Pro
Sheet Author
You're right, it was confirmed early on by the Devs we didn't need to maintain two versions. They've already merged "some sheets" that include sheet worker scripts and new repeating section updates however.  Not sure what the criteria for making the last merge was, but not everyone's sheets were processed...?