[3.5] Modifiers not working

I have a problem where the 'Misc' modifiers for Ability Scores are not adding fully, only using the first number in the sheet (or occasionally using the first two). My DM wants me to indicate in square brackets where each bonus is coming from, so it is important that I can give the individual bonuses on the sheet. For example, for 'Misc' Strength bonuses I would write: 2[size]+2[racial]+2[levels]+4[warshaper]+2[bracers]+2[arm] Any help solving this would be much appreciated! To clarify, my character's base strength is 18, so the total strength should be: 18+2+2+2+4+2+2=32.   However the total shown on the character sheet is only 20. Even when removing the square brackets the total is still wrong.

It's due to how the bonuses are now calculated. To be able to use the strength to calculate encumbrance, I had to switch from the auto calculated values to using sheetworkers which uses Javascript to grab the values and then uses that to calculate the bonuses. I'm having my resident Javascript guy look into a workaround for this, but no promises. 

So what would you suggest? Using individual values for the misc modifier instead of adding them together separately?

The base, misc, and temp fields expect just a single number.&nbsp; The javascript in the sheet workers doesn't know how to handle the math or the labels so just truncates the value when it finds the first non-numeric character. If you need a place to keep track of where those numbers came from, you could possibly use one of the note fields; either the Other field below and on the right on the same Stats tab or just add a note on the Notes tab.&nbsp; The strength (etc) macro could be edited and a {{notes = Misc bonus= 2[size] +2[racial] +2[levels] +4[warshaper] +2[bracers] +2[arm] }} could be added but that, again, is just a display of the values.&nbsp; I may add a notes fields to the ability scores section like many of the other sections use, to make this easier but that won't be going into effect terribly soon (and again would just be a display). If your DM has a Pro subscription, he could roll back to the previous version of the character sheet by pulling it off of GitHub @ <a href="https://github.com/Roll20/roll20-character-sheets" rel="nofollow">https://github.com/Roll20/roll20-character-sheets</a>... and entering it as a custom character sheet.&nbsp; He will need both the HTML and CSS files. <a href="https://github.com/Roll20/roll20-character-sheets/" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/</a>... (is the Sept 23, 2015 commit which was the one before the sheetworkers).&nbsp; Then it will go back to how the sheet worked two weeks ago.

Great, thank you for the help!

no problem.

Slightly different problem. Some time ago I found (with much tinkering) that strength, enhancements, and other multiplicable damage modifiers are not being calculated in critical damage. I'm not much of a programer, but I found the code for critical damage to have an unnecesary ' ( ' that seemed to be preventing the rest of that block of code from being calculated. No problem; just went into each and every weapon attack of every character and deleted that one character. Making new characters today i don't recognize the code; the offending code used to be easily identifiable as a crowded spot something like ... )]]*([[&nbsp; but thats no longer there. I'm having trouble finding the offending parenthesis,&nbsp; but the problem in calculating critical damage has returned/ remained. Was there an update recently? My previously fixed macros still work fine... so for now i'm just cut and pasting that code.

Hm.&nbsp; I haven't pushed another update since the sheetworkers went in.&nbsp; When I was adjusting the spaces in the macros, I had a temporary issue with a space in the die roll calculation for the crit calc ie: [[...]] d6 instead of [[....]]d6 but I squashed that one long before I pushed things live.&nbsp; I don't see the same issue even with a fresh character on my test campaign (though I only tested the first 3 and 10th weapons). Is there a particular attack number it's showing up in?&nbsp; Could you get me a screenshot showing the problem, preferably mousing-over the crit damage number so I can see the calculation?&nbsp; How are you accessing the macro?&nbsp;

In the weapons tab of the character sheet, the 5th field has the critical damage calculation. Doesn't really work well for weapons that do multiple dice in damage (such as greatswords or large weapons). My work around there was change the first part thusly [[2*(@{weapon1critmult}-1)]]d6 for a 2d6 weapon. For the issue we're talking about though, the second part originally (based on my older characters) looked like this +[[(@{weapon1critmult}-1)]]* ( [[@{weapon1damagestat}]][Weapon Dmg Ability] +@{weapon1enh}[Weapon Enh] +@{weapon1specialize}[Weapon Spec] +?{Power Attack Gradient (positive)|0}[Pwr Attk] So i went through and deleted the extraneous ( bracket and it works fine, though now i realize it also works fine if i were to close it off at the end. however, on new characters as well as any weapon macro i didn't muck with at the time, the critical damage calculation macro (both parts) now looks like this... [[ (@{weapon1critmult}-1) ]]d6 + [[ (@{weapon1critmult}-1) ]] *( @{weapon1damagestat}[Weapon Dmg Ability] +@{weapon1enh}[Weapon Enh] +@{weapon1specialize}[Weapon Spec] +?{Power Attack Bonus?|0}[Pwr Attk] +?{Additional Damage Bonus?|0}[Ad'l Dmg Bon]) ... and on testing... appears to be calculating critical damage properly again... So yay it's working.. but i'm so confused.

oh I see. I think it was originally closed off, but when I went through to either delete power attack where it didn't apply or change the way power attack is handled (single query) I failed to close off the macro with a ")" at the end, resulting in every single critical calculation becoming broken, and again with your new version after repeating my mistakes on that one as well. I will be more careful about that in the future. Thank you for your attention though. Incidentally, the other portion of how power attack is handled was to add this code to the first field &nbsp;+?{Power Attack Gradient (positive)|0}*-1[Pwr Attk] which is how i handle combat expertise as well, though I don't have a way of automatically tracking the AC bonus (yet?). In both cases I throw a multi-sided token on the field with the current modifier displayed.

I'm glad you got it figured out and working again. Happy gaming. :)

@Shnigda I've submitted an update to GitHub: <a href="https://github.com/Roll20/roll20-character-sheets/" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/</a>... This update adds a notes section for each of the Ability stats and moves the notes and the macro to a toggle-hidden area much like the saving throws section.&nbsp; Sadly, my Javascript wizard does not know how to convince Javascript to be able to add an unknown number of potential values together so the notes section is the best I can do to allow you to keep track of where the values come from.&nbsp; The Ability check macro has also been update to output the notes associated with each ability score if they exist. Hope that helps.