Macro Help (5e OGL)

I am currently trying to setup a set of macros so that i don't have to keep opening the character sheet for my most used attacks ect. But i am currently having issues getting them to work correctly even after looking up on the wiki.  Wiki Link I have changed the {{always}} to @{rtype} like the wiki says is doable as i have the character sheets to ask for advantage ect. However  after doing this the macro no longer functions correctly it instead displays like the image. Top to bottom: Normal, Advantage, Disadvantage. 5e OGL Template issue I cant figure out why this is happening as i have tried all the changes i can think of but so far nothing has worked. The macro is below and i would appreciate some help figuring this out. &{template:atkdmg} {{mod= Pb }} {{rname= Bite }} {{r1= [[ 1d20cs>20 + 4 + @{Nogme|pb} ]] }} @{Skriff|rtype} {{r2= [[ 1d20cs>20 + 4 + @{Nogme|pb} ]] }} {{attack=0}} {{range= Melee, Reach 5 feet }} {{damage=1}} {{dmg1flag=1}} {{dmg1= [[2d4 + 4 + @{Nogme|pb} + ?{Favored Enemy|no, 0|yes, 4} ]] }} {{dmg1type= Piecing }} {{damage=1}} {{dmg2flag=}} {{dmg2=}} {{dmg2type=dmg2type }} {{crit1=[[2d4]]}} {{crit2=}} {{save=1}} {{saveattr= Strength }} {{savedesc= Prone on fail}} {{savedc= 11}} {{desc= Skriff savagely bites the target }} ammo=ammo {{charname= Skriff }}

The easiest way would be to configure your attacks on the sheet as normal and drag those Roll from the sheet onto your Macro bar.  You only need to make your own if you're doing something custom that the sheet doesn't already have  (*Like MultiAttack or Monk Flurries*) If you do want to use your own, you can run the macro from the sheet button and just press the up-arrow in the chat window.  That will reveal the code it used.  Keep in mind that this method no longer references the sheet when you use that already-resolved code.

yes this is one of the reasons i am making them as my character already has more rolls ect. to make than the sheet will allow me to enter for a single attack. I prefer not to flood the chat with individual rolls when these templates are here to keep everything together. However I still cant understand why this is not working as i have it setup how the template shows from what i can tell. I have so far tried rearranging the order and changing some values but still to no avail

Kairain said: I am currently trying to setup a set of macros so that i don't have to keep opening the character sheet for my most used attacks ect. But i am currently having issues getting them to work correctly even after looking up on the wiki.  Wiki Link I have changed the {{always}} to @{rtype} like the wiki says is doable as i have the character sheets to ask for advantage ect. However  after doing this the macro no longer functions correctly it instead displays like the image. Top to bottom: Normal, Advantage, Disadvantage. 5e OGL Template issue I cant figure out why this is happening as i have tried all the changes i can think of but so far nothing has worked. The macro is below and i would appreciate some help figuring this out. &{template:atkdmg} {{mod= Pb }} {{rname= Bite }} {{r1= [[ 1d20cs>20 + 4 + @{Nogme|pb} ]] }} @{Skriff|rtype} {{r2= [[ 1d20cs>20 + 4 + @{Nogme|pb} ]] }} {{attack=0}} {{range= Melee, Reach 5 feet }} {{damage=1}} {{dmg1flag=1}} {{dmg1= [[2d4 + 4 + @{Nogme|pb} + ?{Favored Enemy|no, 0|yes, 4} ]] }} {{dmg1type= Piecing }} {{damage=1}} {{dmg2flag=}} {{dmg2=}} {{dmg2type=dmg2type }} {{crit1=[[2d4]]}} {{crit2=}} {{save=1}} {{saveattr= Strength }} {{savedesc= Prone on fail}} {{savedc= 11}} {{desc= Skriff savagely bites the target }} ammo=ammo {{charname= Skriff }} Sorry about the confusion Kairain, apparently I need to make that bit in the wiki about using @{rtype} more clear. I've bolded the section above that should be giving you problems when using @{rtype}. It should look like this: @{Skriff|rtype}cs>20 + 4 + @{Nogme|pb} ]] }} The value of @{rtype} is {{always/advantage/disadvantage}} {{r2=[[1d20 or {{normal}} {{r2=[[0d20 if the sheet is set to only roll a single 1d20. Hope that helps, Scott EDIT: Also it looks like you are referencing attributes from two different characters, Nogme for proficiency bonus and Skriff for rtype, in this macro. Realized this is probably for a pet of some kind and therefore relies on some of the master's attributes for bonuses, my bad. EDIT the second: If you are making these as character abilities (in the attributes and abilities tab) on the associated character, you don't need to specify the character name.

Yes the 2 different characters are meant to be that way as currently trying the ua revised ranger rules in our game which requires the companion to use the rangers proficiency. I am still a bit lost with this however as what am i am using @{rtype} for is to ask me if i wish to roll normal,advantage, disadvantage in a drop down menu like when i click the attack in the character sheet. If i were to select advantage or disadvantage then it would grey out the unused result and ignore it in damage calculation. along with only displaying the 1 roll if selecting normal. This i like as it keeps everything clean and removes likelihood of mix ups. However currently it works if i set it as {{always=1} displaying both rolls every time however this causes it to also display the crit damage bonus if either roll happens to crit regardless of if you are using that roll or not. EDIT image for comparison. this is how it looks when i select from the character sheet 5e OGL from character sheet

Ah, then you can do this: &{template:atkdmg} {{mod= Pb }} {{rname= Bite }} {{r1= [[ 1d20cs>20 + 4 + @{Nogme|pb} ]] }} {{?{(dis)advantage|Normal,{{normal}} {{r2=[[0d20|Advantage,{{advantage}} {{r2=[[1d20|Disadvantage,{{disadvantage}} {{r2=[[1d20 |Both,{{always}} {{r2=[[1d20 }cs>20 + 4 + @{Nogme|pb} ]] }} {{attack=0}} {{range= Melee, Reach 5 feet }} {{damage=1}} {{dmg1flag=1}} {{dmg1= [[2d4 + 4 + @{Nogme|pb} + ?{Favored Enemy|no, 0|yes, 4} ]] }} {{dmg1type= Piecing }} {{damage=1}} {{dmg2flag=}} {{dmg2=}} {{dmg2type=dmg2type }} {{crit1=[[2d4]]}} {{crit2=}} {{save=1}} {{saveattr= Strength }} {{savedesc= Prone on fail}} {{savedc= 11}} {{desc= Skriff savagely bites the target }} ammo=ammo {{charname= Skriff }} If you don't want the option for rolling both, just delete the bolded section. Unfortunately, it is not possible to utilize the sheet generated roll query for normal/(dis)advantage (or at least I haven't found a way as of yet). So, you need to do it yourself.

This also doesn't seem to work however has given me a new idea to try out

What is it doing incorrectly? Although, glad I inspired a new idea ;) Instead of the complicated roll query above, you can do this: &{template:atkdmg} {{mod= Pb }} {{rname= Bite }} {{r1= [[ 1d20cs>20 + 4 + @{Nogme|pb} ]] }} {{?{(dis)advantage|Normal,normal|Advantage,advantage|Disadvantage,disadvantage}}} {{r2= [[ 1d20cs>20 + 4 + @{Nogme|pb} ]] }} {{attack=0}} {{range= Melee, Reach 5 feet }} {{damage=1}} {{dmg1flag=1}} {{dmg1= [[2d4 + 4 + @{Nogme|pb} + ?{Favored Enemy|no, 0|yes, 4} ]] }} {{dmg1type= Piecing }} {{damage=1}} {{dmg2flag=}} {{dmg2=}} {{dmg2type=dmg2type }} {{crit1=[[2d4]]}} {{crit2=}} {{save=1}} {{saveattr= Strength }} {{savedesc= Prone on fail}} {{savedc= 11}} {{desc= Skriff savagely bites the target }} ammo=ammo {{charname= Skriff }} Didn't suggest this one before because the second roll will still be rolled, but not displayed if you select normal. This is only noticeable with 3d dice on.

Thanks for the help Yours is slightly off as you have missed the needed value, But this less complicated one appears that it works if you set it up as follows.  &{template:atkdmg} {{mod= Pb }} {{rname= Bite }} {{r1= [[ 1d20cs>20 + 4 + @{Nogme|pb} ]] }} {{?{(dis)advantage|Normal,normal=1|Advantage,advantage=1|Disadvantage,disadvantage=1}}} {{r2= [[ 1d20cs>20 + 4 + @{Nogme|pb} ]] }} {{attack=0}} {{range= Melee, Reach 5 feet }} {{damage=1}} {{dmg1flag=1}} {{dmg1= [[2d4 + 4 + @{Nogme|pb} + ?{Favored Enemy|no, 0|yes, 4} ]] }} {{dmg1type= Piecing }} {{damage=1}} {{dmg2flag=}} {{dmg2=}} {{dmg2type=dmg2type }} {{crit1=[[2d4]]}} {{crit2=}} {{save=1}} {{saveattr= Strength }} {{savedesc= Prone on fail}} {{savedc= 11}} {{desc= Skriff savagely bites the target }} ammo=ammo {{charname= Skriff }} This may be worth adding to the wiki.