Detailed description of the problem When creating a custom Fx, the wiki states that the onDeath tag should use the format "effect-color" when using preset effects. This does not work as written for several reasons. onDeath is using internal names instead of displaynames to spawn fx. "onDeath": "explosion-magic" would not work because the effect is called "explode" internally. onDeath doesn't check for preset effects when searching for valid values. The code $fxType.find(":contains(" + r.onDeath + ')[data-custom="true"]').first().val();
a && a !== t && (e.onDeath = a + "|duration:10") searches for the name written in the onDeath tag from the list on the tabletop, makes sure it isn't itself (no recursion), and then gives it a duration of 10. The important point here is [data-custom="true"] which searches the selection box for only user-created Fx. Minimum number of steps to reproduce the problem Create a custom Fx Add "onDeath": "explosion-magic" to the effect Test Description of Setup Chrome 75 Broken with/ without plugins Windows 10 Proposed Solution(s) Document wiki to include stipulation that preset-color pairs will not work and this is intentional. If this is the intention of the current wording, please clarify. Allow preset-color pairs past the check As 2, but also allow tag additions/ overwrites in the form of "|tag:value" #1 can be done immediately if it is intentional, #2 and #3 require the same amount of work since the spawnFx function will already accept these values if they come from the preset. Proposed Workarounds Document wiki indicating this feature does not work like documented until team clarification. Recreate effects needed using custom effects. effect-color pairs will have to be made explicitly. To facilitate #2, I have extracted the internal definitions of the effects and updated them here on the wiki . Most people probably won't comment on this bug report, like my last one, because there isn't much to say. I will be bumping this thread every 45 days to keep it from getting locked. If you are a moderator who can see deleted messages, I apologize in advance.
