My macros for my Monster Manuals aren't working properly

I'm starting a campaign using 5E dnd. (Played on Roll20 for awhile but 2nd edition dnd) So I'm setting up my Monster manual and Monster Tokens. I set up the Monster NPC sheet, seach out the monster using the i icon, and copy and paste. (This works fine.) To set up their attack macro on the monster token, i go to the sheet, hit the attack, go to the chat section, press up and copy that macro to the Abilities and Attributes section. When I use the attack button from the token, it rolls 2d20s. 1 for the attack and 1 for the damage. (the 1d20 for damage is for all token damages such as a Bugbear or a Gnoll standard attack.) What am I doing wrong?

Maybe you didn't quite get all the macro copied (the ones on the fancier sheets are huge)?  Another thing you might try is to enable the quick macro bar at the bottom of your screen.  Drag an attack there and roll it from there.  Put your cursor in chat and hit the up arrow.  That should give you a condensed command that will pull the same attack.  Put that in your token ability and see if that works for you.

I've been playing around with this since I posted the question. I started a new campaign using the 5E sheet from Roll20. I created a Bugbear for the Monster manual. I went to the information icon and searched bugbear. I pulled the bugbear over to the sheet and it auto populated as it is supposed to Before I even made the attack macro on the token, I went to the Character Sheet in the Monster Manual section, opened it and clicked on Mourning Star. In the chat window both attack and damage dice was a d20. (damage breakdown when you put your cursor over the result was a 16 on a d20 +4 for a total of 19. Looks like I'm going to have to figure out how to create damage macros. (Lots of work, but possible.) I just wish I could use the standard method as it is MUCH easier.

I'm guessing from your description, that you have two settings on your character sheet that are set in such a way as to produce this output. 1) is "Roll Queries: always roll advantage". This will show the 2d20 rolls you are seeing. They are both "to hit" rolls. This is one of the rolling alternatives that saves you the step of toggling or querying for advantage/disadvantage. If there is no mod to the roll, use the one on the left, otherwise choose the higher or lower as appropriate. 2) is "Auto Damage Roll: Don't Auto Roll Damage". This setting means that when you roll an attack, the damage does not display immediately. Instead, you must click on the attack name in the output to show the damage. Many players do not like to see the damage unless the roll was a hit. Change this to "Auto Roll Damage & Crit" and the damage will display automatically upon rolling the attack. My suggestion is to play with these alternatives until you find the one you like, then change them in you game settings page (outside the game) to be the default behavior. You can then go back into the game and use the Experimental Settings to apply them to existing in-game content. Instructions here .

Here is an example of the change in settings. In the first auto damage is off. To get damage, click on the pink word "Attack" It will roll and display damage. In the second, the damage is set to roll automatically.

On my PC character sheets I have settings as toggle advantage so I have a normal and buttons for Advantage and Disadvantage. I do have auto roll damage on. But this is an NPC. (So instead of using Charactermancer I selected create NCP the middle button of the three options.) Does the settings from my PC sheets effect my NPC sheets as well? Additional information for you two know. I have the dice roll animation on. Only two d20s roll, not an additional third dice for damage. In the chat window (if you hover the mouse over the results.) It breaks down the results for attack and damage rolls. the Damage dice is a 20. I'll log in and capture any sceenshots that you would like, just let me know. 

The screen shots of the output, plus a screen shot of the sheet settings are that shows the roll options would be helpful, as well as posting the text of the problematic bugbear macro. Put together, those should help track down wherever the issue is occurring.

Let me know if you need more. I didn't take screen shots of clicking the weapon on the NPC Bugbear and then going to chat, hitting the up button in chat to get the macro to copy and paste to the Abilities and Attributes section, but the full macro is pictured and labled # 4

Ok Keith, I see the problem. It is just two advantage rolls with NO damage roll. I have to click on the weapon name "Mouringstar" in the chat window and Im' getting two d8 rolled on the screen. I'll just have to look for a macro that doesn't roll attack and damage with advantage and both in one roll.

If you click "Auto damage and Crit" on the bugbear, and then click the attack and copy the resulting macro, that macro will display damage when you attack. Roll settings are on a per-character basis, not a per-game basis. You are seeing two d20s roll on the attack because Roll20 always rolls 2 d20s if 2d20's might be needed. The roll template hides one from you depending on your selection. Dice macros do not have any conditional logic, so it has to roll2d20s if there is even the possibility that 2 will be needed. The roll template can conditionally hide dice you don't need to see, but it will always roll them. If you click the option I indicated, your macro should read: @{Bugbear|wtype}&{template:npcaction} {{attack=1}} {{damage=1}} {{dmg1flag=1}} @{Bugbear|npc_name_flag} {{rname=Morningstar}} {{r1=[[@{Bugbear|d20}+(4+0)]]}} @{Bugbear|rtype}+(4+0)]]}} {{dmg1=[[2d8 + 2+0]]}} {{dmg1type=piercing}} {{dmg2=[[+0]]}} {{dmg2type=}} {{crit1=[[2d8+0]]}} {{crit2=[[+0]]}} {{description=}} @{Bugbear|charname_output} If you want only one 3D d20 to show on an attack roll, set Roll Queries to "Never Roll Advantage".

Note, if you want crit damage to roll automatically, the dice roller will always roll twice the number of dice needed. The roller doesn't know if a crit has happened when the dice are thrown. If you roll damage by clicking the attack name button in chat, it will roll only the dice needed, crit or not. If you can describe what you want to see when you click the attack, I can make a screen shot of the proper settings, and you can generate your macro from that.