Attack macro help needed

Pro

Sheet Author

API Scripter

This section of your code is the issue. /w @{selected|token_name} &{template:default}{{name=ATTACKS}}{{[@{selected|weaponname}](! #ATTACK1)}}{{[@{selected|repeating_weapons_$0_weaponname}](! #ATTACK2)}}{{[@{selected|repeating_weapons_$1_weaponname}](! #ATTACK3)}}{{[@{selected|repeating_weapons_$2_weaponname}](! #ATTACK4)}}{{[@{selected|repeating_weapons_$3_weaponname}](! #ATTACK5)}}{{[@{selected|repeating_weapons_$4_weaponname}](! #ATTACK6)}}{{[@{selected|repeating_weapons_$5_weaponname}](! #ATTACK7)}} When making API buttons you need to insert the carriage return code after the !, as described in the wiki.  The above section should be /w @{selected|token_name} &{template:default}{{name=ATTACKS}} {{[@{selected|weaponname}](!&#13;#ATTACK1)}} {{[@{selected|repeating_weapons_$0_weaponname}](!&#13;#ATTACK2)}} {{[@{selected|repeating_weapons_$1_weaponname}](!&#13;#ATTACK3)}} {{[@{selected|repeating_weapons_$2_weaponname}](!&#13;#ATTACK4)}} {{[@{selected|repeating_weapons_$3_weaponname}](!&#13;#ATTACK5)}} {{[@{selected|repeating_weapons_$4_weaponname}](!&#13;#ATTACK6)}} {{[@{selected|repeating_weapons_$5_weaponname}](!&#13;#ATTACK7)}} linebreaks inserted for clarity. Remove them. when you save a macro that contains html entities, you cannot reopen it after saving it . When you open a macro, all html characters will be parsed, and converted into the characters they represent. That's why your code has linebreaks in it - the macro has been reopened and the html entities have been processed and removed. Note: this doesnt happen with character sheet abilities, so if you can save this as an ability on your character sheet, you'd avoid this issue. If you're the GM, you can make a character sheet called Macros, set it as editable by everyone, and put such macros as Abilities on that sheet. Then anyone can use them. One question: is that first button (selected| weaponname ) a correct reference?

1577749254

Pro

I appreciate the reply but it did not fix the issue result is exactly the same. whether i run it from a character sheet or as a macro.

1577749290

Pro

and yes the first button is a correct reference as it is one of the few that work

1577750159

Edited 1577750177

Pro

Sheet Author

API Scripter

I'd suggest trying to recreate my version of the macro, and make sure you remove the linebreaks. I just created it in a custom game, and get this: The names after the first are that way because the sheet I'm testing doesnt have a repeating_weapons section, so it just prints the text in the macro. But you can see the buttons are there, properly formed. And they work.

1577750278

Pro

By line breaks what do you mean

1577750813

Edited 1577750839

Pro

Sheet Author

API Scripter

The code I pasted above was organised so you could see the full text, because i made each section a new line: /w @{selected|token_name} &{template:default}{{name=ATTACKS}} {{[@{selected|weaponname}](!&#13;#ATTACK1)}} {{[@{selected|repeating_weapons_$0_weaponname}](!&#13;#ATTACK2)}} {{[@{selected|repeating_weapons_$1_weaponname}](!&#13;#ATTACK3)}} {{[@{selected|repeating_weapons_$2_weaponname}](!&#13;#ATTACK4)}} {{[@{selected|repeating_weapons_$3_weaponname}](!&#13;#ATTACK5)}} {{[@{selected|repeating_weapons_$4_weaponname}](!&#13;#ATTACK6)}} {{[@{selected|repeating_weapons_$5_weaponname}](!&#13;#ATTACK7)}} But in your macro or ability, it should be a single line, with no manual linebreaks, like this: /w @{selected|token_name} &{template:default}{{name=ATTACKS}} {{[@{selected|weaponname}](!&#13;#ATTACK1)}} {{[@{selected|repeating_weapons_$0_weaponname}](!&#13;#ATTACK2)}} {{[@{selected|repeating_weapons_$1_weaponname}](!&#13;#ATTACK3)}} {{[@{selected|repeating_weapons_$2_weaponname}](!&#13;#ATTACK4)}} {{[@{selected|repeating_weapons_$3_weaponname}](!&#13;#ATTACK5)}} {{[@{selected|repeating_weapons_$4_weaponname}](!&#13;#ATTACK6)}} {{[@{selected|repeating_weapons_$5_weaponname}](!&#13;#ATTACK7)}} In the macro box, it will wrap over several lines, which makes it look like  it has linebreaks when it doesnt. But for templates to work properly, they must be on a single line. And remember to make sure your code has these characters where they should be:  &#13;

1577758312

Pro

So it works but still the weird breaks I added weapons 1 at a time and all was fine until I added the weapons in the damage section and that is when all the strangeness happens so at this point I believe it is an issue with the way the macro calls on the sheet so back to the drawing board but thanks a ton for your help

1577763691

Pro

Sheet Author

API Scripter

The only thing i can think of is there are some weird characters in one or more of the weapon names. Nothing else in this macro directly accesses the character sheet, until you press one of the buttons. The contents of the attack macros cannot affect the way this is displayed. Is there more to the macro than you shared above? if you share the full thing, we might be able to get to the bottom of it.

1578161817

Pro