Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Broken Damage Macro Constantly Does Exactly 40 dmg + die dmg

1580452202

Edited 1580452686
As the title says. For some reason my damage calculator macro is busted. I know my weapons macros are advanced and deal with allot of variables but for the life of me I can't figure out what the cause of this is so I can't go into the macro to fix it. I will post all 6 macros below in order from left to right on the 3.5 character sheet weapons section. I use sneak attack as well as have feats and items that let me add on my level cha and dex mods to damage rolls and my dex and str mods to attack rolls. I also stealth and flank allot so there are variables in there to ask what conditions are applicable and apply the correct bonus's accordingly. The macro still asks for all the input correctly with the pop up screens but when you mouse over the results it doesn't show any of that input and instead shows the die roll + 40 static no matter what. Any and all help is much appreciated!  As promised the macros are below: 1d20cs>@{weapon2critmin} +@{bab}[BAB] +@{epicattackbonus}[Epic AB] +@{weapon2stat}[Ability] +@{size}[size] +@{weapon2enh}[Weapon Enh] +@{weapon2focus}[Weapon Focus] +?{Invis?|Yes,2|No,0}[Invis] +?{Flank?|Yes,2|No,0}[Flank] +?{Additional Attack Bonus?|0}[Ad'l Atk Bon] &{template:DnD35Attack} {{pcflag=true}} {{name=@{character_name}}} {{subtags=attacks with a @{weapon1name} }} {{attack1=hitting AC [[ @{weapon1attackcalc} ]] }} {{critconfirm1=Crit?: [[ @{weapon1attackcalc} ]] }} {{damage1=for [[ @{weapon1damage} ]]dmg}} {{critdmg1=+ [[ @{weapon1crit} ]] crit dmg}} {{fullattackflag= [[ 0d1 ]] }}  &{template:DnD35Attack} {{pcflag=true}} {{name=@{character_name}}} {{subtags=attacks with a @{weapon1name} }} {{attack1=A1: [[ @{weapon1attackcalc} ]] }} {{critconfirm1=Crit?: [[ @{weapon1attackcalc} ]] }} {{damage1=D1: [[ @{weapon1damage} ]] }} {{critdmg1= [[ @{weapon1crit} ]] }} {{fullattackflag= [[ ?{Full Attack?|No, 0d1|Yes, d1} ]] }} {{attack2=A2: [[ @{weapon1attackcalc}-3 ]] }} {{critconfirm2=Crit!: [[ @{weapon1attackcalc}-3 ]] }} {{damage2=D2: [[ @{weapon1damage} ]] }} {{critdmg2= [[ @{weapon1crit} ]] }} {{attack3=A3: [[ @{weapon1attackcalc}-6 ]] }} {{critconfirm3=Crit!: [[ @{weapon1attackcalc}-6 ]] }} {{damage3=D3: [[ @{weapon1damage} ]] }} {{critdmg3= [[ @{weapon1crit} ]] }} {{attack4=A4: [[ @{weapon1attackcalc}-9 ]] }} {{critconfirm4=Crit!: [[ @{weapon1attackcalc}-9 ]] }} {{damage4=D4: [[ @{weapon1damage} ]] }} {{critdmg4= [[ @{weapon1crit} ]] }} {{attack5=A5: [[ @{weapon1attackcalc}-12 ]] }} {{critconfirm5=Crit!: [[ @{weapon1attackcalc}-12 ]] }} {{damage5=D5: [[ @{weapon1damage} ]] }} {{critdmg5= [[ @{weapon1crit} ]] }} 1d10+?{Sneak?|Yes,[[?{Sneak Amount|14}|No,0]]d6r1}[Sneak Attack]+?{Flat Footed|Yes,@{dexmod}[FF Dex]|No,0} +@{dexmod}[Dex] +2 +@{weapon1damagestat}[Weapon Dmg Ability] +@{weapon1enh}[Weapon Enh] +@{weapon1specialize}[Weapon Spec] +?{Additional Damage Bonus?|0}[Ad'l Dmg Bon] +@{Tink|chamod}[Cha] ]] [[ (@{weapon1critmult}-1) ]]d10 + [[ (@{weapon1critmult}-1) ]] *( +@{weapon1damagestat}[Weapon Dmg Ability] +@{weapon1enh}[Weapon Enh] +@{weapon1specialize}[Weapon Spec] +?{Craven?|Yes,@{Level}[Level] |No,} +?{Flat Footed|Yes,@{dexmod}[FF Dex]|No,0} +@{dexmod}[Dex] +@{Tink|chamod}[Cha] +?{Additional Damage Bonus?|0}[Ad'l Dmg Bon]) &{template:DnD35Attack} {{pcflag=true}} {{name=@{character_name}'s @{weapon1name} }} {{damage1=does [[ @{weapon1damage} ]]damage}} {{fullattackflag= [[ 0d1 ]] }} EDIT!!!!!:  So I was able to get the Cha and dex mods to change on the damage end of it finally however I realized part of why the static damage is so high is it is adding 1 point of static damage per sneak die instead of actually rolling a sneak die for some reason. Any help fixing the sneak attack portion would be super appreciated :O
1580466410
Ziechael
Forum Champion
Sheet Author
API Scripter
You appear to have a surplus set of ]] at the end of your damage macro which could be causing problems. Do you get the expected outcome when you just run: [[ 1d10+?{Sneak?|Yes,[[?{Sneak Amount|14}|No,0]]d6r1}[Sneak Attack]+?{Flat Footed|Yes,@{dexmod}[FF Dex]|No,0} +@{dexmod}[Dex] +2 +@{weapon1damagestat}[Weapon Dmg Ability] +@{weapon1enh}[Weapon Enh] +@{weapon1specialize}[Weapon Spec] +?{Additional Damage Bonus?|0}[Ad'l Dmg Bon] +@{Tink|chamod}[Cha] ]] in the chat? Also, the sneak portion seems needlessly complex, instead of asking yes or no then asking the amount which seems static anyway why not replace: ?{Sneak?|Yes,[[?{Sneak Amount|14}|No,0]]d6r1}[Sneak Attack] with [[ ?{Sneak?|Yes,14 d6r1 |No,0} ]][Sneak Attack] You could likely replace the 14 with something more dynamic so you don't have to update the macro each time you level?
1580501984

Edited 1580502438
Ziechael said: You appear to have a surplus set of ]] at the end of your damage macro which could be causing problems. Do you get the expected outcome when you just run: [[ 1d10+?{Sneak?|Yes,[[?{Sneak Amount|14}|No,0]]d6r1}[Sneak Attack]+?{Flat Footed|Yes,@{dexmod}[FF Dex]|No,0} +@{dexmod}[Dex] +2 +@{weapon1damagestat}[Weapon Dmg Ability] +@{weapon1enh}[Weapon Enh] +@{weapon1specialize}[Weapon Spec] +?{Additional Damage Bonus?|0}[Ad'l Dmg Bon] +@{Tink|chamod}[Cha] ]] in the chat? Also, the sneak portion seems needlessly complex, instead of asking yes or no then asking the amount which seems static anyway why not replace: ?{Sneak?|Yes,[[?{Sneak Amount|14}|No,0]]d6r1}[Sneak Attack] with [[ ?{Sneak?|Yes,14 d6r1 |No,0} ]][Sneak Attack] You could likely replace the 14 with something more dynamic so you don't have to update the macro each time you level? When trying to run just that in the chat I get TypeError: Cannot read property 'substring' of undefined True about the sneak. I could make it less complex. I had done that because allot of my martial maneuvers feats and other things make it where the amount of sneak die I use on a given turn may not be the full amount as I might sacrifice them for other things situationally. So the ability to take them off is nice. It wouldn't be AS big of an issue if I didn't have the "r1" section in there from an item rerolling 1s as I'd just look at the last few die rolls and say "this much less dmg" when I do do less sneaks but it gets more confusing with the rerolls. Thanks for the catch on the surplus of brackets! I'm gonna fix that now out of OCD and I'll let you know if it changes anything :O (as soon as I took the brackets off it broke lol and gave me this " does [[ 1d10+68damage " so I put them back on there >"<