5e OGL macro to roll a weapons damage without having to add it to the NPC sheet

Hi. I want Monsters with the same npc sheet to be able to use all kind of weapon types on the fly. Normally I would have to add those attacks to the character sheet, but thats way to much work. So I Frankensteined a little macro.  But since I don't know anything about the types of drop down menus or what an "rtype" is, it looks rather ghastly. So maybe someone here can understand my intent and clean it up? Maybe even explain those basics to me I missused? Oh and I have no clue on how to make the macro check if DEX or STR would be better for a finesse weapon. If thats even possible. triggering a query would be fine too. Here it is: @{selected|wtype}&{template:simple} @{selected|rtype}?{Stat |Battleaxe,*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Battleaxe (V),*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Club,*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Hand Crossbow,*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Heavy Crossbow,*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Light Crossbow,*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Dagger,*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Dart,*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Flail,*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Glaive,*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Greataxe,*0 + 1d12 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d12 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Greatsword,*0 + 2d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 2d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Halberd,*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Handaxe,*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Javelin,*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Lance,*0 + 1d12 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d12 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Light Hammer,*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Longbow,*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Longsword,*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Longsword (V),*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Mace,*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Maul,*0 + 2d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 2d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Morningstar,*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Pike,*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Quarterstaff,*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Quarterstaff (V),*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Rapier,*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Scimitar,*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Shortbow,*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Sickle,*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Sling,*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Spear,*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Spear (V),*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Trident,*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d6 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |War Pick,*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Warhammer,*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d8 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Warhammer (V),*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d10 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] |Whip,*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{rname=^{charisma-u}}} {{mod=[[ [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]]}} {{r1=[[@{selected|d20}*0 + 1d4 + [[@{selected|strength_mod}]][STR] + [[@{selected|pb}]][pb] ]] }}} @{selected|global_skill_mod} @{selected|charname_output}

{@{selected|strength_mod},@{selected|dexterity_mod}}kh1    should handle the dex vs str comparison.  You'd have to replace the comma and end-braces with HTML replacements in order to use it in a drop-down query, of course.

But not the braces in the attribute lookups, as I understand it.

@{selected|wtype}&{template:npcaction} {{attack=1}} {{damage=1}} {{dmg1flag=1}} @{selected|npc_name_flag} {{rname=rname}} {{r1=[[@{selected|d20} ?{Attack Modifier |STR,+@{selected|strength_mod}+@{selected|pb} |DEX,+@{selected|dexterity_mod}+@{selected|pb}}]]}} @{selected|rtype}?{Attack Modifier |STR,+(@{selected|strength_mod})+(@{selected|pb}) |DEX,+@{selected|dexterity_mod}+@{selected|pb}}]]}} {{dmg1=[[?{Waffe |Battleaxe,1d8 + @{selected|strength_mod} |Battleaxe (V),1d10 + @{selected|strength_mod} |Club,1d4 + @{selected|strength_mod} |Hand Crossbow,1d6 + @{selected|dexterity_mod} |Heavy Crossbow,1d10 + @{selected|dexterity_mod} |Light Crossbow,1d8 + @{selected|dexterity_mod} |Dagger,1d4 + @{selected|dexterity_mod} |Dart,1d4 + @{selected|dexterity_mod} |Flail,1d8 + @{selected|strength_mod} |Glaive,1d10 + @{selected|strength_mod} |Greataxe,1d12 + @{selected|strength_mod} |Greatsword,2d6 + @{selected|strength_mod} |Halberd,1d10 + @{selected|strength_mod} |Handaxe,1d6 + @{selected|strength_mod} |Javelin,1d6 + @{selected|strength_mod} |Lance,1d12 + @{selected|strength_mod} |Light Hammer,1d4 + @{selected|strength_mod} |Longbow,1d8 + @{selected|dexterity_mod} |Longsword,1d8 + @{selected|strength_mod} |Longsword (V),1d10 + @{selected|strength_mod} |Mace,1d6 + @{selected|strength_mod} |Maul,2d6 + @{selected|strength_mod} |Morningstar,1d8 + @{selected|strength_mod} |Pike,1d10 + @{selected|strength_mod} |Quarterstaff,1d6 + @{selected|strength_mod} |Quarterstaff (V),1d8 + @{selected|strength_mod} |Rapier,1d8 + @{selected|dexterity_mod} |Scimitar,1d6 + @{selected|dexterity_mod} |Shortbow,1d6 + @{selected|dexterity_mod} |Sickle,1d4 + @{selected|dexterity_mod} |Sling,1d4 + @{selected|dexterity_mod} |Spear,1d6 + @{selected|strength_mod} |Spear (V),1d8 + @{selected|strength_mod} |Trident,1d6 + @{selected|strength_mod} |War Pick,1d8 + @{selected|strength_mod} |Warhammer,1d8 + @{selected|strength_mod} |Warhammer (V),1d10 + @{selected|strength_mod} |Whip, 1d4 + @{selected|dexterity_mod}}]]}} {{dmg1type=piercing}} {{dmg2=[[+@{selected|pb}]]}} {{dmg2type=}} {{crit1=[[4d6+0]]}} {{crit2=[[@{selected|pb}]]}} {{description=}} @{selected|charname_output}

Also so ist es schonmal schöner Ich werd ma versuchen den STR/DEX vergleich einzubauen

Id like to run the following in the query for "finesse". Someone an idea? |Dagger,1d4 + {@{selected|strength_mod}d1,@{selected|dexterity_mod}d1}kh1

Ok, this works 99%. Only problem: if its two negative modifiers in STR and DEX, it will take the lower one But how often does that happen? @{selected|wtype}&{template:npcaction} {{attack=1}} {{damage=1}} {{dmg1flag=1}} @{selected|npc_name_flag} {{rname=Chosen Weapon}} {{r1=[[@{selected|d20} ?{Attack Modifier |STR,+@{selected|strength_mod}+@{selected|pb} |DEX,+@{selected|dexterity_mod}+@{selected|pb}}]]}} @{selected|rtype}?{Attack Modifier |STR,+(@{selected|strength_mod})+(@{selected|pb}) |DEX,+@{selected|dexterity_mod}+@{selected|pb}}]]}} {{dmg1=[[?{Waffe |Battleaxe,1d8 + @{selected|strength_mod} |Battleaxe (V),1d10 + @{selected|strength_mod} |Club,1d4 + @{selected|strength_mod} |Hand Crossbow,1d6 + @{selected|dexterity_mod} |Heavy Crossbow,1d10 + @{selected|dexterity_mod} |Light Crossbow,1d8 + @{selected|dexterity_mod} |Dagger,1d4 + (((@{selected|strength_mod}+10+@{selected|dexterity_mod})/2)+(1/2*(@{selected|strength_mod}+10-@{selected|dexterity_mod}))-10) |Dart,1d4 + (((@{selected|strength_mod}+10+@{selected|dexterity_mod})/2)+(1/2*(@{selected|strength_mod}+10-@{selected|dexterity_mod}))-10) |Flail,1d8 + @{selected|strength_mod} |Glaive,1d10 + @{selected|strength_mod} |Greataxe,1d12 + @{selected|strength_mod} |Greatsword,2d6 + @{selected|strength_mod} |Halberd,1d10 + @{selected|strength_mod} |Handaxe,1d6 + @{selected|strength_mod} |Javelin,1d6 + @{selected|strength_mod} |Lance,1d12 + @{selected|strength_mod} |Light Hammer,1d4 + @{selected|strength_mod} |Longbow,1d8 + @{selected|dexterity_mod} |Longsword,1d8 + @{selected|strength_mod} |Longsword (V),1d10 + @{selected|strength_mod} |Mace,1d6 + @{selected|strength_mod} |Maul,2d6 + @{selected|strength_mod} |Morningstar,1d8 + @{selected|strength_mod} |Pike,1d10 + @{selected|strength_mod} |Quarterstaff,1d6 + @{selected|strength_mod} |Quarterstaff (V),1d8 + @{selected|strength_mod} |Rapier,1d8 + (((@{selected|strength_mod}+10+@{selected|dexterity_mod})/2)+(1/2*(@{selected|strength_mod}+10-@{selected|dexterity_mod}))-10) |Scimitar,1d6 + (((@{selected|strength_mod}+10+@{selected|dexterity_mod})/2)+(1/2*(@{selected|strength_mod}+10-@{selected|dexterity_mod}))-10) |Shortbow,1d6 + @{selected|dexterity_mod} |Shortsword,1d6 + (((@{selected|strength_mod}+10+@{selected|dexterity_mod})/2)+(1/2*(@{selected|strength_mod}+10-@{selected|dexterity_mod}))-10) |Sickle,1d4 + @{selected|dexterity_mod} |Sling,1d4 + @{selected|dexterity_mod} |Spear,1d6 + @{selected|strength_mod} |Spear (V),1d8 + @{selected|strength_mod} |Trident,1d6 + @{selected|strength_mod} |War Pick,1d8 + @{selected|strength_mod} |Warhammer,1d8 + @{selected|strength_mod} |Warhammer (V),1d10 + @{selected|strength_mod} |Whip, 1d4 + (((@{selected|strength_mod}+10+@{selected|dexterity_mod})/2)+(1/2*(@{selected|strength_mod}+10-@{selected|dexterity_mod}))-10)}]]}} {{dmg1type=piercing}} {{dmg2=[[+@{selected|pb}]]}} {{dmg2type=}} {{crit1=[[0]]}} {{crit2=[[@{selected|pb}]]}} {{description=}} @{selected|charname_output}