Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×

Legacy sanitization has made tabs stop working on custom sheet

1616061745

Edited 1616062059
Good morning. I am in the need of help. I have a custom character sheet based on a Dresden Files sheet. I customized the sheet long ago to fit the group needs and it worked perfectly until yesterday, when I made a change and saved it (in fact, past friday 12th march it was working ok). The problem is that the tabs that change the view between pages of the character sheet have stopped working, and I am lost on how to make them work again. If save it without Legacy Sanitization the view is a huge mess and the tabs do not work. If I save it with Legacy Sanitization, the CSS is ok but the "click" on the tabs do not show the proper sheet. Thank you in advance ^^ Here is the code as written: Related HTML LAYOUT <!-- buttons that toggle the diferent pages of the character sheet --> <div class="tabstoggle">         <input type="hidden" class="sheet-tabstoggle" name="attr_sheetTab" title="@{sheetTab}" value="charsheet">         <input type="hidden" class="sheet-typetoggle" name="attr_sheet_type" title="@{sheet_type}" value="character">         <button type="action" id="charbutton" class="char-button toggleable" name="act_charsheet" >Personaje</button>         <button type="action" id="spellbutton" class="spell-button toggleable" name="act_spellsheet" >Magia</button> </div> <input type="hidden" class="tabstoggle" name="attr_sheetTab" value="config"  /> <h1>Destino de Mago</h1> <!-- pages to toggle and that are not beign shown --> <div class="sheet-page sheet-charsheet"> ... </div> <div class="sheet-page sheet-spellsheet"> ... </div> Related CSS Styling /*Hide toggleable pages and sections*/ .sheet-toggleable { display: none; } /* show the selected tab */ .sheet-tabstoggle[value="charsheet"] ~ #sheet-charsheet, .sheet-tabstoggle[value="spellsheet"] ~ #sheet-spellsheet {         display: block; } Related SCRIPT <script type="text/worker">     const charButtonList = ["worksheet","charsheet","spellsheet","city-high","city-locs","city-face","config"];     charButtonList.forEach(button => {         on(`clicked:${button}`, function() {             setAttrs({                 sheetTab: button             });         });     }); </script> Related TRANSLATION { "legacy": true }
1616099579
Andreas J.
Forum Champion
Sheet Author
Translator
C hange out the generic css class names here &lt;div class="sheet-page sheet-charsheet"&gt; , pretty sure charsheet is one of the inherit css classes, so naming your classes to something that's less likely to be already used should make things work. Similar how sheet-col and sheet-row is used by inherit roll20 css sheet classes, so it's best to have some other names for your own column and row classes. You'll probably wanna read up on the latest back &amp; forth on the main thread on this feature/update: <a href="https://app.roll20.net/forum/post/9883156/character-sheet-enhancements" rel="nofollow">https://app.roll20.net/forum/post/9883156/character-sheet-enhancements</a> I'm not up to speed or completely sure where things are, but after they released CSE , they rolled it back some day later, and then apparently made some features available again.
1616103413

Edited 1616103556
Andreas J. said: C hange out the generic css class names here &lt;div class="sheet-page sheet-charsheet"&gt; , pretty sure charsheet is one of the inherit css classes, so naming your classes to something that's less likely to be already used should make things work. Similar how sheet-col and sheet-row is used by inherit roll20 css sheet classes, so it's best to have some other names for your own column and row classes. You'll probably wanna read up on the latest back &amp; forth on the main thread on this feature/update: <a href="https://app.roll20.net/forum/post/9883156/character-sheet-enhancements" rel="nofollow">https://app.roll20.net/forum/post/9883156/character-sheet-enhancements</a> I'm not up to speed or completely sure where things are, but after they released CSE , they rolled it back some day later, and then apparently made some features available again. Thanks for the advice! I tried to change some names and it still doesn't work, but I will follow your suggestion and see if it is a problem with keywords.&nbsp; The "Dresden Files Role-Playing Game" sheet in witch is based my custom sheet has also ceased working. It doen't work from selecting the template nor from copying the HTML/CSS. If sheets begin to break this game... it will be a huge problem for all of us.
1616105088
Kavini
Roll20 Production Team
Marketplace Creator
Sheet Author
Compendium Curator
My guess is that the toggles are referring to ids, which are being stripped out. .sheet-tabstoggle[value="worksheet"] ~ #sheet-worksheet, .sheet-tabstoggle[value="charsheet"] ~ #sheet-charsheet, .sheet-tabstoggle[value="spellsheet"] ~ #sheet-spellsheet, .sheet-tabstoggle[value="city-high"] ~ #sheet-city-high, .sheet-tabstoggle[value="city-locs"] ~ #sheet-city-locs, .sheet-tabstoggle[value="city-face"] ~ #sheet-city-face, .sheet-tabstoggle[value="config"] ~ #sheet-config, .sheet-aspecttoggle[value="1"] ~ #sheet-temp-aspects, .sheet-skilltoggle[value="1"] ~ #sheet-skills_compact_view, .sheet-skilltoggle[value="0"] ~ #sheet-skills_expanded_view, .sheet-skill_tier_toggle[value="1"] + .sheet-skill_tier, .sheet-evotoggle[value="0"] ~ #sheet-evocation_specializations, .sheet-evotoggle[value="1"] ~ #sheet-evocation_elements, .sheet-evotoggle[value="0"] ~ .sheet-evo-spec, .sheet-evotoggle[value="1"] ~ .sheet-evo-name, .sheet-spelltotaltoggle[value="0"] ~ #sheet-spell_totals, .sheet-focus-evothau[value="evocation"] ~ #sheet-focus-item-evocation, .sheet-focus-evothau[value="thaumaturgy"] ~ #sheet-focus-item-thaumaturgy, .sheet-focus-item-expanded[value="0"] ~ #sheet-focus_items, .sheet-focus-item-expanded[value="1"] ~ #sheet-focus_items-expanded, .sheet-enchanted-expanded[value="0"] ~ #sheet-enchanted_items, .sheet-enchanted-expanded[value="1"] ~ #sheet-enchanted_items-expanded, .sheet-rote-expanded[value="0"] ~ #sheet-rote_spells, .sheet-rote-expanded[value="1"] ~ #sheet-rote_spells-expanded, .sheet-spellcaster-view[value="1"] ~ #sheet-spellcaster-sub-options, .sheet-typetoggle[value="character"] ~ .sheet-character-config, .sheet-typetoggle[value="city"] ~ .sheet-city-config, .sheet-face-revealer[value="theme-one"] ~ .sheet-theme-one { display: block; } From the inspector:
I am checking all my other games, and I found that the games that use the Star Wars FFG sheet (yes, the one with the API that requires a pro subscription) does not load at all, and it is not even customized. It shows nothing. Last Sunday it was working. Ok... This thing is beggining to worry me a lot.
1616109512
Dean
Roll20 Team
Dourden said: I am checking all my other games, and I found that the games that use the Star Wars FFG sheet (yes, the one with the API that requires a pro subscription) does not load at all, and it is not even customized. It shows nothing. Last Sunday it was working. Ok... This thing is beggining to worry me a lot. Hi Dourden - as a heads up, the Star Wars FFG sheet not loading was related to a very recent deploy and has been quickly caught and patched up. That part at least should be working fine for you now. If it's not please let us know!
Dean said: Hi Dourden - as a heads up, the Star Wars FFG sheet not loading was related to a very recent deploy and has been quickly caught and patched up. That part at least should be working fine for you now. If it's not please let us know! Thanks a lot!! I was beggining to worry. Phew... Thanks again for the quick reply.
Hey folks - We just pushed out a fix for issues with broken tabs in character sheets. If you are having any additional issues, please make sure to refresh your game and clear your cache. Also, if you're using any extensions or addons, please make sure to disable them. Thanks!
Nicholas said: Hey folks - We just pushed out a fix for issues with broken tabs in character sheets. If you are having any additional issues, please make sure to refresh your game and clear your cache. Also, if you're using any extensions or addons, please make sure to disable them. Thanks! Thank you! The problem with the tabs has been solved without modifying the original code. Thanks a lot!