Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Player disconnects if they are hovering over a turn timer entry when token is deleted

One of my players and I discovered this last night, and being developers had to try a few more times to get a repo case: You require a player and a GM, and a map with tokens in the turn timer.   If the player has the turn order selected and is hovering their mouse over a token (so they get the little yellow box highlighting which enemy it is)  at the same moment that the GM deletes the token (because it just died) then the players roll 20 connection breaks.   However only the read part of the connection breaks.  The player can still move their token and the GM and all the other players see the token move, so the players actions are still being sent to the server, however the player themselves no longer sees any updates from the VTT.  To them they try and drag their token and it doesn't move.  - The receive data or map-update loop of the webpage has crashed.   The player fix is to close and relaunch the webpage, at which point it reconnects and works fine.   With 2 people this is trivial to repro, but I wasn't able to with 1 person (being GM and player) because it needs my mouse to be in 2 places at once.   Player and GM both using google chrome.  
Some more details: Players are on Chrome for Mac, we have not tested if it affects chrome for windows, but given the nature of the error that seems highly likely.   Have now replicated with multiple players using the steps above - player hovers mouse over turn order entry of a token as the GM deletes the token.   Screenshot is from the player: In the screenshot below, the last error in the console appeared at the moment that I deleted the token next to the turn order that is currently highlighted in yellow.  That token has gone from the game in mine and every other players VTT.   Further the player who took the screenshot controls the character on the far right (same row as the highlighted character).  That is where their token is displaying, they have moved the token around the map, which can be seen by me and all other players, but their token image is lost in place.  The 3 Token bar circles that should appear above the token, are being drawn in the location where they have moved their token to (roughly centre of the screenshot, the 3 circles that are there with no apparent token, those are the ones belonging to that player and on my screen her token is right below them as I would expect) Given the last line of the stack appears to be in renderloop it looks like her screen has processed the removal of the token from whatever game state object stores them all, but on the next frame of render the highlighter render is called before the turn order and screen is updated and the highlighter is attempting to locate a non existent token in the state to find its location and draw the highlight?
1616183918
keithcurtis
Forum Champion
Marketplace Creator
API Scripter
I have not taken the time to replicate myself, but it would explain an incident from last year...