Community Forums: One Click merges? | Roll20: Online virtual tabletop

1628692771

Pro

API Scripter

When do the GIT merges occur? I put this Pull request in (<a href="https://github.com/Roll20/roll20-api-scripts/pull/1291" rel="nofollow">https://github.com/Roll20/roll20-api-scripts/pull/1291</a>) and requested review, but have not seen any activity in 7 days. Are they less frequent than weekly? - E

1628695990

Scott C.

Forum Champion

Sheet Author

API Scripter

Compendium Curator

Permalink Quote

The merges occur at least weekly, but sometimes can occur more frequently. I do notice you still seem to have an error in your script.json. You have a 1.01 folder, but the json still says the current version is 1.0. You also have 1.0 listed as a previous version.

1628696775

Andreas J.

Forum Champion

Sheet Author

Translator

Permalink Quote

Scott C. said: The merges occur at least weekly, That's for character sheets, not APIs. Looking back at the api repos recent merge dates, it seems to bee on about a 1/week schedule.

1628709512

Ernest P.

Pro

API Scripter

Permalink Quote

Scott C. said: The merges occur at least weekly, but sometimes can occur more frequently. I do notice you still seem to have an error in your script.json. You have a 1.01 folder, but the json still says the current version is 1.0. You also have 1.0 listed as a previous version. Thanks, I just fixed that as well. Hopefully it makes the cut. =) - E

1628714672

David M.

Pro

API Scripter

Permalink Quote

API scripts typically merge weekly on Tuesdays. If you don't get confirmation of a merge by Monday I'd put in a ticket, though your post above might get some visibility.

1628715334

Andreas J.

Forum Champion

Sheet Author

Translator

Permalink Quote

Just heard the api-related devs are away currently. so sounds like this week's api-merge gets delayed or skipped.

1628727147

Ernest P.

Pro

API Scripter

Permalink Quote

Andreas J. said: Just heard the api-related devs are away currently. so sounds like this week's api-merge gets delayed or skipped. Thanks for the update, much appreciated. - E

1629480577

Ernest P.

Pro

API Scripter

Permalink Quote

Any updates for when the Devs might be back?

1629491779

timmaugh

Pro

API Scripter

Permalink Quote

This week's merge happened, so they're... probably... back now.

1629492469

Ernest P.

Pro

API Scripter

Permalink Quote

Any chance they look here? Or would I need to contact through some other method? My pull request has not changed besides what I added to it. -

1629852718

Ernest P.

Pro

API Scripter

Permalink Quote

Anyone have a clue who I can reach out to? NicholasR77 last reviewed it and I am not sure how to ask someone else to take a look.

1629905739

Nicholas

Roll20 Team

Permalink Quote

Hey folks! My sincerest apologies for the trouble here! This script has been approved and merged. For some reason our GitHub account never triggered notifications for this submission and it got lost in the shuffle. I'll be talking to the team this week to make sure submissions like this don't slip through the cracks again. Thanks for checking in!

1629906052

Nicholas

Roll20 Team

Permalink Quote

Hey all! Since this has been resolved now, I'm going to go ahead and close this thread, but please feel free to reach out again with any other questions or concerns! Thanks!

Cookie Preferences

One Click merges?