Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

D&D_OED: Pull request validation failed

I just made a pull request to the Roll20 Github character sheet repository. This involved a single change: replacing the preview image with an updated one (file oed-roll20-front.jpg). Unfortunately, the automatic character sheet validation is reporting, "All checks have failed: There as an error with the validation check." Any ideas what that could be? <a href="https://github.com/Roll20/roll20-character-sheets/pull/11519" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/pull/11519</a>
1677318648
GiGs
Pro
Sheet Author
API Scripter
I have seen that happen a few times to pushes that seem reasonable to me, so I don't know exactly. I understand that someone does look at the files before they are pushed live (which used to be on Tuesdays), and that's the earliest someone will reply to your question. That said, it looks like you have several unchecked boxes in your submission. I'd delete those questions complletely.
GiGs said: ... That said, it looks like you have several unchecked boxes in your submission. I'd delete those questions complletely. Thanks for the reply. FWIW, re: those unchecked boxes in the "New Sheet Details" section (which don't apply): I've always left that section untouched, in the same state, for all my prior pull requests (about a half-dozen), and they've always auto-verified in the past.
1677390932
GiGs
Pro
Sheet Author
API Scripter
I alwas delete the ones that don't apply, just in case. It's nice to know you can leave them untouched. Sadly, I have no idea why your pull has problems then.
Well, that pull request got merged into master without comment anyway, so who knows, lol.
1677570097
GiGs
Pro
Sheet Author
API Scripter
The message you got was automated, and automated systems can have errors. If it makes no sense to you, it probably makes no sense to the dev who looked at it and they ignored it. Messages like those don't always cause delays, but they do worry you while you wait for someone to actually lok at it.