Macro that had been in use for years stopped working recently.

Resolved. Recopying the macro worked.  As the title states: this macro worked fine before the holidays and is now broke. Any ideas what changed? &{template:DnD35StdRoll}{{name=@{selected|character_name} }} {{saveflag=true}} ?{Which resistance?|Fortitude ,{{subtags=braces against the attack}} {{check=Fortitude check:}} {{checkroll= [[1d20 + [[@{selected|fortitude}]] ]]}} {{notes=@{selected|fortitudenote} }}|Reflex ,{{subtags=tries to dodge}} {{check=Reflex check:}} {{checkroll= [[1d20 + [[@{selected|reflex}]] ]]}} {{notes=@{selected|reflexnote} }}|Will ,{{subtags=tries to resist}} {{check=Will check:}} {{checkroll= [[1d20 + [[@{selected|will}]] ]]}} {{notes=@{selected|willnote} }} }

Did you save this macro in the collections? For the query in your macro to work, all the unresolved closing braces within the query need to be html substituted, and whenever you open a collections macro to edit it, it parses out html entities within the macro. For this reason (and a few others), it's recommended to save complex macros as character sheet ability macros instead.

Yet it worked for years but stopped now? Something changed somewhere. Whoops, to answer  your question, yes in macro collections. Being a selected|character_name allow a quick check on any player character currently on the map.

It probably worked until you opened it to look at it, that would break it. What you can do is save the macro as a character ability, and then have a collections macro that calls that macro, and you have the same utility without the problems collections macros have with complex stuff. But, it could be there's a different problem too (which would have prompted you to open the macro and so further breaking it) that I can't see just looking at the macro - what character sheet are you using, and are you using jumpgate? I'd like to test this.

Hi Erich S.,  I second Tuo's statements. When you edit a Collection tab Macro it messes up macros with HTML entities in them.  For this reason and others I almost never use Collection tab Macros anymore. Instead I use Ability macros on characters, or on a Macro Mule (a character that is only for holding macros).  There are a number of advantages to using Macro Mules for macros. 

Tuo, One of my players reported it broken so I tried it and it was broken. Opened another game and just tried it - same result. Opened up three other games and they were all given the same message. Gauss, you are correct about the HTML entities and that made me think about what I posted earlier. That was right out of the macro which I opened to study (duh). Fortunately I keep a record of everything I use in my games and went back to that record to find the original: &{template:DnD35StdRoll}{{name=@{selected|character_name} }} {{saveflag=true}} ?{Which resistance?|Fortitude ,{{subtags=braces against the attack}} {{check=Fortitude check:}} {{checkroll= [[1d20 + [[@{selected|fortitude}]] ]]}} {{notes=@{selected|fortitudenote} }}|Reflex ,{{subtags=tries to dodge}} {{check=Reflex check:}} {{checkroll= [[1d20 + [[@{selected|reflex}]] ]]}} {{notes=@{selected|reflexnote} }}|Will ,{{subtags=tries to resist}} {{check=Will check:}} {{checkroll= [[1d20 + [[@{selected|will}]] ]]}} {{notes=@{selected|willnote} }} } You can see the original has the escaped characters. And when I put that back into the game(s) it all suddenly began working once more. Thankfully. So in this case I am thinking one of my players opened it even to just look at it and might have done it across multiple games though one of them is only where I work on my character sheet and it did not work either. Either way, thank you two for your responses as they did prompt me to go to the original macro and reload the corrected macro across the games. A mystery but at least replacing the code worked.

If it was stored in the Collections tab, it is unlikely that a player opened it. Permissions on Collections macros allow other players to see them and use them, but they cannot open or edit them.

keithcurtis said: If it was stored in the Collections tab, it is unlikely that a player opened it. Permissions on Collections macros allow other players to see them and use them, but they cannot open or edit them. Just trying to figure out how a macro that has worked fine for years across multiple games suddenly died but when reloaded with the original script works once more. Odd.

Erich S. said: keithcurtis said: If it was stored in the Collections tab, it is unlikely that a player opened it. Permissions on Collections macros allow other players to see them and use them, but they cannot open or edit them. Just trying to figure out how a macro that has worked fine for years across multiple games suddenly died but when reloaded with the original script works once more. Odd. Yeah, usually that indicates that it was opened and closed (didn't have to be edited). Besides clicking on it in the Collections tab, a macro in the bar or an action in the Token Action bar can be opened with a shift click. My guess is a misclick that didn't even consciously register. Or something weird.

Erich S. said: Just trying to figure out how a macro that has worked fine for years across multiple games suddenly died but when reloaded with the original script works once more. Odd. It's a bug that's been around for an absurdly long time. Normally you would expect an application to store, retrieve, and present your data correctly. Roll20 often doesn't do so with macros in the collections tab.

Jim R. said: Erich S. said: Just trying to figure out how a macro that has worked fine for years across multiple games suddenly died but when reloaded with the original script works once more. Odd. It's a bug that's been around for an absurdly long time. Normally you would expect an application to store, retrieve, and present your data correctly. Roll20 often doesn't do so with macros in the collections tab. Good as chance as any; thanks for making me aware.