[GroupCheck] Incorrect Result

Having calculation issues with GroupCheck.

I haven’t used the API in a few months, but noticed today it wasn’t calculating the numbers correctly.  Never had an issue in the past. Not sure what’s changed in my campaign, so I started a brand new game and I’m still seeing the same problem.

Configuration:

1 – NOT using Jumpgate

2 – Using D&D 5E 2014 by Roll20 sheet

3 – GroupCheck “latest” version from the Roll20 Mod Library

4 – GroupCheck configured for 5e-OGL

Issue:

GroupCheck calculating the wrong result no matter which check I choose.

Example: Strength check

The picture below shows the results from the “Strength Check” formula shown below:

FORMULA = [[d20 + ([[d0 + @{strength_save_bonus}@{pbd_safe}]]*(1-@{npc})) [PC] + (@{npc_str_save}*@{npc}) [NPC]]]

• It’s getting the @{strength_save_bonus} correct (3)
• Not sure what @{pbd_safe} does in this formula?
• Not getting correct value for @{npc} (1). The value for the “npc” attribute on the character sheet is 0, not 1.  Even if I change “npc” value to 2000, it still shows (1). Still get a 1 if I delete the “npc” attribute.
• Not getting correct value for @{npc_str_save}. It shows (2), which matches my strength modifier, but I can’t find @{npc_str_save} anywhere on the character sheet attributes.

Is anyone else seeing a similar issue?

*****************************************************************************

The PRIMARY issue is GroupCheck is seeing @{npc}=1 when it should be "0"

@{pbd_safe} is just a value of 's0cf0' to ensure that there isn't a crit value from that roll.

If a character sheet is set to NPC, the 'npc' attribute is '1'; if the character sheet is set to PC, the 'npc' attribute is '0'.

So in this formula, you get:

A 1d20 roll:

 [[d20 

Plus a PC's strength_save_bonus, which is multiplied by 1 if the character is a PC, or multiplied by 0 if the character is an NPC:

+ ([[d0 + @{strength_save_bonus}@{pbd_safe}]]*(1-@{npc})) [PC] 

Plus an NPC's npc_str_save, which is multiplied by 0 if the character is a PC, or multiplied by 1 if the character is an NPC:

+ (@{npc_str_save}*@{npc}) [NPC]]]

Is the character you are rolling for a PC or NPC? It is currently set as an NPC, so it is getting the NPC's 'npc_str_save' attribute, which is set to '2'. 

Hi Jaren, thanks for walking me through the formula. Its confirmed my interpretation on how it works.

ALL the rolls have been on PC characters. This is why I'm not sure what's going on. The formula appears to be working, But the 'npc' attribute value is not correct.

The character token I'm selecting is verified linked to a PC sheet. In some cases, the NPC attribute on the "PC" character sheet is set to "0", while in other cases, the PC sheet has no "npc" attribute. But in BOTH cases, GroupCheck still sets the incorrect value for the formula roll, (always shows 'npc'=1).

Do you have more than one character with the same name in the Journal? Including any archived characters? 

No, there are no characters with the same name in the journal and archive.  I get the issue even after creating a brand new "test" character or creating an entirely fresh game and installing GroupCheck on that game.

When I type @{selected|npc} into the chat while selecting the PC token in question, the chat message returns a "0" as a result. So the npc value should be correct, but GroupCheck thinks it's a "1" for some reason..? Are you seeing similar results? I just cleared the entire list using --clear and reimported the 5E-OGL checks and it's still showing the same problem... npc=1 when it should be 0

I am having the same issue. Also, when I run the GroupCheck on a pc for a skill check, the proficiency bonus is not getting applied due to the wrong NPC value.

What is the output of !group-check-config --show ?

the output is:

Just trying to keep this discussion to the top... has anyone else witnessed GroupCheck treating all tokens as if they were npc=1.  Looks like me and David S. so far...?

HI 've the same problem, my PC on @{selected|npc} has 0 but group check fails to add correct TS. 

Still not for me either.

Thank you Nicole!!!