Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Mork Borg, fixed some problems, who do I notify?

Bless the people who made the Mork Borg sheet. However there were several issues with the Getting Better roller/template causing it to frequently give incorrect results. I ended up re-writing that whole section, this seems to have addressed all the issues and simplified the logic, but I have no idea who to notify about this or how to go about doing that. If you are that person, feel free to use this or adjust it if I've made a mistake, but I ran it 175 times without an error, which covered nearly every possible result, so I think it's pretty solid. <rolltemplate class="sheet-rolltemplate-general"> <div class="sheet-container sheet-yellow-bg"> <div> <h1>{{name}}</h1> </div> <!-- Getting Better HP --> <!-- IF 6d10 ≥ current max HP → BETTER --> {{#^rollLess() labelhpcheck targethp}} {{#labelhpcheck}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelhpcheck"></span>:<span>{{labelhpcheck}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="labelhpgain"></span>:<span>{{labelhpgain}}</span></div> {{/labelhpcheck}} {{/^rollLess() labelhpcheck targethp}} <!-- ELSE the roll of 6d10 is less than current max hp, so No Change --> {{#rollLess() labelhpcheck targethp}} {{#labelhpcheck}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelhpcheck"></span>:<span>{{labelhpcheck}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-same-u">NO CHANGE...</span></div> {{/labelhpcheck}} {{/rollLess() labelhpcheck targethp}} <!-- Getting Better DEBRIS --> {{#rollGreater() labeldebris 3}} {{#rollTotal() labeldebris 4}} {{#labeldebris}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeldebris"></span>:<span>{{labeldebris}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="silver-u">Silver</span>(3d10): {{silver}}</div> {{/labeldebris}} {{/rollTotal() labeldebris 4}} {{#rollTotal() labeldebris 5}} {{#labeldebris}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeldebris"></span>:<span>{{labeldebris}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="scroll-unclean">Unclean Scroll</span></div> {{/labeldebris}} {{/rollTotal() labeldebris 5}} {{#rollTotal() labeldebris 6}} {{#labeldebris}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeldebris"></span>:<span>{{labeldebris}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="scroll-sacred">Sacred Scroll</span></div> {{/labeldebris}} {{/rollTotal() labeldebris 6}} {{/rollGreater() labeldebris 3}} {{#^rollGreater() labeldebris 3}} {{#labeldebris}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeldebris"></span>:<span>{{labeldebris}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-nothing-u">NOTHING</span></div> {{/labeldebris}} {{/^rollGreater() labeldebris 3}} <!-- Getting Better ABILITIES --> <!-- Inputs: target*** = current ability modifier (−3..+6) label***inc = d6 roll result (1–6) Rules: If target*** > 1 (i.e., +2..+6): • If roll < target*** → WORSE (−1) • If roll ≥ target***: – If target*** < +6 → BETTER (+1) – Else (target*** ≥ +6) → MAXED OUT, NO CHANGE If −3 ≤ target*** ≤ +1: • If roll ≥ 2 → BETTER (+1) • If roll = 1: – If target*** > −3 → WORSE (−1) – Else (target*** ≤ −3) → CAPPED AT -3, NO CHANGE Helper notes used here: rollGreater(A,B) = A > B rollLess(A,B) = A < B ^rollLess(A,B) = A ≥ B (inverted) ^rollGreater(A,B) = A ≤ B (inverted) --> <!-- STRENGTH --> <!-- IF current ability > 1 --> {{#rollGreater() targetstr 1}} <!-- IF roll < current ability → WORSE (−1) --> {{#rollLess() labelstrinc targetstr}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelstrinc"></span>:<span>{{labelstrinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-worse-u">WORSE...</span><span data-i18n="decrease">Decrease by</span><strong> -1</strong></div> {{/rollLess() labelstrinc targetstr}} <!-- ELSE (roll ≥ current ability) --> {{#^rollLess() labelstrinc targetstr}} <!-- IF current ability < +6 → BETTER (+1) --> {{#rollLess() targetstr 6}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelstrinc"></span>:<span>{{labelstrinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="increase">Increase by</span><strong> +1</strong></div> {{/rollLess() targetstr 6}} <!-- ELSE (current ability ≥ +6) → NO CHANGE --> {{#^rollLess() targetstr 6}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelstrinc"></span>:<span>{{labelstrinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-same-u">NO CHANGE...</span><span data-i18n="ability-maximum-abbrv">Max +6</span></div> {{/^rollLess() targetstr 6}} {{/^rollLess() labelstrinc targetstr}} {{/rollGreater() targetstr 1}} <!-- ELSE (current ability ≤ 1) --> {{#^rollGreater() targetstr 1}} <!-- IF roll ≥ 2 → BETTER (+1) --> {{#rollGreater() labelstrinc 1}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelstrinc"></span>:<span>{{labelstrinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="increase">Increase by</span><strong> +1</strong></div> {{/rollGreater() labelstrinc 1}} <!-- ELSE (roll = 1) → use Not Greater Than to catch ≤1 on a d6 --> {{#^rollGreater() labelstrinc 1}} <!-- IF current ability > −3 → WORSE (−1) --> {{#rollGreater() targetstr -3}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelstrinc"></span>:<span>{{labelstrinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-worse-u">WORSE...</span><span data-i18n="decrease">Decrease by</span><strong> -1</strong></div> {{/rollGreater() targetstr -3}} <!-- ELSE (current ability ≤ −3) → CAPPED AT -3, NO CHANGE --> {{#^rollGreater() targetstr -3}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelstrinc"></span>:<span>{{labelstrinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-same-u">NO CHANGE...</span><span data-i18n="ability-minimum-abbrv">Min -3</span></div> {{/^rollGreater() targetstr -3}} {{/^rollGreater() labelstrinc 1}} {{/^rollGreater() targetstr 1}} <!-- AGILITY --> <!-- IF current ability > 1 --> {{#rollGreater() targetagi 1}} <!-- IF roll < current ability → WORSE (−1) --> {{#rollLess() labelagiinc targetagi}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelagiinc"></span>:<span>{{labelagiinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-worse-u">WORSE...</span><span data-i18n="decrease">Decrease by</span><strong> -1</strong></div> {{/rollLess() labelagiinc targetagi}} <!-- ELSE (roll ≥ current ability) --> {{#^rollLess() labelagiinc targetagi}} <!-- IF current ability < +6 → BETTER (+1) --> {{#rollLess() targetagi 6}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelagiinc"></span>:<span>{{labelagiinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="increase">Increase by</span><strong> +1</strong></div> {{/rollLess() targetagi 6}} <!-- ELSE (current ability ≥ +6) → NO CHANGE --> {{#^rollLess() targetagi 6}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelagiinc"></span>:<span>{{labelagiinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-same-u">NO CHANGE...</span><span data-i18n="ability-maximum-abbrv">Max +6</span></div> {{/^rollLess() targetagi 6}} {{/^rollLess() labelagiinc targetagi}} {{/rollGreater() targetagi 1}} <!-- ELSE (current ability ≤ 1) --> {{#^rollGreater() targetagi 1}} <!-- IF roll ≥ 2 → BETTER (+1) --> {{#rollGreater() labelagiinc 1}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelagiinc"></span>:<span>{{labelagiinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="increase">Increase by</span><strong> +1</strong></div> {{/rollGreater() labelagiinc 1}} <!-- ELSE (roll = 1) --> {{#^rollGreater() labelagiinc 1}} <!-- IF current ability > −3 → WORSE (−1) --> {{#rollGreater() targetagi -3}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelagiinc"></span>:<span>{{labelagiinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-worse-u">WORSE...</span><span data-i18n="decrease">Decrease by</span><strong> -1</strong></div> {{/rollGreater() targetagi -3}} <!-- ELSE (current ability ≤ −3) → NO CHANGE --> {{#^rollGreater() targetagi -3}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelagiinc"></span>:<span>{{labelagiinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-same-u">NO CHANGE...</span><span data-i18n="ability-minimum-abbrv">Min -3</span></div> {{/^rollGreater() targetagi -3}} {{/^rollGreater() labelagiinc 1}} {{/^rollGreater() targetagi 1}} <!-- PRESENCE --> <!-- IF current ability > 1 --> {{#rollGreater() targetpre 1}} <!-- IF roll < current ability → WORSE (−1) --> {{#rollLess() labelpreinc targetpre}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelpreinc"></span>:<span>{{labelpreinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-worse-u">WORSE...</span><span data-i18n="decrease">Decrease by</span><strong> -1</strong></div> {{/rollLess() labelpreinc targetpre}} <!-- ELSE (roll ≥ current ability) --> {{#^rollLess() labelpreinc targetpre}} <!-- IF current ability < +6 → BETTER (+1) --> {{#rollLess() targetpre 6}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelpreinc"></span>:<span>{{labelpreinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="increase">Increase by</span><strong> +1</strong></div> {{/rollLess() targetpre 6}} <!-- ELSE (current ability ≥ +6) → NO CHANGE --> {{#^rollLess() targetpre 6}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelpreinc"></span>:<span>{{labelpreinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-same-u">NO CHANGE...</span><span data-i18n="ability-maximum-abbrv">Max +6</span></div> {{/^rollLess() targetpre 6}} {{/^rollLess() labelpreinc targetpre}} {{/rollGreater() targetpre 1}} <!-- ELSE (current ability ≤ 1) --> {{#^rollGreater() targetpre 1}} <!-- IF roll ≥ 2 → BETTER (+1) --> {{#rollGreater() labelpreinc 1}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelpreinc"></span>:<span>{{labelpreinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="increase">Increase by</span><strong> +1</strong></div> {{/rollGreater() labelpreinc 1}} <!-- ELSE (roll = 1) --> {{#^rollGreater() labelpreinc 1}} <!-- IF current ability > −3 → WORSE (−1) --> {{#rollGreater() targetpre -3}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelpreinc"></span>:<span>{{labelpreinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-worse-u">WORSE...</span><span data-i18n="decrease">Decrease by</span><strong> -1</strong></div> {{/rollGreater() targetpre -3}} <!-- ELSE (current ability ≤ −3) → NO CHANGE --> {{#^rollGreater() targetpre -3}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labelpreinc"></span>:<span>{{labelpreinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-same-u">NO CHANGE...</span><span data-i18n="ability-minimum-abbrv">Min -3</span></div> {{/^rollGreater() targetpre -3}} {{/^rollGreater() labelpreinc 1}} {{/^rollGreater() targetpre 1}} <!-- TOUGHNESS --> <!-- IF current ability > 1 --> {{#rollGreater() targettou 1}} <!-- IF roll < current ability → WORSE (−1) --> {{#rollLess() labeltouinc targettou}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeltouinc"></span>:<span>{{labeltouinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-worse-u">WORSE...</span><span data-i18n="decrease">Decrease by</span><strong> -1</strong></div> {{/rollLess() labeltouinc targettou}} <!-- ELSE (roll ≥ current ability) --> {{#^rollLess() labeltouinc targettou}} <!-- IF current ability < +6 → BETTER (+1) --> {{#rollLess() targettou 6}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeltouinc"></span>:<span>{{labeltouinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="increase">Increase by</span><strong> +1</strong></div> {{/rollLess() targettou 6}} <!-- ELSE (current ability ≥ +6) → NO CHANGE --> {{#^rollLess() targettou 6}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeltouinc"></span>:<span>{{labeltouinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-same-u">NO CHANGE...</span><span data-i18n="ability-maximum-abbrv">Max +6</span></div> {{/^rollLess() targettou 6}} {{/^rollLess() labeltouinc targettou}} {{/rollGreater() targettou 1}} <!-- ELSE (current ability ≤ 1) --> {{#^rollGreater() targettou 1}} <!-- IF roll ≥ 2 → BETTER (+1) --> {{#rollGreater() labeltouinc 1}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeltouinc"></span>:<span>{{labeltouinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-better-u">BETTER...</span><span data-i18n="increase">Increase by</span><strong> +1</strong></div> {{/rollGreater() labeltouinc 1}} <!-- ELSE (roll = 1) --> {{#^rollGreater() labeltouinc 1}} <!-- IF current ability > −3 → WORSE (−1) --> {{#rollGreater() targettou -3}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeltouinc"></span>:<span>{{labeltouinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-worse-u">WORSE...</span><span data-i18n="decrease">Decrease by</span><strong> -1</strong></div> {{/rollGreater() targettou -3}} <!-- ELSE (current ability ≤ −3) → NO CHANGE --> {{#^rollGreater() targettou -3}} <div class="sheet-aligns-right"><span class="sheet-bold-text" data-i18n="labeltouinc"></span>:<span>{{labeltouinc}}</span></div> <div><span class="sheet-bold-text" data-i18n="getting-better-same-u">NO CHANGE...</span><span data-i18n="ability-minimum-abbrv">Min -3</span></div> {{/^rollGreater() targettou -3}} {{/^rollGreater() labeltouinc 1}} {{/^rollGreater() targettou 1}} {{#allprops() name labelhpcheck labelhpgain labeldebris labelstrinc labelagiinc labelpreinc labeltouinc targethp targetstr targetagi targetpre targettou silver}} <div> <span>{{key}}</span> <span>{{value}}</span> </div> {{/allprops() name labelhpcheck labelhpgain labeldebris labelstrinc labelagiinc labelpreinc labeltouinc targethp targetstr targetagi targetpre targettou silver}} </div> </rolltemplate>
1758130873

Edited 1758130925
Gold
Forum Champion
info Mork Borg character sheet in Roll20, Authors: Kevin B. (@brocktopus), and a modest change from Eric Rinkus (ejrinkus) however I think Vince may be able to help with this, I saw in github that he has done some fixes on this sheet before.&nbsp; Here is Vince's profile if you want to try to DM and ask him. However also I bet you he will see this thread in due time. <a href="https://app.roll20.net/users/463088/vince" rel="nofollow">https://app.roll20.net/users/463088/vince</a>
Thanks
1758142436
vÍnce
Pro
Sheet Author
Hi Joel, thanks for the re-write. I'm not the original author, but I did make some updates recently(including the Getting Better Roll...) I'll try and submit your changes this week or next. Cheers
1758146500
vÍnce
Pro
Sheet Author
<a href="https://github.com/Roll20/roll20-character-sheets/pull/14359" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/pull/14359</a> Thanks Joel
You're very welcome. Hope it works for everyone.
This has been merged! :)&nbsp;