Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
May your rolls be chill this holiday season!
Create a free account

How the French-Toast does GitHub works ?! U_u

1431881696

Edited 1431883437
BlackyB
Sheet Author
Hi there, I know it's a common question, I read a bunch of topic and the GitHub for beginner's guide But english is not my native language and this GitHub is not ergonomic at all ! I clicked the fork on Roll20 Character Sheet repository I see my character sheet folder in my (?) respository (Don't even know how I managed it) And.. What know ? I don't get this "pull request" thing I tried following G.V Here But I can't click on the Create a Pull Actually I'm getting tired of this, I'm about to throw my fist right into my computer screen
1. What is your native language? 2. What do you want to do and do you know what "git" is? - before I start explaining what git is in the first place.
1431888510

Edited 1431888568
BlackyB
Sheet Author
I'm french I understand that GitHub is an online repository That I have to modify the copy (fork) of roll20 repository by adding my folder with character sheet, then ask to be modify the original repository by asking (pull) a moderator to accept the modification Am I right ? If so, my question is : How ?
1431888933
Lithl
Pro
Sheet Author
API Scripter
You've successfully added your character sheet files to your fork of the repository (it appears when you look at your fork online)? And you can't click the create pull request button? BlackyB said: this GitHub is not ergonomic at all ! One of the biggest complaints about the git repository system that I've seen across the net (not just here on Roll20 and not just on GitHub) is that it's not very newbie-friendly. Sorry. =)
1431889404

Edited 1431889585
vÍnce
Pro
Sheet Author
I feel your pain BlackyB. A quick version of how I use github; 1. Make a fork of the main roll20 repository 2. Make edits to your fork 3. Once you are done with your edit(s) make a commit 4. In order for your commits to be added to the main repository, you have to make a PR(pull request). Go to your fork and make PR 5. Finally, you have to wait for the PR's to be accepted by the roll20 Dev's (usually Steve K.) This usually happens once a week, sometimes sooner. Once the servers pick up the new sheet it will automatically update the campaigns that use it. Hope this helps. Cheers EDIT: guess I should have refreshed. :-)
1431894187

Edited 1431894395
BlackyB
Sheet Author
Okay, but I don't understand how and when I have to put my character sheet folder xD And how do I 'edit' the fork
1431895083

Edited 1431895628
vÍnce
Pro
Sheet Author
You can click the little "+" symbol at the top of your fork's directory listing to add/create a file/folder. On the new page that opens, type a name for the folder your want including the name of the file inside you want to create. It's a little idiosyncrasy that you need to include a file name when creating a folder the first time. So if want to create a template called "test", type test/test.html. A new folder will be created on the repository called test with a file inside called test.html After that, you can just create/add the other necessary files in your sheet's folder, such as test.css, test.json, and test.png You can edit your fork by going to your github user's page, clicking on the "Repositories" tab, open the roll20 fork, go inside any folder on the fork, and use View on a file to open it and the Edit option(looks like a little pen icon) to edit the code directly. You can copy and paste from an external editor as well. Commit and make a PR as mentioned above to get your changes updated to the roll20 community.
Okay for the .css / .html / .json But how did I host my .png ?
1431898670

Edited 1431899994
vÍnce
Pro
Sheet Author
This is a little bit of "github hell" isn't it? :-) To upload images, you'll have to install the Github GUI Windows <a href="https://windows.github.com/" rel="nofollow">https://windows.github.com/</a> Mac <a href="https://mac.github.com/" rel="nofollow">https://mac.github.com/</a> Github Help <a href="https://help.github.com/articles/getting-started-w" rel="nofollow">https://help.github.com/articles/getting-started-w</a>... Use the "Clone to Desktop" link from your online fork of roll20's repository to create a local copy. You can add your image to your sheet's local folder. Open the github gui and make a commit. Go to your fork online and make a PR. BTW, you can continue to make commits to the same PR. Any commits made after you make a PR will just be added to your PR.
God... This is insane xD I'll give it a try and let you know if I have another trouble Thanks for your help guys
I think this is it, it must be pulled Can someone tell me if it shows in your PR list ?
I can see it here . It says "Le Donjon de Naheulbeuk" is being added by "BlackyB".
Yay, awesome Thanks a lots for your help guys :)
1431907492
vÍnce
Pro
Sheet Author
Yay!
1431930983

Edited 1431930999
vÍnce
Pro
Sheet Author
BlackyB, you'll probably want to Close this PR since it looks like it was an accident. :-) <a href="https://github.com/Roll20/roll20-character-sheets/" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/</a>... scroll to the bottom and click "Close pull request"
1431935771
Natha
KS Backer
Sheet Author
API Scripter
When using the Windows github software (with graphic interface and all), the thing that I had a hard time to get when I began creating/modifying sheets, is that you have to sync your fork with the main Roll20 repository between your commits (especially if they're sparse). So before creating the pull request from your fork, you have to sync your local copy of your fork with the Roll20 repository (with commands like : "git checkout master", then "git fetch Roll20", then "git merge Roll20/master"), If you don't do that, I came across 2 different problems : if you missed too many modifications on your fork (it's out of sync with Roll20), the github software won't accept your commits and/or Pull Requests (too far behind). If you just update your local copy with the last modificaitons from Roll20 but don't merge/sync with your fork on github, your next PR will include all the other users modifications (since last complet sync of your fork). Unless I'm missing something ...
1431954884
Stephen S.
Pro
Marketplace Creator
Sheet Author
API Scripter
It's dreadful. it so bad I was forced to ask Vince for help. and when that didn't work I got Aaron to do it for me. I get why we are using it but something native to Roll20 would be nice.
1431955454
vÍnce
Pro
Sheet Author
Stephen S. said: It's dreadful. it so bad I was forced to ask Vince for help. and when that didn't work I got Aaron to do it for me. I get why we are using it but something native to Roll20 would be nice. LOL Stephen. I nearly choked on my morning cereal.
1431977936

Edited 1431978527
Michael B.
Pro
Sheet Author
Yup, this has been an insurmountable point of frustration for me as well. Roll20 seems to be taking a "it's not ours, so not our job to document it".... But then making it a mandatory tool for some of the premium features of their product. GitHub may be the catalyst for my switching back to a free account, as i am not getting my money's worth for my paid account because of this GitHub roadblock.
1431978959

Edited 1431979000
Lithl
Pro
Sheet Author
API Scripter
Michael B. said: GitHub may be the cstalyst for my switching back to a free account, as i am not getting my money's worth for paying because of this roadblock. Michael, have you read the Beginner's Guide to GitHub ? Stephen S. said: I get why we are using it but something native to Roll20 would be nice. It's worth noting that Riley and Steven obviously use GitHub for things other than the community sheets and scripts. If you check the Roll20 GitHub account page, there are several other repositories: dm-postgres-types (postgres support for DataMapper in Ruby) help.roll20.net (seems to have been replaced by the wiki) webrtc-server (webRTC support) jquery-mentions-input (a library to @mention people like Twitter, doesn't seem to be in use) three.js (3D library, probably used for 3D dice on the VTT) bouncy (manages HTTP requests) dm-paperclip (DataMapper plugin) raphael (vector graphics) Using GitHub for character sheets and API scripts is the result of putting to use what's already being used.
1431979227
Michael B.
Pro
Sheet Author
I've read the beginners guide more times than I care to. It is a GREAT doc if all one is interested in is adding updates to currently existing sheets/API scripts.... But sadly the big gap in documentation is in how to add NEW items. I've seen a few forum discussions that come close to providing me that Aha moment, but not yet. It took a week to stumblr across a topic that clearly pointed out the GitHub client software is required... But now figuring g out how to use that has only shifted the frustration.
1431979904
Lithl
Pro
Sheet Author
API Scripter
Michael B. said: It is a GREAT doc if all one is interested in is adding updates to currently existing sheets/API scripts.... But sadly the big gap in documentation is in how to add NEW items. "Once you have a working copy of your repository cloned, you can make changes to it. Most importantly, this includes creating a new folder for your character sheet or API script and adding the source code to it." If you're using GitHub by creating a local copy, you simply create new files on your computer wherever the cloned repository is. If you think this needs to be clearer, please, by all means, suggest improvements to the guide, or make the improvements yourself. (It is a wiki!) ^_^
1431981895

Edited 1431982143
Michael B.
Pro
Sheet Author
Once I learn how to do it... I would happily edit and expand the heck out of the wiki.... Issues How do I sync my client with the repository? How do I clone the repository? It's not the concepts (I work peripherally with developers in the real world), it is the how do I use this stupid counter-intuitive piece of nonsense application to achieve those concepts. P.S. I fully own the fact that my familiarity with a different product that does the same thing might be a part of my challenges with GitHub.
1431988214

Edited 1431988265
Lithl
Pro
Sheet Author
API Scripter
Michael B. said: How do I sync my client with the repository? There is a button in the top-right labeled "Sync" Michael B. said: How do I clone the repository? Click the "+" button in the top-left and select Clone. All of the repositories on your GitHub account will be listed.
Hello guys, great news, my character sheet seems to be accepted as I can see it on the Roll20 repository and it's added in the approved.yaml Repository Anyway, I can't find it when creating a new campaign, have I to wait an update ?
You have to wait for an update. It can take over 24 hours, if the Internets are not cooperating. Also, stabbing the internet does not help; I tried.
1431998274
vÍnce
Pro
Sheet Author
Coal Powered Puppet said: You have to wait for an update. It can take over 24 hours, if the Internets are not cooperating. Also, stabbing the internet does not help; I tried. Back stabbing allowed?
1432034814
Natha
KS Backer
Sheet Author
API Scripter
BlackyB said: Hello guys, great news, my character sheet seems to be accepted as I can see it on the Roll20 repository and it's added in the approved.yaml Repository Anyway, I can't find it when creating a new campaign, have I to wait an update ? Bonne nouvelle ! "Le Ranger : Et voilà, nous allons entrer dans le fameux donjon de Naheulbeuk."
Je mettrai une annonce sur le topic de campagne FR pour annoncer la bonne nouvelle :) J'espere que la fiche vous plaira, et n'hesitez pas à me soumettre vos suggestion
1432076159
Michael B.
Pro
Sheet Author
Brian, thank you for those answers... It helped me figure it out. This is a big hurdle you have helped me overcome.
Hi, I would like to know why my custom character sheet still not appear in the list ? It has been updated today but still invisible ^^
1432760037
Lithl
Pro
Sheet Author
API Scripter
If your pull request was only just merged into the repo, it'll probably take a day or two to appear in the list of selectable character sheets.
1432762948

Edited 1432766327
BlackyB
Sheet Author
The original sheet had been merged 10days ago, and didn't have shown yet
Still not there..
1433002337
Michael B.
Pro
Sheet Author
Ditto... Although it has only been 3 or maybe 4 days since I saw the push request completed. But I am guessing these requests are done grouped together to save effort of many one-offs.
There are several sheets currently in the wings, ready to fly into being on Roll20. I, too, am waiting for my little hatchlings to sprout wings, but alas, the nest of Github is thick in width and great in height, and it can take much too long for the little critters to clamber their way above to a perch they will need. I think I took that analogy much further than needed. Anyhow, yeah, its been a while. I wonder what's up?