Hi, I've just been rebuilding my campaign to use the new Shaped 5e sheet, and in the process I've cleared out all the scripts and started with the latest versions from the repository. I've noticed that the latest version of TurnMarker and GroupInit don't quite work together as they should. If you select a bunch of characters with the initiative tracker closed, and run !group-init, everything works as expected, *except* that the turn marker doesn't get set on the top token in the initiative order until the first time the turn order is moved on. Also, the first turn doesn't get announced properly either (presumably the same underlying problem). Looking at the code, it seems like TurnMarker registers an observer on GroupInit, presumably because the API-based changes that GroupInit makes don't trigger the relevant change events for TurnMarker to pick up. This observer is getting called correctly, but for some reason all it does is to ensure that the "pr" value for the turn marker is set to -1 if it isn't already (presumably to compensate for people accidentally changing initiative for the marker itself somehow). It seems like this function should probably also be calling TurnMarker.Start() as well somewhere, but I don't understand it well enough to know if that will have other unintended consequences (and would require GroupInit to notify observers *after* showing the initiative order to work correctly, since Start just returns if the initiative order isn't showing). While I'm posting on the subject, is there a neat way to have the initiative order cleaned out before rolling it with !group-init? At the moment it seems like I have to do that manually if there are still unwanted entries from a previous combat in the tracker... but perhaps I'm missing something? Cheers, Lucian
