Having a macro problem

Ive been using this attack macro: &{template:pf_generic}{{color=darkred}}{{name=@{Selected|token_name} slams his weighted spear into @{target|Token_Name} with a howl of rage!}} {{Weighted Spear:=[[d20+4+?{temp modifier|0}]]}}{{Critical Confirm:=:[[d20+4+?{temp modifier|0}]]}}{{?{Weapon?|Mace,Mace Damage (Blunt):=[[d6+2]]|Spear, Spear Damage (Piercing):=[[d8+2]]}}} It worked fine till I imported the character to another VTT/Game. Now it wont output anything at all. I suspect its because of the &{template:pf_generic} somehow, and maybe it cant access that particular template. Both I and the other game have full subscriptions.  Anyone have any idea whats going on? Second, I'd like to modify this to only roll the Critical Confirmation and additional damage when the initial attack roll is a critical i.e. on a 20. Any help would be most appreciated.

pf_generic is one of the roll templates used on the Pathfinder-neceros sheet.  I was able to use your macro without issue.  Are you using a different sheet in the game you imported into? I don't think you can achieve the logic you want from a macro alone. ;-(  Roll templates can be written for a sheet that can handle rolling a crit confirm only if a crit is rolled and only showing the crit damage if a crit confirm is successful.  This is the way the pf_attack roll template is written.

We arent really using the sheets as such (not even filling them out) and the character file is really just a token and macro holder, but I think its the big updated sheet with tabs thats installed in the game, not the old one. ( I like that one better, BTW, less complicated) could it be that?since I imported it in, and he uses the other sheet, now I cant get the pf_generic template? Is there not a way I can import that in as well?

I've written them using the sheet request tags: @(sheet_attribute) etc. , but I ran into problems on import with that as well. Now I just have a library of macros and plug in the ones I want and change the variables when I need to, or make them input requests.

I was really glad this save roll macro worked with the drop down too. &{template:pf_generic}{{color=darkblue}}{{name=?{save?|Fortitude, Gnarrll grits his teeth and resists|Reflex, Gnarrll dodges out of the way|Will, Gnarrll shakes his head and resists!} }} {{?{Which save?|F, Fortitude =[[d20+4]] |R, Reflex =[[d20+0]] |W, Will =[[d20+5]] } }} I wanted the top selection to be the flavor text in the header, but dont want to have to select it twice. can I put the roll result in the header bar with the flavor text like this? &{template:pf_generic}{{color=darkblue}}{{name=?{save?|Fortitude, Gnarrll grits his teeth and resists! Fortitude =[[d20+4]]|Reflex, Gnarrll tries to dodge out of the way! Reflex =[[d20+0]]|Will, Gnarrll shakes his head and resists! Will =[[d20+5]]} }}

I just figured it out thanks to your input. Even though Im using the old Pathfinder sheet, and his game was set for that sheet, the template I was requesting is only available if the game settings are on the newer Pathfinder sheet. It doesnt really matter to his game what its set to, so we just changede it to the new sheet and my macros work, even though I imported it in on an old sheet. Thanks! I just tested my rebuild of the save macro too, and it works just like I intended. I should just be more confident and go with my gut on these things. Im always so hesitent about experimentation.

Roll templates are written for a particular sheet. If you change sheet's, you only have access to that sheet's roll templates. You can also use roll20's &{template:default} roll template which is available to all games, however it's very limited in it's function.  If you want to use the pf_generic, pf_attack, pf_spell, etc. you have to use the Pathfinder-neceros sheet. (the big tabbed sheet).   your macros look fine to me.  ;-)

Excelent! As it turns out, it doesnt matter what your character is on, it only matters what the Game settings are set for, it seems. As long as the game is configured to the Neceros sheet, it doesn't matter what your character is on, really, as far as handmaid roll macros and the templates you use. Once I set the game options to the newer sheet, all my macros would work. I dont really like the &{template:default} because it only generates that putrid purple, and I like to color code the results. Red for attacks, Blue for saves, skills, and class abilities, and gold for spells, spell abilities, and healing. Green (light and dark) for Druid magic and abilities and Black for Necromantic effects. I know, I'm a weirdo.... I just did one for any skill on the fly too, but I'll likely fix it up with a dropdown in the next iteration to select the skill you want. &{template:pf_generic}{{color=blue}}{{name=@{Selected|token_name} tries to ?{Skill} = [[1d20+?{total bonus|0}]]}} It is, of course, super simplistic for someone with expertise in this, but I'm trying to teach myself this stuff, so I'm always proud when something works as I intended. My dropdown combat maneuver macro is a thing of beauty, to me.

I like the second version of the save macro in your pic, btw, and changed mine to that in my library note.

Heres my new dropdown skill check macro &{template:pf_generic}{{color=blue}}{{name=@{Selected|token_name} tries to use ?{skill?|Acrobatics|Appraise|Bluff|Climb|Craft|Diplomacy|Disable Device|Disguise|Escape Artist|Fly|Handle Animal|Heal|Intimidate|Knowledge|Linguistics|Perception|Perform|Profession|Ride|Sense Motive|Sleight of Hand|Spellcraft|Stealth|Survival|Swim|Use Magic Device} ?{ knowledge/craft/profession type?} >>> Check = [[1d20+?{total bonus|0}]]}} :)