Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Unable to delete row - only clears values

1543432997
SᵃᵛᵃǤᵉ
Sheet Author
API Scripter
Weird thing happening. I am unable to delete rows on one of my repeating sections. what happens it the values in the row are cleared but the row remains. I looked for similiar issues but this one is different. <a href="https://app.roll20.net/campaigns/details/3841529/gurps-working-copy" rel="nofollow">https://app.roll20.net/campaigns/details/3841529/gurps-working-copy</a>
1543436697

Edited 1543436778
Mike W.
Pro
Sheet Author
Savage Gamer Yes this is a known issue.on the GURPS sheet for Techniques. Click the Updates tab and will explain the issue. I have an open Big report into the Devs on this. The issue is the 'Max' value for the Technique. If any value was placed in there, the row will not delete. So in this PULL I have blocked values from being placed there so that new Techniques can be deleted if need be. Existing Techniques that you are unable to delete - the Devs are looking into that issue and will advise me. NOTE: Techniques, as it is now on the character sheet, does not really work well - that section will most likely be completely rewritten (I plan on doing it when I get some time and my skills at HTML improve). Mike
1543437285

Edited 1543437415
SᵃᵛᵃǤᵉ
Sheet Author
API Scripter
Yea, I saw that post. I have it redone...however existing sheets that had entries in that cell. Those rows after updating HTML will not delete, yet the entries do. FYI &lt;fieldset class="repeating_techniques"&gt; &lt;input class="sheet-toggle" type="checkbox" /&gt; &lt;span class="sheet-checkbox"&gt;&lt;/span&gt; &lt;div class="sheet-row sheet-row-stats"&gt; &lt;div class="sheet-cell sheet-col0"&gt; &lt;input type="hidden" name="attr_rowid" readonly="readonly"/&gt; &lt;button type="roll" name="attr_skillroll" value="!tech @{character_id} @{rowid} [[3d6]] [[@{level} + @{modifier}]]" /&gt; &lt;/div&gt; &lt;div class="sheet-cell sheet-col1"&gt; &lt;input type="text" name="attr_techniquename" placeholder="Technique Name"/&gt; &lt;/div&gt; &lt;div class="sheet-cell sheet-col1"&gt; &lt;input type="text" name="attr_parent" placeholder="Parent Skill Name"/&gt; &lt;/div&gt; &lt;div class="sheet-cell sheet-col2"&gt;&lt;select name="attr_difficulty"&gt;&lt;option value="0"&gt;A&lt;/option&gt;&lt;option value="-1"&gt;H&lt;/option&gt;&lt;/select&gt;&lt;/div&gt; &lt;div class="sheet-cell sheet-col2"&gt; &lt;input type="number" name="attr_defaultlvl" value="0" placeholder="0"/&gt; &lt;/div&gt; &lt;div class="sheet-cell sheet-col2"&gt; &lt;input type="number" name="attr_mxlvl" value="0" placeholder="0"/&gt; &lt;/div&gt; &lt;div class="sheet-cell sheet-col2"&gt; &lt;input type="number" name="attr_level" value="0" readonly="readonly"/&gt; &lt;/div&gt; &lt;div class="sheet-cell sheet-col2"&gt; &lt;input type="number" name="attr_bonus" value="0" placeholder="0"/&gt; &lt;/div&gt; &lt;div class="sheet-cell sheet-col2"&gt; &lt;input type="number" name="attr_points" value="0" placeholder="0"/&gt; &lt;/div&gt; &lt;div class="sheet-cell sheet-col3"&gt; &lt;input type="text" name="attr_ref" placeholder="0"/&gt; &lt;/div&gt; &lt;/div&gt; &lt;div class="sheet-row sheet-row-details"&gt; &lt;div class="sheet-cell sheet-col0 sheet-label"&gt; Notes &lt;/div&gt; &lt;div class="sheet-cell sheet-col1"&gt; &lt;input type="text" name="attr_notes" placeholder="notes"/&gt; &lt;/div&gt; &lt;/div&gt; &lt;/fieldset&gt; and my sheet workers // Update Line Techniques on('change:repeating_techniques', function() { TAS.repeating('techniques') .fields('difficulty', 'defaultlvl', 'mxlvl', 'bonus', 'points', 'level') .each(function(r){ r.D[0].level = (r.F.difficulty + r.F.defaultlvl + r.F.bonus + r.F.points); }) .execute(); }); // Update the total cost of Techniques on('change:repeating_techniques', function() { TAS.repeatingSimpleSum('techniques', 'points', 'techniques_points'); });
1543437758

Edited 1543437876
Mike W.
Pro
Sheet Author
I always had the entries deleting (well it was always deleting originally). except it would not delete attr_max. There is a bug when using an attribute name of max, something about it probably being a reserved word. What needs to be done is remove that attribute form the Repeating section, all such stored values already in use. One coder is working on code that will go through the repeating section and delete the attr_max field. Once that is done, existing techniques that were created before I stop the field form populating can then be deleted.
1543438029
Mike W.
Pro
Sheet Author
The way I have it now, newer Techniques will delete but older ones will not.
1543453440
SᵃᵛᵃǤᵉ
Sheet Author
API Scripter
I discovered that after rewriting the code. That only new sheets are allowing deletion of the row. I checked making imported characters, dupes, and copies.
1543455594
Mike W.
Pro
Sheet Author
As I originally changed the code. It was like that before. Those that entered the Max value prior to me blocking it cannot be deleted. Once I stopped using the Max attribute you are able to delete new Techniques added. I have tested this ob older and newer sheets when I first blocked the use of that attribute Max. However it may be possible the other guy, who will not coordinate things, tried to change the code and may have made it worse. So as far as I can tell, no changes were needed - what is needed is code to loop through the repeating section and setting to null or deleting the Max attribute for each row. This was confirmed by the Devs and another coder helping me code. I must confess though, that I&nbsp; have not looked at it in over a month and things may have been changed unknowingly by someone else.
1543455686
Mike W.
Pro
Sheet Author
The other solution it to rewrite the entire Tech sections, which in my book it the better idea ans the original concept and code is faulty and not very functional.