Advertisement Create a free account

Error in the Default Templates in the Star Wars Saga Edition

I noticed an error in the default templates for Star Wars Saga Edition. In the file roll20-character-sheets/Star Wars Saga Edition/StarWarsSagaEdition.html, on lines 3140-3142, it specifies "{{#rollBetween() skillcheck 25 29 }} <tr><td><span class="tcat">DC 25 </span>{{25}}</td></tr> {{/rollBetween() skillcheck 25 29 }}, but on lines 3151-3153 this is repeated. Likewise on 3162-3164. This means that if you have a skill check which has a less than 25, and either a more than 35 or a more than 40. Then for a roll between DC 25-29, the result will be repeated twice. (This error repeats again in the Less than 30 section, for more than 35/40, in which it duplicates the 30-35 DC).
I fixed the error in the file on gethub, and submitted a pull request here: <a href="https://github.com/Roll20/roll20-character-sheets/pull/5084" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/pull/5084</a> Hopefully someone with write permissions can merge this into the trunk.
1558015072
Dragon Dreamer
Roll20 Mod Team
Hello Devin W., I have moved this post to the Character Sheets &amp; Compendium forum.
1558018091
Andreas J.
Roll20 Production Team
Sheet Author
Devin W. said: I fixed the error in the file on gethub, and submitted a pull request here: <a href="https://github.com/Roll20/roll20-character-sheets/pull/5084" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/pull/5084</a> Hopefully someone with write permissions can merge this into the trunk. Roll20 reviews(and gives feedback) pull requests on Mondays and merges/rolls out approved changes on Tuesdays, so with good luck the fix is live next Tuesday evening. The PR seems to have no problems so good job on your first GitHub contribution! Do note that when you eventually see that the PR gets marked with "approved" it does not mean it have been merged yet, so don't go closing the PR or anything, it with automatically close itself when(if) it gets merged.
Understood. Thank you.
My fix got pushed live today :). Thanks for your help&nbsp;Andreas J.