Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

NPC sheets rolling damage as a crit when set to disadvantage

1581970553

Edited 1582045474
It seems that NPC sheets when set to disadvantage via 'toggle advantage' are rolling damage as a crit on their attacks. I've tried this multiple times and it seems I'm able to replicate it reliably although it doesn't consider every attack roll made with disadvantage to be a crit just a few so if replicating the issue roll a dozen or so attacks and then try to roll damage on each a few wind up broken and think they're a crit when neither die rolled a 20. The issue also happens more reliably when 'whisper toggle' is on and set to public atleast on my end. This issue is occurring with the standard D&D 5E OGL sheet.
Hey Big Boss - Can you provide me the name of the game you've seen this occur on, please? Also, if you know, when was the last time the issue happened for that game?
1582219449

Edited 1582219607
Currently the issue seems to be happening regardless of the game I join I tested it in my 'Curse of Strahd' and 'The Five Kingdoms' game. I also had one of my players test it in their game and they said the same issue occurred if you're referring to the system it's the standard D&D 5E OGL sheet by Roll20. I've tried disabling API and it persists the player I had try it also had no API involved so it seems to just be a coding issue with the Roll20 5E sheet when NPC's are set to disadvantage. It takes a few tries but I have no issue replicating it if you can take a look I just did it again in my 'Curse of Strahd' game. So the last time this occurred would be at the time of this post it's not a huge issue but I thought it worth reporting as it may be an easy fix.
Hey Big Boss -  And does this happen when you roll directly from the sheet, like when you click on the NPC's weapon attack? Or this occurring with some sort of macro or something?
This is occurring when I roll an attack directly from the NPC's sheet I set the toggles to roll publicly and at disadvantage and when I click their attack roll in the chat box it occasionally assumes it's rolled a crit when it hasn't and shows the damage roll as well as the doubled die roll. I just replicated the bug in my 'Curse of Strahd' game with two seperate NPC's. I can only assume it's a bug in the code that makes it think it's crit when neither die rolled 20. 
Hey Big Boss -  Unfortunately, I'm not able to replicate this issue on my end. I try the same reproduction steps and all of my rolls come out normally. We did notice the use of unsupported extensions in your game - I would recommend trying to disable your extensions to prevent these outside factors possibly affecting intended behavior. 
1582504082

Edited 1582504393
Hey I just retested it with all extensions and API off and it still seems to occur though I did notice when you tested it you only rolled one attack from the sheet to test. The bug is inconsistent and doesn't occur on every roll to replicate try rolling three or more attacks and then testing the damage step of each. On some rolls at disadvantage it'll occur and others it seems to work as intended I can't imagine why but it's still occurring without anything that would interfere with the page.
1582734407

Edited 1582734539
This is done on Chrome in my 'Curse of Strahd' game with no extensions and all API disabled with the NPC sheet toggled to 'Public' and 'Disadvantage'. Even when it crit fails it's still occasionally thinking it crit on those damage rolls unless it crits there should be no + with a second damage step. I can tell it's thinking it's crit because it's applying the second rolls with no proficiency or damage bonus as in when it's adding that + for the second damage it's only doubling the damage die. Not a massive issue but it's a bit annoying since my players do tend to impose disadvantage in various ways on the creatures and I'd like to be able to roll at disadvantage without double checking each roll. I can't imagine what's causing it but I can replicate it reliably without any extensions or API.
1582768759

Edited 1582827446
This test was done on a fresh install of Firefox in my 'Curse of Strahd' game after deleting the disabled API scripts in the game just incase they were still somehow effecting it. I will be re-enabling API and extensions now to do my prep for this weekends game but as far as I can tell the API and extensions aren't affecting it after successfully replicating on a fresh install of Firefox as it's not my default browser. Also worth noting 'auto roll damage and crit' is off but maybe it's confused and assumes it's on or something. I have no idea why it's happening but it does seem to think it's critting even on crit fails. I understand your team is busy with way more immediate issues and it's a really niche issue that doesn't really affect someone's game all that much but I would greatly appreciate a fix whenever the team has time to look into it. Not a deal breaker just a bug fix that would make running my games a little easier.
I am seeing this issue too.  Here are a selection of rolls I made with a "Thug" NPC.  Some of them are treated as crits and some aren't...
It looks like it rolls a crit when the left hand number is greyed out.
I see the latest hotfix claims this is fixed... <a href="https://app.roll20.net/forum/post/8475767/release-note-for-april-15-2020-hotfix" rel="nofollow">https://app.roll20.net/forum/post/8475767/release-note-for-april-15-2020-hotfix</a> "NPCs no longer roll crit damage on non-critical hits" However, it only seems partially fixed to me... The first damage roll was made by clicking on the word "Morningstar", the second one was made by clicking on the word "Attack".&nbsp; The "attack" one is still producing a crit.