I just hopped onto the dev server. The button dragging from repeating sections remains broken.
keithcurtis said:
I just hopped onto the dev server. The button dragging from repeating sections remains broken.
It definitely is. The buttons in repeating sections are being detected, since the cursor changes when you are over a button, but it never generates the little bit you drag to the bar like it does for the buttons outside repeating sections.
Lol half of me finds this really exciting and half of me doesn't understand a word of it :D
I feel like I sort of brute-force stumbled my way through making my first sheet, but I hope these options mean that more people find it easier to try stuff out because that would be awesome
Kitten said:
Lol half of me finds this really exciting and half of me doesn't understand a word of it :D
I feel like I sort of brute-force stumbled my way through making my first sheet, but I hope these options mean that more people find it easier to try stuff out because that would be awesome
I feel exactly the same way!
I have been coding almost non stop these last two weeks, testing and refining the new features. I cannot wait to get them online for all the players to use!
Hi there, everyone!
I've got some answers for your questions and I'd like to go ahead and address the concern about repeated action functionality!
We were not aware that repeating section rolls were not functioning We are working to resolve this issue immediately. Thank you for bringing this to our attention!
Marco M. and Vince: Via our developers: We will be allowing a tags, but the href must be an anchor link (starting with the # symbol)
TK J. said:
Hi there, everyone!
I've got some answers for your questions and I'd like to go ahead and address the concern about repeated action functionality!
We were not aware that repeating section rolls were not functioning We are working to resolve this issue immediately. Thank you for bringing this to our attention!Marco M. and Vince: Via our developers: We will be allowing a tags, but the href must be an anchor link (starting with the # symbol)
Please let me know if you have further questions and absolutely keep those reports coming!-TK
<a href="#">Great</a>
Hey folks! Just wanted to let you know that the issue with repeating sections not being drag-able or available to add to the macro quick bar has been fixed and is live on the dev server. Thanks again for letting us know about this!
Hey folks! The bug mentioned by Chris D. has been addressed. Additionally, a bug was discovered with previous/current values in the setWithWorker sheet worker which has also been fixed. Both of these fixes are now available for testing on the dev server.
I have a question about the new "id" identifier: will it be possible to create new div or append options using it, or this still goes against the DOM limits?
For example, I was looking on how to add a select with a variable number of elements or a datalist with a variable number of elements would be great. At the moment the best option would be doing some clever and messy CSS wizardry with hidden checkbox that behaves as radio button (Thanks to @Scott C. and @Jakob to come up with that), but using id it would be dirty simple
Example
To add an option:
function addOption(optText,optValue){
let dl = document.getElementById('mylist');
for (; i < len; i += 1) {
var option = document.createElement('option');
option.value = optValue;
option.innerHTML=optText;
dl.appendChild(option);
}
}
To remove an option:
function removeOption(optNum){ \\ find the number of the repeating skill removed in an old vs new array let dl = document.getElementById('mylist'); dl.options[optNum].remove(); }
With the HTML
<datalist id="mylist"> <\datalist>
Now in many cases it could be even simpler to recreate the datalist from an array every time the name of a skill is changed (if that's what you are using the datalist for) cause the number of elements is relatively small and there is less chance of making any mistake.
The javascript functions that affect the DOM, like appendChild, are still not available in sheetworkers. No longer sanitizing ids out has nothing to do with these functions.
Nicholas said:
Hey folks! The bug mentioned by Chris D. has been addressed. Additionally, a bug was discovered with previous/current values in the setWithWorker sheet worker which has also been fixed. Both of these fixes are now available for testing on the dev server.
Sounds good that more bugs are getting fixed day by day! :)
Are there any plans to tackle the problem with Ghost Rows https://app.roll20.net/forum/post/9643364/bug-ghost-rows-in-repeating-sections-when-a-dash-is-used-in-the-section-name before going to the live servers?
David said:
With custom sheets on the development server when legacy sanitation is turned off the old Roll20 basic classes such as 3colrow still have "sheet-" prefixes
Any news on this? This effects a large number of sheets.
David said:
David said:
With custom sheets on the development server when legacy sanitation is turned off the old Roll20 basic classes such as 3colrow still have "sheet-" prefixes
Any news on this? This effects a large number of sheets.
Hey David -
If you are using the legacy sanitization settings, which are enabled by default for all existing sheets, then yes, "sheet-" will be prepended to those classes and everything will work as it did before.
However, if you make the swap to the new sanitization system, then "sheet-" is not prepended and you will have to manually add "sheet-" to those classes (row, 2colrow, etc.) in order to use them.
Does that make sense? Or was there anything I can clarify there?
So, found an issue with the new sanitization. I think there still needs to be some sanitization or maybe the iframe needs to be localized differently. As the system currently stands, doing something like:
div{
display:none;
}
causes everything about the character except for the character header (where the character's name and the edit button are located) to not be displayed. This is almost certainly not the desired behavior.
Scott C. said:
This is almost certainly not the desired behavior.
Lol, master of understatement there.
Scott C. said:
So, found an issue with the new sanitization. I think there still needs to be some sanitization or maybe the iframe needs to be localized differently. As the system currently stands, doing something like:
div{
display:none;
}causes everything about the character except for the character header (where the character's name and the edit button are located) to not be displayed. This is almost certainly not the desired behavior.
I would say that it is the sheet authors responsibility to avoid having such a statement in their CSS file.
Either remove or edit it with appropriate classes should do the trick
My point though is that code like this exists in tons of sheets, and looking forward to the eventual sunsetting of the legacy sanitizer, that will cause a major break in many sheets.
Scott C. said:
My point though is that code like this exists in tons of sheets, and looking forward to the eventual sunsetting of the legacy sanitizer, that will cause a major break in many sheets.
Yes. The bright shiny new toys are wonderful. But my concern, and I am sure others with multiple sheets going back years, what is likely to break, how much time do we have to fix it and what tools are we be given to fix and test them.
TK J. said:
Hi there, everyone!
I've got some answers for your questions and I'd like to go ahead and address the concern about repeated action functionality!
We were not aware that repeating section rolls were not functioning We are working to resolve this issue immediately. Thank you for bringing this to our attention!Marco M. and Vince: Via our developers: We will be allowing a tags, but the href must be an anchor link (starting with the # symbol)
Please let me know if you have further questions and absolutely keep those reports coming!-TK
<a href="#">Wow! Thank you so much</a>
Marco M. said:
TK J. said:
Marco M. and Vince: Via our developers: We will be allowing a tags, but the href must be an anchor link (starting with the # symbol)
<a href="#">Wow! Thank you so much</a>
What's the implications and usercases for <a href="">, will it be useful for creating popups only, or also for making links between parts of a sheet? Or even enable creating links to other sheets or handouts? Assume it can't be used for creating links to other parts of the website, like to the external compendium, the forums or wiki?
Anyway, I added this example to the wiki, anyone who understands it better feel free to improve it. https://wiki.roll20.net/Character_Sheet_Enhancement#Popup
Also, adding links to sheet code using the new features would be great as well, so we have more examples and see what others have done.