Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Windows system breaks Only War Enhanced sheet's ranged attacks

The new window update has resulted in the Only War Enhanced sheet's ranged attacks being broken. Proof (Video): <a href="https://i.gyazo.com/50af714304903d023eb8a929be8a439e.mp4" rel="nofollow">https://i.gyazo.com/50af714304903d023eb8a929be8a439e.mp4</a> Where the linked point leads: The code for the ranged weapon attack: &lt;button name='weapon_hit' class='equipment_ranged_weapons_gs_a4 full_width clear' type='roll' value='@{to-gm}&amp;{template:mythic} {{character= @{character_name}}} {{attack= }} {{weapon= @{R_weapon_name}}} {{burstwin=[[ceil([[[[1+ floor(abs([[{{ {@{R_weapon_target}+@{inlinemod-toggle}}, {@{bsTotal}-@{limiter}}}kh1, {@{bsTotal}+@{limiter}}}kl1]]-[[1d100@{R_weapon_mishap_chance}]])/10)]]+ceil(@{BS_unnat}/2)]]/2)]]}}{{target= $[[0]]}}{{roll= $[[1]]}}{{dof= $[[2]]}}{{dos=$[[3]]}} @{settings_hitroll} {{aim= [[@{R_weapon_aim}]]}}{{R_type= [[@{R_weapon_attack}]]}}{{range= [[@{R_weapon_attack_range}]]}}{{modifier= [[@{inlinemod-toggle}]]}}{{stat_name= Ballistic Skill}}{{stat=[[@{BS}]]}}{{advancement= [[@{BS_advancement}]]}}{{hitmod= [[@{R_weapon_mod1}]]}}{{trained= [[@{R_weapon_trained}-20]]}}{{burst=@{R_weapon_burst}}}{{auto=@{R_weapon_auto}}}{{fatigued=[[@{fatigued}]]}} !ammo @{character_id} repeating_rangedweapons_@{id}_R_weapon_mag [[@{ammo}*@{R_weapon_setting}]]'&gt;Hit |&lt;input name='attr_R_weapon_target' value='@{bsTotal} + @{R_weapon_trained} - 20 + @{R_weapon_mod1} + @{R_weapon_attack} + @{R_weapon_aim} + @{R_weapon_attack_range} + @{atk_accurate_aim}+@{fatigued}' class='input_background input_char_background' disabled &gt;&lt;/button&gt; The code for the melee weapon attack: &lt;button name='weapon_hit' class='equipment_melee_weapons_gs_a4 full_width clear' type='roll' value='@{to-gm}&amp;{template:mythic} {{character= @{character_name}}} {{attack= }}{{weapon= @{M_weapon_name}}}{{burstwin=[[ceil([[[[1+ floor(abs([[{{ {@{M_weapon_target}+@{inlinemod-toggle}}, {@{wsTotal}-@{limiter}}}kh1, {@{wsTotal}+@{limiter}}}kl1]]-[[1d100]])/10)]]+ceil(@{WS_unnat}/2)]]/2)]]}}{{target= $[[0]]}}{{roll= $[[1]]}}{{dof= $[[2]]}}{{dos= $[[3]]}} @{settings_hitroll} {{aim= [[@{M_weapon_aim}]]}}{{M_type= [[@{M_weapon_attack}]]}}{{multi= [[@{M_weapon_multi}]]}}{{modifier= [[@{inlinemod-toggle}]]}}{{stat_name= Weapon Skill}}{{stat=[[@{WS}]]}}{{advancement=[[@{WS_advancement}]]}}{{hitmod=[[@{M_weapon_mod1}]]}}{{trained=[[@{M_weapon_trained}-20]]}}{{WS_bonus=[[@{wsB}]]}}{{fatigued=[[@{fatigued}]]}}' &gt;Hit |&lt;input name='attr_M_weapon_target' value='@{wsTotal}+@{M_weapon_trained}-20+@{M_weapon_mod1}+@{M_weapon_attack}+@{M_weapon_aim}+@{M_weapon_multi}+@{fatigued}' class='input_background input_char_background' disabled &gt;&lt;/button&gt; I'm posting this here rather than on the actual sheet thread because the problem may be something that extends past this isolated example, but will just move this to the relevant singular thread if necessary
1671199352
timmaugh
Forum Champion
API Scripter
Cross-posting to raise awareness that this does seem to be more widespread: <a href="https://app.roll20.net/forum/permalink/11232602/" rel="nofollow">https://app.roll20.net/forum/permalink/11232602/</a> A Plus user (Mike D - don't call him heavy, he just crushes a lot), using a standard chat button gets the message: "TypeError: Cannot read properties of undefined (reading 'models')" He was using a button like: [button](!&amp;#13;#macro) Which works for me (a Pro user), but not him. Could it be something like the implementation of the new windows assumed that bangsy messages automatically denoted a Pro user... missing this use case... and started on a path of code that was looking for a models array that didn't exist? Unfortunately, history says...
1671220190
Bodo
Pro
Sheet Author
Is the issue worked on? Do we have any feedback / acknowledgement from Roll20 support?&nbsp;
Update: I have tested the exact same code as the hit roll but without the ammo api call portion and it works splendidly
Hey folks - this issue should be resolved now, we posted a fix about 30 minutes ago, so, Tobor500 -- you will have been using the updated code. Sorry for the interruption to your games, and thank you for the reports!
I mean, I'd been on there about an hour without refreshing and I did them side-by-side to make sure my improvised macro worked and found that the old one still didn't at the time of my macro testing. Still, glad to not have to use it.