My Macro stop working

Hi Nazamura, there were probably special character substitutions (a hack needed for nested query macros), but once you opened the macro to edit, the vtt converts the special characters which now breaks your macro. <a href="https://wiki.roll20.net/Macros#Nesting_in_a_Roll_Query" rel="nofollow">https://wiki.roll20.net/Macros#Nesting_in_a_Roll_Query</a> You'll need to substitute the special characters, back it up somewhere if you ever need/want to edit it in the future because it will convert them again if you ever open it. ;-( Another option is to use a "macro-mule" character that holds your macros so you don't have to worry about the vtt converting when editing. <a href="https://wiki.roll20.net/Macro_Character_Sheet" rel="nofollow">https://wiki.roll20.net/Macro_Character_Sheet</a> And finally, you could ditch the nested queries and create a chat menu. <a href="https://wiki.roll20.net/Chat_menus" rel="nofollow">https://wiki.roll20.net/Chat_menus</a> Cheers

1701654428

Edited 1701654769

something happened because I made those macros in 2014, and I never needed to update them till today when I re-log and decided to gameplay again, and saw that I could do something to improve, and then "bam" it crashes... so any new rules on macros now? when you say "special characters" do you mean the Brazilian types? or latin-1 type? what I need is to work as previously, a nested querys but with &{template:default} for beautiful outputs...

1701658070

Edited 1701658096

Pro

What was the original macro that you used in 2014? Do you still have a copy of it? It had html entity substitutions in it (such as &#125; instead of a } ).  When you put html substitutions in a Collections Macro, it will save just fine. But as soon as you open the macro then those substitutions will be replaced and each &#125; becomes a } .  The other substitutions are for commas and vertical pipe characters if they are in nested queries.  So you need to recopy the original macro with the html substitutions again, or else figure out which ones need to be substituted and recreate it. 

1701707669

unfortunatelly no, so, it seems that all } that are inside the red bracket should be replaced then? the other macros works exactly the same as this one, but they are still working (thanks to you i know if i hit save ill mess them up)

1701707908

heh, i made the replacement, and the macro doesnt even open up... please help ?{Lore|Arkham,&{template:default&#125; {{name=@{selected|token_name&#125;: Teste de Conhecimento (Lore)&#125;&#125;{{Conhecimento (Lore) Atual=@{selected|Lore&#125;&#125;&#125; {{Bônus de Habilidade (Skill) =@{selected|Lore Bonus&#125;&#125;&#125;{{Dificuldade =?{Dificuldade|-1&#125;&#125;&#125; {{@{Arkham|Evento&#125; = @{Arkham|Lore&#125;&#125;&#125;  /roll [[@{selected|Lore&#125;+@{selected|Lore Bonus&#125;+@{Arkham|Lore&#125; +?{Dificuldade|-1&#125;]]d6>@?{Condition|Normal,5|Bless,4|Cursed,6&#125;|Outro Mundo, &{template:default&#125; {{name=@{selected|token_name&#125;: Teste de Conhecimento (Lore) - Outro Mundo&#125;&#125;{{Conhecimento (Lore) Atual=@{selected|Lore&#125;&#125;&#125;{{Bônus de Habilidade (Skill) =@{selected|Lore Bonus&#125;&#125;&#125;{{Dificuldade =?{Dificuldade|-1&#125;&#125;&#125; /roll [[@{selected|Lore&#125;+@{selected|Lore Bonus&#125;+?{Dificuldade|-1&#125;]]d6>@?{Condition|Normal,5|Bless,4|Cursed,6&#125;|Usando Pista,&{template:default&#125; {{name=@{selected|token_name&#125;: Pista em Conhecimento (Lore)&#125;&#125; {{Bônus de Habilidade (Skill) =@{selected|Lore Bonus&#125;&#125;&#125; /roll [[1+@{selected|Lore Bonus&#125;+@{selected|Joe&#125;]]d6>@?{Condition|Normal,5|Bless,4|Cursed,6&#125;}

1701709428

Pro

Try this (untested): &{template:default} {{name=@{selected|token_name}: ?{Lore| Arkham,Teste de Conhecimento (Lore)&rbrace;&rbrace; {{Conhecimento (Lore) Atual=@{selected|Lore}&rbrace&rbrace {{Bônus de Habilidade (Skill) =@{selected|Lore Bonus}&rbrace&rbrace {{Dificuldade =?{Dificuldade&vert-1&rbrace;&rbrace&rbrace {{@{Arkham|Evento} = @{Arkham|Lore}&rbrace&rbrace /roll [[@{selected|Lore}+@{selected|Lore Bonus}+@{Arkham|Lore} +?{Dificuldade&vert-1&rbrace;]]d6>@?{Condition&vert;Normal&comma;5&vert;Bless&comma;4&vert;Cursed&comma;6&rbrace;| Outro Mundo,Teste de Conhecimento (Lore) - Outro Mundo&rbrace&rbrace {{Conhecimento (Lore) Atual=@{selected|Lore}&rbrace&rbrace {{Bônus de Habilidade (Skill) =@{selected|Lore Bonus}&rbrace&rbrace {{Dificuldade =?{Dificuldade&vert-1&rbrace;&rbrace&rbrace /roll [[@{selected|Lore}+@{selected|Lore Bonus}+?{Dificuldade&vert-1&rbrace;]]d6>@?{Condition&vert;Normal&comma;5&vert;Bless&comma;4&vert;Cursed&comma;6&rbrace; | Usando Pista,Pista em Conhecimento (Lore)&rbrace&rbrace {{Bônus de Habilidade (Skill) =@{selected|Lore Bonus}&rbrace&rbrace /roll [[1+@{selected|Lore Bonus}+@{selected|Joe}]]d6>@?{Condition&vert;Normal&comma;5&vert;Bless&comma;4&vert;Cursed&comma;6&rbrace;} One error you were definitely making is that you were making html entity replacements within attribute calls (any reference that uses an @ symbol, such as '@{Arkham|Lore}'.  Never use html replacements in attribute calls . Anything that is the same in each query output can be moved outside the query as well. I moved '&{template:default} {{name=@{selected|token_name}: ' outside of the query. I think you may still need a 'line break' before each of the /roll commands, but if you said it was working before then maybe not. I never use the default template so I'm not familiar with out that will parse out. I also recommend saving this macro on a Macro Mule character - create a character named 'Roll Macros' and save this as an ability called 'LoreRoll'. Then create a Collections Macro to call it with this code.  If your players need to use the roll, then make sure to set 'Lore' to 'All Players' as well as the 'Roll Macros' character to be controlled by 'All Players' (but not visible in their Journals). Lore %{Roll Macros|LoreRoll} &{noerror}

1701717151

Pro

Sheet Author

API Scripter

Alternatively, explore whether you can replace this macro with chat menu button (and a bunch of smaller macros that players never see). You might be able to avoid html substitutions completely.

1701719604

It's displaying this now, i believe might have an extra &vert somewhere

1701721779

&{template:default}{{name=@{selected|token_name}: ?{Lore|Arkham,Teste de Conhecimento (Lore)&rbrace;&rbrace;{{Conhecimento (Lore) Atual=@{selected|Lore}&rbrace;&rbrace;{{Bônus de Habilidade (Skill) =@{selected|Lore Bonus}&rbrace;&rbrace;{{Dificuldade =?{Dificuldade&vert-1&rbrace;&rbrace;&rbrace;{{@{Arkham|Evento} = @{Arkham|Lore}&rbrace;&rbrace; /roll [[@{selected|Lore}+@{selected|Lore Bonus}+@{Arkham|Lore}+?{Dificuldade&vert-1&rbrace;]]d6> @?{Condition&vert;Normal&comma;5&vert;Bless&comma;4&vert;Cursed&comma;6&rbrace;|Outro Mundo,Teste de Conhecimento (Lore) - Outro Mundo&rbrace;&rbrace;{{Conhecimento (Lore) Atual=@{selected|Lore}&rbrace;&rbrace;{{Bônus de Habilidade (Skill) =@{selected|Lore Bonus}&rbrace;&rbrace;{{Dificuldade =?{Dificuldade&vert-1&rbrace;&rbrace;&rbrace; /roll [[@{selected|Lore}+@{selected|Lore Bonus}+?{Dificuldade&vert-1&rbrace;]]d6> @?{Condition&vert;Normal&comma;5&vert;Bless&comma;4&vert;Cursed&comma;6&rbrace;|Usando Pista,Pista em Conhecimento (Lore)&rbrace;&rbrace;{{Bônus de Habilidade (Skill) =@{selected|Lore Bonus}&rbrace;&rbrace; /roll [[1+@{selected|Lore Bonus}+@{selected|Joe}]]d6>@?{Condition&vert;Normal&comma;5&vert;Bless&comma;4&vert;Cursed&comma;6&rbrace;} this was the closests i get...

1701722213

Pro

You may need to replace the nested ?s as well - you would use &quest; as the replacement. I’m on mobile so I can’t check. 

1701723466

which one ?

1701890664

anyone?

1701891781

Pro

Sheet Author

API Scripter

It doesn't look like it. It's a big complex macro. I'd recommend breaking it up for a chat menu, as I mentioned earlier. That way you wont have to bother with html substitutions.

1702133136

i did, and still not working, it seems i have to replace something where it says "Dificuldade&vert-1", can you help me? &{template:default}{{name=@{selected|token_name}: ?{Lore|Arkham,Teste de Conhecimento (Lore)&rbrace;&rbrace;{{Conhecimento (Lore) Atual=@{selected|Lore}&rbrace;&rbrace;{{Bônus de Habilidade (Skill) =@{selected|Lore Bonus}&rbrace;&rbrace;{{Dificuldade = ?{Dificuldade&vert-1&rbrace;&rbrace;&rbrace; {{@{Arkham|Evento} = @{Arkham|Lore}&rbrace;&rbrace; /roll [[@{selected|Lore}+@{selected|Lore Bonus}+@{Arkham|Lore}+?{Dificuldade&vert-1&rbrace;]]d6> @?{Condition&vert;Normal&comma;5&vert;Bless&comma;4&vert;Cursed&comma;6&rbrace;|Outro Mundo,Teste de Conhecimento (Lore) - Outro Mundo&rbrace;&rbrace;{{Conhecimento (Lore) Atual=@{selected|Lore}&rbrace;&rbrace;{{Bônus de Habilidade (Skill) =@{selected|Lore Bonus}&rbrace;&rbrace;{{Dificuldade =?{Dificuldade&vert-1&rbrace;&rbrace;&rbrace; /roll [[@{selected|Lore}+@{selected|Lore Bonus}+?{Dificuldade&vert-1&rbrace;]]d6> @?{Condition&vert;Normal&comma;5&vert;Bless&comma;4&vert;Cursed&comma;6&rbrace;|Usando Pista,Pista em Conhecimento (Lore)&rbrace;&rbrace;{{Bônus de Habilidade (Skill) =@{selected|Lore Bonus}&rbrace;&rbrace; /roll [[1+@{selected|Lore Bonus}+@{selected|Joe}]]d6>@?{Condition&vert;Normal&comma;5&vert;Bless&comma;4&vert;Cursed&comma;6&rbrace;}

1702135695

Edited 1703182459

Pro

Sheet Author

API Scripter

That looks like a query inside a query, and for those, you need to double up on the html entities (adding an extra &amp; ) That's all the help I will give - I gave up on html entities a long time ago (except where absolutely necessary), and use chat menus instead where possible now. Show a chat menu version and I'll help with that.

1702138886

Edited 1702138945

keithcurtis

Forum Champion

Marketplace Creator

API Scripter

GiGs said: That looks like a query inside a query, and for those, you need to double up on the html entities (adding qn extra &amp; ) That's all the help I will give - I gave up on html entities a long time ago (except where absolutely necessary), and use chat menus instead where possible now. Show a chat menu version and I'll help with that. Sad to say, but that's the way I generally feel too. Entity replacement-laden macros are eye-watering and make my head swim. I feel for folks who really want to go this route, but it's so much work to wrap my brain around.

1703004823

Edited 1703182351

Pro

Sheet Author

API Scripter

Edit: this is a reply to a post that has been deleted and is not visible any more. This is not a forum for casual meetups. Comments must specifically relate to roll20.

1703004915

Pro

Tony M. said: Was same problem, thanks for resolve. Is here anyone who plays cs2 and follow bo3 team ranking ? Have a good day anyone ! GiGs said: This is not a forum for casual meetups. Comments must specifically relate to roll20. Just another bot. No hours or games played and account was just created today. :/

1703005095

Pro

Sheet Author

API Scripter

You're right, I didn't look at the rest of the thread.

1703168016

@GiGs whats a chat menu and how to do it? is there an youtube video guiding it ?

1703180139

keithcurtis

Forum Champion

Marketplace Creator

API Scripter

Some links: Chat Menu Macro Character Sheet The chat menu allows you to click on buttons in chat instead of messing with difficult nested queries, a Macro Character Sheet (or Macro Mule) allows you to save your macros as Actions on a character sheet, rather than Macros in the Collections tab. Actions generally do not require html substitutions. The links have more details.

1703185045

Edited 1703185086

Pro

Sheet Author

API Scripter

As ever, Keith is fastest with links :) Actions generally do not require html substitutions. The generally part here is worth notice. If your original macro has a query, and the destination macro also has a query, you iwll need html substitutions. The beauty of chat menus is that by replacing the query in the original macro with a rolltemplate of buttons, you avoid the need for that first query.

1703764440

Edited 1703764584