Inline Styles removed

Hi all I am authoring 2 sheets that have been around for many years, before the guidelines to use grid/flex layouts instead of table-based layouts & CSS classes instead of in-line styles. I haven't changed the sheet when the CSE came out, so I'm still using the old sanitzation system (legacy: true in sheet.json) Since the last PR integrated in the Roll20 repo 2 weeks ago, the Roll20 engine has suddenly decided to remove all inlines style attributes, resulting in a messed up layout. However this unwanted sanitization does not happen in the sandbox nor when using the "Custom" option in the game settings, checking the legacy check box and pasting the HTML and CSS. I have opened a support request but haven't got any satisfying answer.  Has anyone seen this kind of behaviour before, was it fixed and if yes, how ? TIA for any insight / solution

I haven't noticed any inline css getting stripped out unless it was some newer css that roll20 didn't appear to support. When this did happen, it happened in Custom as well as Live (this was pre-sandbox btw).&nbsp; Post sandox addition, I haven't noticed any differences between them.&nbsp; Toggling legacy does make a difference though.&nbsp; Mainly if you have a legacy sheet and try to run it with legacy mode off or if you try features that are only available in non-legacy. For clarity, you said; ...so I'm still using the old sanitzation system (legacy: true in sheet.json) Make sure that the sheet.json is set using "legacy" : true Note the quotes. <a href="https://jsonlint.com/" rel="nofollow">https://jsonlint.com/</a> is handy for verifying syntax. Just something to check. Curious to hear what info you get back from roll20. Cheers

Hi Vince Thanks for your answer I was lazy with quotes when posting on the forum, but not when submitting the PR ;-) Here are the sheet.json in the Github repo <a href="https://github.com/Roll20/roll20-character-sheets/blob/master/ChroniquesGalactiques/sheet.json" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/blob/master/ChroniquesGalactiques/sheet.json</a> <a href="https://github.com/Roll20/roll20-character-sheets/blob/master/ChroniquesOublieesContemporain/sheet.json" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/blob/master/ChroniquesOublieesContemporain/sheet.json</a> They both look good to me I initially saw the issue on an img element with its style attribute removed and the image not being the correct size so that's what I reported, but I did not check the whole sheet. Then I saw on the other sheet that a style="display: none;" was being removed as well, and so an element that I want hidden is displayed in the middle of nowhere. Then I also discovered that the issue did not happen in the sandbox and when using a Custom sheet and pasting the exact same HTML and CSS. But the response of Roll20 support 3 days ago has been only for my initial post about the img element. Radio silence since then. I have no time to invest in rewriting these sheets, CSS trickery is a major pain for me. I just need them to work as before.

Looks like other's are seeing this as well... <a href="https://app.roll20.net/forum/permalink/11896854/" rel="nofollow">https://app.roll20.net/forum/permalink/11896854/</a>

Might try adding class="hidden" instead of style="display: none;" I believe "hidden" is a system recognized class.

Thanks Vince. I’m quite mad at Roll20 right now and won’t change anything.&nbsp; The buggy sanitization impacts more inline styles than the display: none stuff&nbsp;

If inline styles are being removed I can think of only two explanations: It's something specific to your character sheet, and Roll20 need to get working on a solution. Your suggestion about inline styles being disabled is accurate, and Roll20 will need to get working on fixing it. If it is affecting more sheets than yours, it will affect many, many sheets. Lots of sheets use inline styles, and many of the sheets wont have anyone actively maintaining them. I could see Roll20 deciding to force the hand of new developers to stop using inline styles (they are generally discouraged), but I can't see them doing this to affect older sheets by choice so it sounds like a bug. This sounds like something that should be raised as a big in the bug forum so that more people see it.

I just checked one of my legacy sheets on the live server and it still has all of it's inline styling, including display: none. checked on FF Maybe this is sheet-specific problem...?&nbsp; IDK example; here's the code with inline css Here's the sheet live showing the code is there and has not been removed or effecting the sheet negatively.

Vince Since the inline styles removal does not happen in the sandbox and when using the custom sheet and pasting the code, s ince the code in the Github repo is correct as far as I know, a nd as you haven't submitted any change for your AD&amp;D sheet for 11 months whereas I submitted an update 2 weeks ago, I suspect something wrong happened when the sheet was copied from Github to the live server GiGs Apparently it affects at least another sheet that I am not authoring. It looks like it's happening in the sheet display but the last change made a couple of weeks ago was one small change in the roll template I'll try posting an issue on the other forum section. I also have a support request opened but haven't got any update for a few days now and I'm afraid that the Roll20 team hasn't got all my updates given the last answer I got (they focused on img inline style removing whereas I see it occuring on other elements)

can confirm this bug is affecting Rogue trader improved sheet everything looks fine in the custom sheet sandbox or custom sheet html/css&nbsp;

Hi Drespar So we need to make a dummy change to the HTML and CSS files, re-submit a PR for the fix to be applied, and wait 2~3 days (usual time before a PR is merged) to see if the fix worked ?

Drespar said: Hi again folks, The development team has informed me that the fix for this issue should be live and the workaround should now be properly viable: Make sure the sheet.json "legacy" flag is set to the intended state. If it is wrong, push the update and wait. Push an update to HTML and CSS files so they get re-sanitized (these can be together) We presently fixed one sheet manually and are looking towards a more widespread fix for affected sheets, but that will take a bit more time. Was the fix done after today's merge? I made changes to the old 1e sheet last night in the hopes of reducing some of these problems. ie removing a few of the worst inline styles issues.&nbsp; After the merge the live sheet is still having the inline styles removed and even using sheet-hidden is being ignored as well. Just a few of the inline and roll20 base css classes being ignored after today's merge. here's the same code in the sandbox right now

@Drespar and others I have NOT re-submitted a PR for the sheet yet But I can already tell that the "fix" made things worse even in the sandbox or using a custom sheet This is the sheet before the PR Of Doom on May 1st This is the sheet today in the sandbox Looks like either this is ignored in the CSS @import url('<a href="https://fonts.googleapis.com/css?family=Maven+Pro&amp;display=swap" rel="nofollow">https://fonts.googleapis.com/css?family=Maven+Pro&amp;display=swap</a>'); Or this is not supported anymore : &nbsp; --cog-font: "Maven Pro"; .sheet-boxtitre { &nbsp; font-family: var(--cog-font);&nbsp; ... } FFS, what is going on ? I won't submit any PR until this is acknowledged and addressed

Hey there, in case this is not on your radar yet, when using ScriptCards, we have been able to access sheet CSS - using the imported fonts. That has stopped working. Note that we use Vince's updated sheet - not anything legacy. Since I suspect this is working for other sheets (like 5E games using fonts from the css in chat), I'm not sure why it stopped working with this sheet. Right now everything is coming through as times roman (insert Papyrus jokes here). Thanks for looking into it!&nbsp; ~D Drespar said: Hi again folks, The development team has informed me that the fix for this issue should be live and the workaround should now be properly viable: Make sure the sheet.json "legacy" flag is set to the intended state. If it is wrong, push the update and wait. Push an update to HTML and CSS files so they get re-sanitized (these can be together) We presently fixed one sheet manually and are looking towards a more widespread fix for affected sheets, but that will take a bit more time.

Driven by some morbid impulse, I just submitted a PR for the CO Galactiques sheet, without any real changes, other than changing the version label wherever it appears in the HTML and CSS comments as well as the README &amp; sheet.json files. I want to believe I won't see some new "unexpected enhancements" in the visuals of the sheet after the merge.&nbsp;

Until I see that this has actually been fixed, I'm afraid to submit a pr for any legacy sheet. (other than the old 1e sheet that's still broken by this bug that is.) You are testing fate StéphaneD... ;-)

as i read in some other posts, i think is the "legacy sanitation" that is sanitizing (ignoring) the html element based styling (inline) this is very painful to fix since everything looks fine in custom sheet mode/sandbox i have sent a PR for rogue trader improved, removing legacy sanitation altogether, when its merged ill post here the results.&nbsp;&nbsp;

It's very worrying if this affects all legacy sheets. I really think no one who is still creating sheets should be using legacy any more, modern code is just better in every way. But it's impractical for all legacy sheets to be manually updated - there are a lot of them that are no longer maintained.

GiGs Apparently, if a sheet using legacy has not been updated recently, it is not affected by the bug. So those that are not maintained anymore won’t be impacted. Drespar’s&nbsp;procedure for fixing sheets that have been affected is to submit another PR. Pretty sure something is broken when the sheets are copied from the Github repo to the live servers, but of course R20 has not disclosed what exactly is happening.&nbsp; I started maintaining those legacy sheets 5 years ago during a few months of unemployment between being let go and a web dev training, and that was a win-win situation for me, but now I really do not have any spare time to recreate those sheets with div/grid/flex layout, CSS classes or handlebars templating, although I’d love to. Just want this pesky Roll20 bug to be fixed…

StéphaneD said: GiGs Apparently, if a sheet using legacy has not been updated recently, it is not affected by the bug. That's great to know. I don't think anyone had said which sheets were affected, but if older sheets are fine, I'm not as concerned. For your problem: sometimes transferring a sheet from legacy to modern is an easy copy/paste operation, but sometimes its a lot trickier and can take many hours before you abandon it in frustration. I feel your pain.

For your problem: sometimes transferring a sheet from legacy to modern is an easy copy/paste operation, but sometimes its a lot trickier and can take many hours before you abandon it in frustration. I feel your pain. Thanks to your blog I understood what CRP was about (thanks a lot BTW). It was really badly documented by Roll20. I think my sheets would'nt suffer from this bug if I had "legacy": false in the json. The CO Fantasy sheet by my friend Ulti has it as well as a bunch of inline styles and it does not suffer from the bug. Unfortunately, CSE is one of those novelties poorly documented and I did not do anything when it came out as I couldn't figure out what needed to be done. Your current blog posts about handlebars are great. I'd love to rewrite the sheets using these techniques. I just do not have enough spare time to do it. And I'm afraid Beacon will not be for me either, as my knowledge of JS front-end librairies is superficial.

Thank you! And yes, rebuilding a sheet that is already written is a huge chore, and often is way more work than is warranted. If what works currently does work, keep using it. I think roll20's documentation problems are because the documentation is written by software engineers for software engineers, and doesn't really take into account that the vast majority of people who want to use it are not actually software engineers. If you can describe where things are falling short, I might be able to white a few posts that clarify things. If Beacon turns out to be useful to people without a lot of experience, i'll definitely be posting about that. Maybe I should write a guide for transferring a sheet from legacy to CSE - it's not really complicated, in principle, and some careful copy/paste operations can often make short work of it.

GiGs said: Thank you! And yes, rebuilding a sheet that is already written is a huge chore, and often is way more work than is warranted. If what works currently does work, keep using it. I think roll20's documentation problems are because the documentation is written by software engineers for software engineers, and doesn't really take into account that the vast majority of people who want to use it are not actually software engineers. If you can describe where things are falling short, I might be able to white a few posts that clarify things. If Beacon turns out to be useful to people without a lot of experience, i'll definitely be posting about that. Maybe I should write a guide for transferring a sheet from legacy to CSE - it's not really complicated, in principle, and some careful copy/paste operations can often make short work of it. I think the hardest part of converting a sheet from legacy to non-legacy/CSE involves converting tables.&nbsp; Again not that hard, but it can be difficult to emulate the exact layout/design with grid and flex for example. Many of these sheet are also using roll20's built-in css for rows and columns as well.&nbsp; It just takes "time" which is a scarce commodity for most people.

vince I was under the impression that the CSE did not suppress elements such as table for the layout, but rather allowed the use of more html elements&nbsp; As far as I understood it, to be able to use "legacy": false in the sheet.json : You need to remove the 'sheet-' prefix in your CSS classes both in the HTML and CSS files You must however keep it for sheet-rolltemplate classes and the Roll20-supplied col, row, 2colrow, 3colrow That's what I tried this morning before work. I changed the legacy setting to false in my sandbox game and loaded my modified files with the sheet- removed where they need to. The sheet is totally blank.&nbsp; Same on my test game I have created with the Custom sheet option and un-checking the legacy box. I may post it on a personal repo and ask for help from you guys... Now to the various Roll20 "fixes" If I change the sheet in the dropdown and select my sheet, this is what is displayed That's not the image of the character sheet, but if you look at the default settings, it looks like the sheet.json has been f*cked up, so Roll20 does not know which png to display.&nbsp; And my 4.5.1 update has not even been merged :( The good news is that the sheet layout issues previously reported seem to be fixed The bad news is that the Google Font I use for some of the headings and labels, which is imported in the CSS, is now ignored (see my comment above) Yesterday, it looks my friend Ulti's CO Fantasy character sheet got some issues too. He switched to CSE years ago and has the "legacy": false in his sheet.json. That did not prevent Roll20 to alter it in a very bad way, since the HTML file that was loaded in the games was not the correct one.&nbsp; I'll report back when my 4.5.1 update with no changes has been merged

As StephaneD mentionned, since that rolled out fix, the sheet I maintain, ChroniquesOubliees, doesn't display the correct html file specified in sheet.json. Could you please fix the fix?

Also, I noted that the image displayed in the sheet description is not the one specified in the sheet.json file either, like StephaneD showed earlier for his sheets.

Drespar said: Hi again folks, The development team has informed me that the fix for this issue should be live and the workaround should now be properly viable: Make sure the sheet.json "legacy" flag is set to the intended state. If it is wrong, push the update and wait. Push an update to HTML and CSS files so they get re-sanitized (these can be together) We presently fixed one sheet manually and are looking towards a more widespread fix for affected sheets, but that will take a bit more time. I'm confused.&nbsp; So a fix was released 5 days ago to address inline styles being removed for which sheets exactly? As-of this morning, I'm still not seeing any change on the live 1e Old/Legacy sheet.&nbsp; I've had a pr in since Thursday night #12933 which was supposed to "re-sanitize" the sheet.&nbsp; Are we still waiting to see if the sheet's from last week that received the fix worked? Thanks

Hi Drespar Yup, the layout issues due to the unwanted removal of inline styles have been fixed as far as I can tell I have seen a couple of additional&nbsp;bugs though : The Google Font imported in the CSS is ignored. I'm using CSS variables as well to reference it wherever needed. This worked before whatever change Roll20 did that triggered this whole thread There are a bunch of 'undefined' in the game settings and the png file used as sheet preview is not the one defined in the sheet.json manifest. Either&nbsp; the file has been corrupted on your servers, or the code that is supposed to load and parse it is broken. A similar issue happened to Ulti's sheet, as the HTML file loaded in the Roll20 app is not the one specified in his sheet.json

vince I'm confused.&nbsp; So a fix was released 5 days ago to address inline styles being removed for which sheets exactly? I don't know which sheet was manually fixed by Roll20. Not one of mines : I did not receive any notification from them and the sheet in my test game was still messed up until this morning I've had a pr in since Thursday night which was supposed to "re-sanitize" the sheet.&nbsp;&nbsp; Are we still waiting to see if the sheet's from last week that received the fix worked? I also made a PR on sunday afternoon. the only changes were the version label reference wherever it appeared (4.5.0 to 4.5.1 in the html, css, readme, sheet.json). I haven't received the merge notification for this PR and in the broken preview in my message above, it still says 4.5.0.

StéphaneD said: vince I was under the impression that the CSE did not suppress elements such as table for the layout, but rather allowed the use of more html elements I was under the impression that although you might "pass" the legacy check with the bare minimum changes, sheet authors should also follow the best practices <a href="https://wiki.roll20.net/Building_Character_Sheets#2._Good_Code" rel="nofollow">https://wiki.roll20.net/Building_Character_Sheets#2._Good_Code</a> which includes removing tables (ie new sheets have been blocked when designed with tables) I suppose this is just a guideline...?

From what I read in this good code guideline, tables can be used for tabular data. That should include skill tables or equipment lists, no?

Ulti said: From what I read in this good code guideline, tables can be used for tabular data. That should include skill tables or equipment lists, no? Those might be acceptable (I don't know, I'm not Roll20), but that's really not what you'll find. In older character sheets, it's very, very common for tables to be used in the layout of the whole sheet, or to create layouts of part of the sheet. This is because tables are percieved as very simple, and more advanced, 100% better systems (like CSS Grid) are not presented in an easy to understand way.

vÍnce said: I think the hardest part of converting a sheet from legacy to non-legacy/CSE involves converting tables.&nbsp; Again not that hard, but it can be difficult to emulate the exact layout/design with grid and flex for example. Many of these sheet are also using roll20's built-in css for rows and columns as well.&nbsp; It just takes "time" which is a scarce commodity for most people. Those are good points. Often the bggest stumbling block is suff that isn't directly related to legacy, but which people have used because CSE didn't exist.

vÍnce said: Drespar said: Hi again folks, The development team has informed me that the fix for this issue should be live and the workaround should now be properly viable: Make sure the sheet.json "legacy" flag is set to the intended state. If it is wrong, push the update and wait. Push an update to HTML and CSS files so they get re-sanitized (these can be together) We presently fixed one sheet manually and are looking towards a more widespread fix for affected sheets, but that will take a bit more time. I'm confused.&nbsp; So a fix was released 5 days ago to address inline styles being removed for which sheets exactly? As-of this morning, I'm still not seeing any change on the live 1e Old/Legacy sheet.&nbsp; I've had a pr in since Thursday night #12933 which was supposed to "re-sanitize" the sheet.&nbsp; Are we still waiting to see if the sheet's from last week that received the fix worked? Thanks After today's merge, it looks like the inline styles are being honored once again.&nbsp; Yay! Any idea what happened?

the roll20 bug fix they submitted (4 days ago) added 2 empty lines to the bottom of the document after the html tag, this did nothing for rogue trader removing all traces of legacy sanitation worked for the rogue trader sheet, now its CSE compliant it was painful but worth it

StéphaneD said: Hi Drespar Yup, the layout issues due to the unwanted removal of inline styles have been fixed as far as I can tell I have seen a couple of additional&nbsp;bugs though : The Google Font imported in the CSS is ignored. I'm using CSS variables as well to reference it wherever needed. This worked before whatever change Roll20 did that triggered this whole thread There are a bunch of 'undefined' in the game settings and the png file used as sheet preview is not the one defined in the sheet.json manifest. Either&nbsp; the file has been corrupted on your servers, or the code that is supposed to load and parse it is broken. A similar issue happened to Ulti's sheet, as the HTML file loaded in the Roll20 app is not the one specified in his sheet.json Looks like @font-face is being ignored on legacy sheets as well. <a href="https://app.roll20.net/forum/permalink/11918886/" rel="nofollow">https://app.roll20.net/forum/permalink/11918886/</a>

On my side, the sheet is now displayed correctly, so it can be used. But it seems the rest of the json file is somehow corrupted, as no sheet option is available anymore (all shown as undefined), and the sheet preview image displayed is a random image, not the one specified in the json file.

The old school essentials thread makes me wonder if there are other sheets that have gone screwy wher ete users don't know to comment on these threads.

I agree.&nbsp; The OSE sheet is only messed up on the live server.&nbsp; It loads fine in a Custom game for me. The OSE sheet only seems to be an issue in FF for some reason. Not sure if it's related. - As other's have noted however, the AD&amp;D1e Legacy sheet also has it's sheet.json sheet settings all locked at Undefined. - It also appears the @font-face no longer works on Legacy sheets anymore. Not sure if that is related either, but timing seems to line-up. Can we please get a Dev to comment on what's been going on?

It’s not only @font-face @import(…) of a Google Font is also ignored on legacy sheets

Was that ever supported on Legacy sheets?

Well, it was before this whole chain of bugs If you scroll up in this thread you'll see the preview of the sheet before the issue appeared, and how it is rendered now

GiGs said: Was that ever supported on Legacy sheets? Not sure if @font-face was ever officially supported (only Google fonts), but lots of sheets have been using them in the past.

Can you describe why this issue happened? What prompted the change that caused this inline styles issue?

My guess is that this was triggered by&nbsp; this commit &nbsp;which changed the way the sheet repos are read.

From reading&nbsp; the code there , it seems that the css files will have the same issue of ignoring the sheet.json specifications.

Hello all So the 4.5.1 update I did to my CO Galactiques sheet was merged yesterday. This update only changed the version label in the HTML, CSS, sheet.json and README of the sheet The inline style weren't stripped again so this bug is fixed The preview image in the game settings is correct, and no 'undefined' appear. However the sheet options defined in the sheet.json do not appear either. S o this bug is only partially fixed. The issue with the Google Fonts imported&nbsp;in the CSS being ignored is still there