Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Inline Styles removed

1717143995
Ulti
Pro
Sheet Author
API Scripter
Oh, that means that one needs a PR for the fix to take effect for the preview images and game settings, then?
1717145803
StéphaneD
Pro
Sheet Author
API Scripter
Oh, I should have paid more attention. No more "undefined" but no sheet options displayed either. I edited my prior comment  I guess it means that a) doing a PR will solve 75% of the issues that have impacted you (I don't think the CO Fantasy sheet is impacted by the ignored Google Fonts, it's plain old Verdana all around ;-) ) and that b) the Roll20 folks need to work a bit more on fixes for all these bugs.  I suspected from the beginning that something wrong was happening in the integration scripts that run between Github and the live servers. I haven't tried to read their code, but you probably nailed it
1717151365
Ulti
Pro
Sheet Author
API Scripter
There was a fixed committed 13 hours ago about the treatment of game settings, and your PR was merged 17 hours ago, StéphaneD. Maybe it's the reason why you don't see them?
1717154519
StéphaneD
Pro
Sheet Author
API Scripter
:( Let's apply the french saying "L'urgence c'est d'attendre" and wait for Roll20 input
GiGs said: Can you describe why this issue happened? What prompted the change that caused this inline styles issue? Sorry for the delay, I had to check with the team on the exact problem here. Our process for updating sheets was moved to a new home and in the migration, the github actions changed slightly. We weren't checking the sheet.json early enough in the process, so the actions didn't know how to handle the sheet and caused it to strip inline styles from sheets it shouldn't be stripping them from. To fix it, we had to manually trigger rebuilds on the sheets with the issues, so if there's somewhere where inline styles are still an issue, please tell us so we can run the rebuild on that sheet too! StéphaneD said: Hello all So the 4.5.1 update I did to my CO Galactiques sheet was merged yesterday. This update only changed the version label in the HTML, CSS, sheet.json and README of the sheet The inline style weren't stripped again so this bug is fixed The preview image in the game settings is correct, and no 'undefined' appear. However the sheet options defined in the sheet.json do not appear either. S o this bug is only partially fixed. The issue with the Google Fonts imported in the CSS being ignored is still there It turns out that the inline styles, the images, the settings, and the fonts are all separate issues, just vaguely linked to the above move of our processes. 1. Inline styles should be resolved everywhere. If anyone is still facing this issue, let us know. 2. Preview image should also be resolved, but may require a PR to force a rebuild on the sheet. This was linked to an issue with loading the wrong HTML file from the same directory as the sheet HTML file, so both of those should be resolved. 3. Settings issue is resolved but requires a rebuild of the sheet. We forced a rebuild specifically on CO Galactiques (as well as a few other sheets this issue was noticed on) to ensure it's actually fixed. 3. The font issue is still ongoing. We've identified the source of the problem, but the fix is going to require some deeper work and discussion so it won't be fixed before the weekend.
3. The font issue is still ongoing. We've identified the source of the problem, but the fix is going to require some deeper work and discussion so it won't be fixed before the weekend. Thanks for working on this. Please try to test accessing the CSS font through an API as well, such as ScriptCards. Sample font for CSS: @import url('<a href="https://fonts.googleapis.com/css2?family=Fira+Sans:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&amp;display=swap" rel="nofollow">https://fonts.googleapis.com/css2?family=Fira+Sans:ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&amp;display=swap</a>'); Here is a test script using ScriptCards: !script {{ --/|Replace the font name with whatever font is imported via the CSS, just make sure it is not one of the already included ones added to Roll20 (eg. something imported by the CSSfrom Google Fonts) --#bodyFontFace|Fira+Sans --+|This is a test. --X| }}
1717261777
Ulti
Pro
Sheet Author
API Scripter
Thank you for the detailed answer, Nicole. Concerning my sheet, everything is back to normal, thanks again!
1717579827
StéphaneD
Pro
Sheet Author
API Scripter
Hi all So a couple of days ago, I submitted an update for my other sheet CO Contemporain which is also a legacy sheet. This sheet does not use imported Google fonts and the inline styles issue had already been fixed by prior Roll20 hotfixes. The fix was only for rebuilding the sheet.json and correct the sheet settings and preview image, so it only had version label changes. The merge was done yesterday and worked as expected. Hope the imported fonts for my CO Galactiques sheet will be fixed soon
1717595009
keithcurtis
Forum Champion
Marketplace Creator
API Scripter
StéphaneD said: Hi all So a couple of days ago, I submitted an update for my other sheet CO Contemporain which is also a legacy sheet. This sheet does not use imported Google fonts and the inline styles issue had already been fixed by prior Roll20 hotfixes. The fix was only for rebuilding the sheet.json and correct the sheet settings and preview image, so it only had version label changes. The merge was done yesterday and worked as expected. Hope the imported fonts for my CO Galactiques sheet will be fixed soon HI&nbsp;Stéphane! I'm not sure if this announcement in other font-related threads is of any help, but here's the gist: Andrew Searles &nbsp;said: Hey Folks, Sorry for the delayed response on this one. Miles contacted us and let us know you were having problems. Here's the issue. Recently, we implemented security measures that restrict the use of fonts not delivered through Google Fonts. We have found that importing fonts can be a security risk, and we need to limit our exposure to that. As of right now, only fonts imported from Google Fonts work. We are quickly looking for safe ways around this to give you all the font options you'd like to use, but for now, I'd suggest looking to see if there are Google Fonts you can use in the meantime. I'll keep you posted with what we learn. Sorry for the inconvenience.
1717596277
StéphaneD
Pro
Sheet Author
API Scripter
Hi Keith Thanks for the comment My CO Galactiques sheet does use a Google Font (namely « Maven Pro ») which I import in my CSS file.&nbsp; Roll20 has had several issues in the past weeks that impacted legacy sheets and broke things that used to work, and it looks like this font issue is one of them. Most of the issues were fixed internally or by asking us to submit an update for the sheet to be re-processed and re-deployed to the live servers. That’s what I did, without changing anything apart the version label, and it worked for the most part. The remaining issue is this Google Font import which is now ignored for some reason.
Wanted to confirm (Google) fonts imported using the sheet CSS are back working using the API. Thanks all for fixing this! Cheers.
1717662394
StéphaneD
Pro
Sheet Author
API Scripter
Hi I confirm that the Google fonts issue is fixed, everything is back to normal as far as I can tell Thanks everyone for all the help and insight