[Script] PowerCards 3 (Thread 3)

Can't nest, but you can just add AND $Ammo.total >= 1 to the attack roll lines.

FGIsembard said:

Hello. I'm having trouble with Macros, I haven't tried anything complex but i am getting me this message in Chat:

!power {{
--name|PowerCard Test
--!Test|This is a test.
}}

FGIsembard said:

Hello. I'm having trouble with Macros, I haven't tried anything complex but i am getting me this message in Chat:



Hoping some one can suggest what I have done wrong. I have tested a few other people macros to check, but get the same message.

Thanks

!ammo @{selected|token_id} rangedammo1 -1
!power {{
--charid|@{character_id}
--emote|@{selected|token_name} pulls back a @{rangedweaponname1} and fires at @{target|token_name}!
--format|COMBAT
--corners|10
--titlefont|Arial
--titlefontsize|9
--subtitlefont|Arial
--name|**Ranged Attack**
--leftsub|**@{rangedweaponname1}**
--rightsub|**Range 80/320**
--Target:|$$#ff0000|**@{target|token_name}**$$
--Ammo:|[[ [$Ammo] @{rangedammo1} - 1 ]] out of [[ @{rangedammo1|max} ]]
--Attack:|[[ [$Atk] @{AdvDisadv} + @{dexterity_mod} + @{prof_bonus} ]] vs AC
--?? $Atk.total < @{target|npc_AC} AND $Atk.base <> 1 AND $Atk.base <> 20 AND $Ammo >= 1 ?? Miss:|The attack missed!
--?? $Atk.base == 1 AND $Ammo >= 1 ?? Critical Miss:|The attack was fumbled!
--?? $Atk.total >= @{target|npc_AC} AND $Atk.base <> 1 AND $Atk.base <> 20 AND $Ammo >= 1 ?? Hit:|You hit for [[ @{rangeddmg1} + @{dexterity_mod} ]] @{rangeddmgtype1} damage!
--?? $Atk.base == 20 AND $Ammo >= 1 ?? Critical Hit:|You decimate the **@{target|token_name}** for [[ (@{rangeddmg1} + @{dexterity_mod}) * 2 ]] @{rangeddmgtype1} damage!
--?? $Ammo.total <= 1 ?? Out of Ammo: You cannot attack with your @{rangedweaponname1}.
}}

HoneyBadger said:

Actually you should already be able to use --whisper|self,gm. If not, that would be easy to fix.

!ammo @{selected|token_id} rangedammo1 -1
!power {{
--name|**Ranged Attack**
-- ?? $Ammo < 0 ?? Out of Ammo:| You cannot attack [...].
-- ?? $Ammo >= 0 ?? 1 ammo used:|[[ [$Ammo|TXT] @{selected|rangedammo1} - 1 + 0d0 ]] of [[ [TXT] @{selected|rangedammo1|max} + 0d0 ]] now remaining.
-- ?? $Ammo >= 0 ?? Attack:|[[ [$Atk] 1d20 ]] vs AC
-- ?? $Ammo >= 0 AND $Atk.base == 1 ?? Critical Miss:|The attack was fumbled!
-- ?? $Ammo >= 0 AND $Atk.base <> 1 AND $Atk.base <> 20 AND $Atk < @{target|npc_AC} ?? Miss:|The attack missed!
-- ?? $Ammo >= 0 AND $Atk.base <> 1 AND $Atk.base <> 20 AND $Atk >= @{target|npc_AC} ?? Hit:|You hit [...]!
-- ?? $Ammo >= 0 AND $Atk.base == 20 ?? Critical Hit:|You decimate [...]!
}}

			_.each(PowerCard.whisper.split(","), function(y) {
				var resip = ('self' === y.trim() ? msg.who : y.trim());
				sendChat(msg.who, "/w " + resip + " " + Display);
			});

Silvyre said:

HoneyBadger said:

Actually you should already be able to use --whisper|self,gm. If not, that would be easy to fix.

--whisper|self,foo,gm will output to foo and gm but not to self

• Version: 3.2.11
• Link: gist.github.com/Sky-Captain-13/452330a3d926b32da49c
• Bugfix: You can now use self as part of multiple target whispers.
  • Example: --whisper|self,gm
  • Courtesy of TheAaron
• Minor Bugfix: Added a blank line semi-colon at the start of the script to help reduce possible errors of a missing semi-colon in another script. Will not have any affect if you have no other scripts. Added after reading about it in one of TheAaron's other posts somewhere.
• Update / Bugfix: Conditionals now properly test for both text and numbers. However, you're only going to get text from a roll query or attribute call and not an inline roll. So for example, in my D&D 5e game, I set up an attribute (AttackRoll ) on my character sheet and put ?{Attack|Standard, 1d20|w/Advantage, 2d20kh1|w/Disadvantage, 2d20kl1} in that attribute. I can now reference it via @{AttackRoll}. If I select Standard, it returns 1d20 and Advantage returns 2d20kh1. These conditionals are case sensitive. Yes does not equal yes or yEs or YEs or any combination other than Yes.
  • Example: -- ?? @{AttackRoll} == 2d20kh1 ?? Advantage|I have advantage!
  • Example: -- ?? ?{Flanking?|Yes|No} == Yes ??Flanking:|I am flanking!
  • Courtesy of Nate W.

--Ammo:|[[ [$Ammo] @{rangedammo1} - 1 + 0d0 ]] of [[ @{rangedammo1|max} + 0d0 ]] remaining.
--?? $Ammo < 0 ?? Out of Ammo:|You cannot attack with your @{rangedweaponname1}.
--?? $Ammo > 0 ?? Attack:|[[ [$Atk] @{AdvDisadv} + @{dexterity_mod} + @{prof_bonus} ]] vs AC
--?? $Ammo > 0 AND $Atk.total < @{target|npc_AC} AND $Atk.base <> 1 AND $Atk.base <> 20 ?? Miss:|The attack missed!
--?? $Ammo > 0 AND $Atk.base == 1 ?? Critical Miss:|The attack was fumbled!
--?? $Ammo > 0 AND $Atk.total >= @{target|npc_AC} AND $Atk.base <> 1 AND $Atk.base <> 20 ?? Hit:|You hit for [[ @{rangeddmg1} + @{dexterity_mod} ]] @{rangeddmgtype1} damage!
--?? $Ammo > 0 AND $Atk.base == 20 ?? Critical Hit:|You decimate the **@{target|token_name}** for [[ (@{rangeddmg1} + @{dexterity_mod}) * 2 ]] @{rangeddmgtype1} damage!

!power {{
--charid|@{selected|character_id}
--emote|//@{selected|token_name} is attempting a Quick test...//
--orowbg|#F5DEB3
--erowbg|#FFFFF0
--name|Quick Test 
--leftsub|Attribute (roll under)

--hroll| Attribute [[ [$ATType] ?{Roll Type:|Quick, 0|Initiative, 1} +0d0 ]]

--?? $ATType == 0 ?? !Roll0:|**Quick:** [[ [nh|$ATQCK] 1d20]] vs [[@{selected|Quick} + ?{Roll Modifier|0}]]
--?? $ATType == 0 AND $ATQCK > @{selected|Quick} ?? ^Failure|
--?? $ATType == 0 AND $ATQCK <= @{selected|Quick} ?? ^Success|

--?? $ATType == 1 ?? !Roll1:|**Initiative:** [[ [nh|trkr] @{selected|Quick}d1]] ^^**Tiebreak:** [[1d20]]

}}

!power {{
--charid|@{selected|character_id}
--emote|//@{selected|token_name} is attempting a Quick test...//
--orowbg|#F5DEB3
--erowbg|#FFFFF0
--name|Quick Test 
--leftsub|Attribute (roll under)

?{Roll Type|
Quick,
--!Roll0:|**Quick:** [[ [nh|$ATQCK] 1d20]] vs [[@{selected|Quick} + ?{Roll Modifier|0}]]
-- ?? $ATQCK > @{selected|Quick} ?? ^Failure|
-- ?? $ATQCK <= @{selected|Quick} ?? ^Success&#124;
|
Initiative,
--!Roll1:&#124;**Initiative:** [[ [nh&#124;trkr] @{selected|Quick}d1]] ^^**Tiebreak:** [[1d20]]
}

}}

The Aaron said:

All rolls are evaluated on the client side. Powercards just adjusts which ones are displayed. I think there might be a work around you can use for initiative, but I don't remember it off the top of my head. 

Silvyre said:

Here's a workaround that involves nesting tags within a Roll Query:

!power {{
--charid|@{selected|character_id}
--emote|//@{selected|token_name} is attempting a Quick test...//
--orowbg|#F5DEB3
--erowbg|#FFFFF0
--name|Quick Test 
--leftsub|Attribute (roll under)

?{Roll Type|
Quick,
--!Roll0:|**Quick:** [[ [nh|$ATQCK] 1d20]] vs [[@{selected|Quick} + ?{Roll Modifier|0}]]
-- ?? $ATQCK > @{selected|Quick} ?? ^Failure|
-- ?? $ATQCK <= @{selected|Quick} ?? ^Success|
|
Initiative,
--!Roll1:|**Initiative:** [[ [nh|trkr] @{selected|Quick}d1]] ^^**Tiebreak:** [[1d20]]
}

}}

Silvyre said:

Just keep in mind that if you'd have to replace the commas in such a list with HTML entities.

HoneyBadger said:

Silvyre said:

Just keep in mind that if you'd have to replace the commas in such a list with HTML entities.

Not in this case I believe. It would be --whisper|?{Whisper to|} and he would type the names in.

HoneyBadger said:

Silvyre said:

Just keep in mind that if you'd have to replace the commas in such a list with HTML entities.

Not in this case I believe. It would be --whisper|?{Whisper to|} and he would type the names in.

TypeError: Cannot read property 'substring' of undefined

!power {{
--charid|@{character_id}
--emote|**@{selected|token_name}** is speaking in ?{What language are you speaking?}
--name|Languages


--whisper|?{Whisper to?} ?{Message..}
}}

Silvyre said:

The only thing that should be placed within whisper tag is a list of names separated by commas. You'll need to place your message Roll Query within another tag.

!power {{
--charid|@{character_id}
--emote|**@{selected|token_name}** is speaking in ?{What language are you speaking?}
--name|Languages


--whisper|?{Whisper to?} 


--!Message|?{Message..}
}}

Silvyre said:

Arthur, would you mind troubleshooting your issue by incrementally removing tags from your macro until your error ceases to pinpoint its source?

HoneyBadger said:

Do this as a macro for me please: @{character_id} and copy/paste the id here. I want to see what part of the character id is throwing it off.

TypeError: Cannot read property 'substring' of undefined

%{B-R8|04-Arcane-Armor})

The fruits of your assistance... (EDIT: Added in castings per day that change as used (with !ammo script))

!power {{
--orowbg|#F5DEB3
--erowbg|#FFFFF0
--name|**Spellbook**
--leftsub|**Power: 1** 

--whisper|self

--!Blank1|~~~
--!Rank0|~C**Rank 0 Spells**~C
--!Blank2|~~~
--!Spells0|[[ @{B-R8|ArcaneArmor} + 0d0 ]] [**Arcane Armor**](!
%{B-R8|04-Arcane-Armor}) ^^ [[ @{B-R8|MagicDart} + 0d0 ]] [**Magic Dart**](!
%{B-R8|07-Magic-Dart})  ^^ [[ @{B-R8|MagicLock} + 0d0 ]] [**Magic Lock**](!
%{B-R8|05-Magic-Lock}) ^^ [[ @{B-R8|SenseMagic} + 0d0 ]] [**Sense Magic**](!
%{B-R8|03-Sense-Magic}) ^^ [[ @{B-R8|SecureSite} + 0d0 ]] [**Secure Site**](!
%{B-R8|02-Secure-Site})

--!Blank3|~~~
--!Rank1|~C**Rank 1 Spells**~C
--!Blank4|~~~
--!Spells1|[[ @{B-R8|Evade} + 0d0 ]] [**Evade**](!
%{B-R8|06-Evade}) ^^ [[ @{B-R8|UnerringDarts} + 0d0 ]] [**Unerring Darts**](!
%{B-R8|08-Unerring-Darts})
}}

Arthur B. said:

HoneyBadger said:

Do this as a macro for me please: @{character_id} and copy/paste the id here. I want to see what part of the character id is throwing it off.

This is what I got when I did that:

TypeError: Cannot read property 'substring' of undefined

Silvyre said:

Arthur B. said:

HoneyBadger said:

Do this as a macro for me please: @{character_id} and copy/paste the id here. I want to see what part of the character id is throwing it off.

This is what I got when I did that:

TypeError: Cannot read property 'substring' of undefined

Could you copy, paste and enter @{selected|character_id} into the text chat after selecting the token that's linked to the Character that you're having difficulty with?

HoneyBadger said:

Wait... is this TypeError in chat with an orange background or in the api console?

Arthur B. said:

HoneyBadger said:

Wait... is this TypeError in chat with an orange background or in the api console?

In chat.

Craig L. said:

Do the buttons call off to another macro to fire off the spell?  Which part of the formula is doing that? 

Is it this part?  

%{B-R8|04-Arcane-Armor})

Craig L. said:

Hey Calhanol (or whomever else can answer),

I'd like to learn more about that awesome spellbook PowerCard you created.  Do the buttons call off to another macro to fire off the spell?  Which part of the formula is doing that? 

Is it this part?  

%{B-R8|04-Arcane-Armor})

I'd like to create one of these as well for 5e spells.  Sorry, I'm a little "wet behind the ears" with how the API works and interacts.  Thanks!

The fruits of your assistance... (EDIT: Added in castings per day that change as used (with !ammo script))

!power {{
--orowbg|#F5DEB3
--erowbg|#FFFFF0
--name|**Spellbook**
--leftsub|**Power: 1** 

--whisper|self

--!Blank1|~~~
--!Rank0|~C**Rank 0 Spells**~C
--!Blank2|~~~
--!Spells0|[[ @{B-R8|ArcaneArmor} + 0d0 ]] [**Arcane Armor**](!
%{B-R8|04-Arcane-Armor}) ^^ [[ @{B-R8|MagicDart} + 0d0 ]] [**Magic Dart**](!
%{B-R8|07-Magic-Dart})  ^^ [[ @{B-R8|MagicLock} + 0d0 ]] [**Magic Lock**](!
%{B-R8|05-Magic-Lock}) ^^ [[ @{B-R8|SenseMagic} + 0d0 ]] [**Sense Magic**](!
%{B-R8|03-Sense-Magic}) ^^ [[ @{B-R8|SecureSite} + 0d0 ]] [**Secure Site**](!
%{B-R8|02-Secure-Site})

--!Blank3|~~~
--!Rank1|~C**Rank 1 Spells**~C
--!Blank4|~~~
--!Spells1|[[ @{B-R8|Evade} + 0d0 ]] [**Evade**](!
%{B-R8|06-Evade}) ^^ [[ @{B-R8|UnerringDarts} + 0d0 ]] [**Unerring Darts**](!
%{B-R8|08-Unerring-Darts})
}}

--!Blank1|~~~
--!Rank0|~C**Rank 0 Spells**~C
--!Blank2|~~~
--!Spells0|[[ @{B-R8|ArcaneArmor} + 0d0 ]] [**Arcane Armor**](!
%{B-R8|04-Arcane-Armor}) ^^ [[ @{B-R8|MagicDart} + 0d0 ]] [**Magic Dart**](!
%{B-R8|07-Magic-Dart})  ^^ [[ @{B-R8|MagicLock} + 0d0 ]] [**Magic Lock**](!
%{B-R8|05-Magic-Lock}) ^^ [[ @{B-R8|SenseMagic} + 0d0 ]] [**Sense Magic**](!
%{B-R8|03-Sense-Magic}) ^^ [[ @{B-R8|SecureSite} + 0d0 ]] [**Secure Site**](!
%{B-R8|02-Secure-Site})

--!Blank1|~~~
--!Rank0|~C**Rank 0 Spells**~C
--!Blank2|~~~
--!Spells0|[[ @{B-R8|ArcaneArmor} + 0d0 ]] 

[**Arcane Armor**](!
%{B-R8|04-Arcane-Armor})

Arthur B. said:

EDIT: You beat me to it Silvyre, but did I do a good job explaining it? I was so happy I could actually answer one of these, thanks to all the help I got from the rest of you!

Silvyre said:

Arthur B. said:

EDIT: You beat me to it Silvyre, but did I do a good job explaining it? I was so happy I could actually answer one of these, thanks to all the help I got from the rest of you!

Yup. :)

• Version: 3.2.12
• Link: gist.github.com/Sky-Captain-13/452330a3d926b32da49c
• Bugfix: Content hidden by conditionals will not be processed. This really only affects the [trkr] roll option that sends a token to the turn order tracker.
  • Example: -- ?? ?{Send to Init|Yes|No} == Yes ?? Initiative:|[[ [trkr] 1d20 ]]
  • If you select no, the token will not be added to the turn order tracker, nor will its existing initiative be modified.
• Update: You can now display the base value of a Roll ID by adding [^Roll ID] to your PowerCard. This cannot be used as a stored variable to do math with however.
  • Example: --Damage:| [[ [$Physical] 1d8 + [$Fire] 1d6 + [$Necrotic] 2d6 ]] ([^Fire] fire, [^Necrotic] necrotic) would show up as Damage: [19] (4 fire, 9 necrotic)
  • If you want to include a modifier as part of the base value, you must wrap the roll and modifier in curly brackets like this: [[ [$Physical] {1d8 + 3 [Str Mod] } + [$Fire] {2d6 + 3} ]]
• Bugfix: As part of the above update, I was able to get Roll ID's to work with multiple dice and their base sum. Before the bugfix, $ID.base would only use the last number rolled, regardless of the number dice rolled.
  • Example: If you rolled [[ [$Fire] 3d6 + 10 ]] and rolled a 3, 3, 5... [^Fire] would only show the five and any conditionals trying to use $Fire.base would only test against the value of five instead of eleven, the sum of the dice only.
  • This would be most useful for system that use multiple dice for a roll that may or may not have modifiers applied, but also bases things like critical success off the base rolls. Like using 3d6 for attacks rolls in D&D instead of 1d20. You would be able to do the following, which did not work before.
    • -- Attack:| [[ [$Atk] 3d6 + 3 [Str Mod] ]] vs AC
    • -- ?? $Atk.base >= 18 ?? Critical Hit:|You got a critical hit!

...A bunch of stuff above this...

--Ammo:|[[ [$Ammo] (@{selected|rangedammo1} - 1) + 0d0 ]] of [[ @{selected|rangedammo1|max} + 0d0 ]] remaining.
--?? $Ammo <= 0 ?? Out of Ammo:|You cannot attack with your @{selected|rangedweaponname1}.
--?? $Ammo > 0 ?? Attack:|[[ [$Atk] @{AdvDisadv} + @{selected|dexterity_mod} + @{selected|prof_bonus} + 0d0 ]] vs AC

....A bunch of stuff below this....