Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×

Many ads are not valid links.

1477422340

Edited 1477423718
Thought you would like to know that the ads shown on top of the page in community don't actually go anywhere, except ones for supporter. They try to link to a non existing anchor. EDIT: Found the error in the html(Bolded): &lt;div style="display:inline; margin-right: 10px;"&gt; &lt;div style="display:inline;"&gt; &lt;a onclick="trackOutboundLink(' <a href="https://www.drivethrurpg.com/" rel="nofollow">https://www.drivethrurpg.com/</a>' ); return false;" href=" <a href="https://www.drivethrurpg.com/" rel="nofollow">https://www.drivethrurpg.com/</a> "&gt; &lt;img style="max-width:69px; max-height:100%; margin-left:auto; margin-right:auto; display:inline;" src="/images/drivethrurpg.png"&gt; &lt;/a&gt; &lt;/div&gt; &lt;div style="width:120px; max-height:100%; max-width:150px; margin-left:5px; display:inline-block; vertical-align:middle; overflow:hidden; -webkit-column-width: 200px; column-width: 200px; text-align:left; line-height:16px;"&gt; &lt;a style="font-size:16px;" onclick="trackOutboundLink(' <a href="https://www.drivethrurpg.com/" rel="nofollow">https://www.drivethrurpg.com/</a>' ); return false ;" href="#{ad[" link"]}"=""&gt; Looking for your next adventure? &lt;/a&gt; &lt;/div&gt; &lt;/div&gt; Also, you may&nbsp;need to change advert from display inline to inline-flex to render right. (Side note, safari would need -webkit-inline-flex) And, change advert to have a height of 100% to avoid the overflow problem. Tested in Microsoft Edge 38.14388.0.0 and Latest Chrome. No ad block used. EDIT: Drive Thru RPG does work if I click on the logo. otherwise it fails. Operating System Windows Windows NT 10.0 Screen Resolution 1920 x 1080 Web Browser Chrome 51.0.2704.79 (Incorrect since was using edge) Browser Size 1920 x 963 Color Depth 24 bit Javascript Enabled Flash Version 22.0.-1 Cookies Enabled
1477496791
Gid
Roll20 Team
Thank you for the report! I'll bring this up to the team.
1477500459
Stephen Koontz
Forum Champion
Marketplace Creator
Sheet Author
API Scripter
Compendium Curator
John, I'm not experiencing this on Windows or OSX, with Chrome, FF, or Safari. Are you sure it's not an extension, add-on, or anti-virus disrupting the normal CSS/JS of the site?
1477503978

Edited 1477504746
Steve K. said: John, I'm not experiencing this on Windows or OSX, with Chrome, FF, or Safari. Are you sure it's not an extension, add-on, or anti-virus disrupting the normal CSS/JS of the site? I have fully tested this by actually going to&nbsp;other computers, logging in and it is the same. On the same network, a virtual machine acts the same way, and another computer that is never used.&nbsp; I have also attempted using my cell phone as a hotspot to check if the router was causing it. On edge and chrome from a blank install,&nbsp;ads that have the drive thru rpg and the book, links go to an anchor and not to an actual site, with the source saying the link is just an anchor.&nbsp;Only the image of Drive Thru RPG links properly. I can try a&nbsp;full reinstall windows on a test machine if you like and connect it to a wifi location not on my network. Edit: I run without any extensions or add-ons, my anti-virus is just windows defender.&nbsp; And it does load one link correctly in the ad but the rest fail to go into the href section, instead showing as href="#{ad[" link"]}" Additional Edit: Another edit, console info, I refreshed untill I got to drive thru rpg image, and there is a different error for it. HTML1300: Navigation occurred. many-ads-are-not-valid-links HTML1423: Malformed start tag. Attributes should be separated by whitespace. many-ads-are-not-valid-links (78,23) HTML1409: Invalid attribute name character. Attribute names should not contain ("),('),(&lt;), or (=). many-ads-are-not-valid-links (78,27) HTML1409: Invalid attribute name character. Attribute names should not contain ("),('),(&lt;), or (=). many-ads-are-not-valid-links (78,30) HTML1423: Malformed start tag. Attributes should be separated by whitespace. many-ads-are-not-valid-links (89,24) HTML1409: Invalid attribute name character. Attribute names should not contain ("),('),(&lt;), or (=). many-ads-are-not-valid-links (89,28) SEC7111: HTTPS security is compromised by <a href="http://www.drivethrurpg.com/images/4790/196160-th" rel="nofollow">http://www.drivethrurpg.com/images/4790/196160-th</a>... many-ads-are-not-valid-links
1477682004
Stephen Koontz
Forum Champion
Marketplace Creator
Sheet Author
API Scripter
Compendium Curator
The only reason that would be happening is if JavaScript was being rejected by a 3rd party process, like an ad-block or an anti-virus. We pushed out an update today that even if the user doesn't have JavaScript enabled the links will still function as expected.
1477682770

Edited 1477684844
Steve K. said: The only reason that would be happening is if JavaScript was being rejected by a 3rd party process, like an ad-block or an anti-virus. We pushed out an update today that even if the user doesn't have JavaScript enabled the links will still function as expected. The odd thing is I don't use ad-block and windows defender is the only thing running, so I really wish I could figure out why it occurred across multiple computers and connection points.&nbsp; On either point your update fixes ads for me, now to just wait on the one I originally wanted to click. Thank you for resolving this issue for all of us free users! That world building book looked really fun.