Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×

Character Sheet Issue

1501468453

Edited 1501534072
Have the sheets been modified or edited  in the past 2 weeks?   Also, why is the modification being applied retroactively to existing sheets? Example: Rolled Inquiry, which pulls from my fellowship which is 42. This is what the roll was; rolling floor((((42 + 0/2) + 10)-1d100)/10)  floor((((42+0/2)+10)-(40))/10) = 1 It should have been  42/2
It would help if you specified which game system and sheet you are talking about.
Oh yeah, forgot that....  Warhammer, Deathwatch 
1501528417
Lithl
Pro
Sheet Author
API Scripter
Looks like the sheet got a commit 13 days ago to add the advanceX attributes to the skill rolls, without wrapping them in parentheses. For example <select class="charaselect" name="attr_InquiryCharacteristic"> <option value="@{Fellowship}">(Ag)</option> </select> Became <select class="charaselect" name="attr_InquiryCharacteristic"> <option value="@{Fellowship} + @{advanceFel}">(Fel)</option> </select> The roll button is then using "@{InquiryCharacteristic}/2", which is getting expanded to "@{Fellowship} + @{advanceFel}/2" Olav Müller is responsible for this specific change, although I don't know what their Roll20 account is, since they didn't add their account id to the sheet.json (but they did add their name to the authors field of sheet.json). Andy W. said: why is the modification is being applied retroactively to existing sheets? Because the character sheet system has no concept of versioning. If the campaign creator has a Pro subscription, you could use a "custom" sheet with content from the GitHub repo's history, to go back to a previous version of the sheet.
Thank you for the help.  I can see the difference although I am not the best at understanding the code...I know its happening for all the basic untrained rolls. Any idea/suggestions on how to search for Olav Müller ?
1501535253
Lithl
Pro
Sheet Author
API Scripter
I tried doing a Google search restricted to roll20.net for the name, but there were no results. Olav's forks of both the character sheets and api scripts repos don't have issues enabled, and GitHub doesn't have a direct messaging feature. The best option would probably be simply to create a pull request for the sheet yourself. Simply wrapping the values of the XCharacteristics attributes in parentheses should solve the problem, eg: <select class="charaselect" name="attr_InquiryCharacteristic">     <option value="(@{Fellowship} + @{advanceFel})">(Fel)</option> </select
Not to sound like a newb here, I have Github up and I'm attempting to create a pull request but I simply have no idea what I am doing to be honest. Even after reading the walkthrough on "How to pull a request" I find I can't get it to create it or I am not selecting the proper "branch."  any suggestions, or if you have the time, would you be able to create it for me.  (I hate asking that, bc I would rather not bug someone to do my work)
I created an Issue but seem to be having problems making the pull request
1501542007

Edited 1501542038
I will look into this after I complete a few other projects I already have on my plate..
Thank you
1501691396
chris b.
Pro
Sheet Author
API Scripter
I've found this video invaluable. it explains how GIT works so much better than anything else: <a href="https://www.youtube.com/watch?feature=player_detai" rel="nofollow">https://www.youtube.com/watch?feature=player_detai</a>... It's not GitHub technically, but knowing this makes GitHub a lot easier.&nbsp; coming from other source control solutions i had no idea what was going on, or why push , pull, merge were named the way they were and not the reverse