[Script] change token image from rolltable

!change-token-img --flip
!change-token-img --help

The Aaron said:

Brian calls it the Revealing Module Pattern, I just call it good sense. =D  (I highly recommend Javascript: The Good Parts by Douglas Crockford, if you haven't read it yet. =D )

var getCleanImgsrc = function (imgsrc) {
   var parts = imgsrc.match(/(.*\/images\/.*)(thumb|max)(.*)$/);
   if(parts) {
      return parts[1]+'thumb'+parts[3];
   }
   return;
};

SeanOG said:

Very nice. I do have to wonder though, why it doesn't work exactly as if someone had changed manually.

For example, I use a script I wrote for tokens to change size based upon their weight using a change: graphic event handler. The token doesn't resize, even after I move it to another square forcing the system to check. Granted, it's probably something in my own script (since I am like an amateur's janitor's best friend's dog walker in scripting), but it seems to lock that part of the rollable table out or something...

Brian said:

SeanOG said:

Very nice. I do have to wonder though, why it doesn't work exactly as if someone had changed manually.

For example, I use a script I wrote for tokens to change size based upon their weight using a change: graphic event handler. The token doesn't resize, even after I move it to another square forcing the system to check. Granted, it's probably something in my own script (since I am like an amateur's janitor's best friend's dog walker in scripting), but it seems to lock that part of the rollable table out or something...

Changes to Roll20 objects by the set() function do not trigger change events. I don't believe API actions trigger events when creating or deleting objects, either. sendChat() does trigger chat:message events, though.

David M. said:

Ok, I'm a massive noob, so that's probably the issue, but...

I put 2 images in a rollable table and added the script to my API scripts.

I added a token from the table, selected the token and tried !change-token-img --set 1.  This gives a result of: "1 is not a valid value for set parameter."

I tried !change-token-img --flip, but that crashes the API with the following error: /home/symbly/www/d20-api-server/node_modules/firebase/lib/firebase-node.js:1 orts, require, module, __filename, __dirname) { function g(a){throw a;}var j=v ^ TypeError: Cannot call method 'substring' of undefined at TrackedObj._validateAttrs (

I don't have a single doubt that I'm doing something simple wrong, but I have no idea what.

Help, please?

if (o && !o.fbpath) {
            o.fbpath = o.changed._fbpath.replace(/([^\/]*\/){4}/, "/");
        }
        return o;

Damian G. said:

Hello all.

I am a Java script noobie, but I found an issue.

I am currently only using the change-token-image script.

When I try using the --set option it did not matter what values I used: 0,1,2, a,b,c,etc.  Now a, b, c should have given errors about it being not a valid option, but 0, 1, and 2 should have.  With the same token, I could use the --flip and --incr without errors.  I finally figured out today that something in the code seems to be making valid inputs act as invalid ones for the --set option.  I was able to fix my issue by commenting out lines 121-124 of your script.
121 // if (! isInt(setval)) {
122 // showError(msg.playerid,setval,'','ARG');
123 // return;
124 // }
With commenting out the lines indicated above I can now use the --set command with out problems.  If I insert an inappropriate value like a, b, or c, it causes the API to bomb out and get disabled.  At this point I don't know how to get this to work with the proper error handling, but yal might know how to fix that part quickly since I have identified part of where the issue is coming from.

Thanks for the great work on this so far,
XiousDs

                            setval =  parseInt(cmds,10);

David M. said:

Well...I'm running A LOT of scripts.  TokenMod, CleanAbilities, Shaped Scripts, IsGM, GroupInit, a custom script for populating druid abilities and health bars, and one just to populate some command buttons in chat to simplify my DM's life.

but...None of them are called TrackedObj or even contain that string.

Regardless, I went through and disabled all of them except ChangeTokenImg, and it fails the same way.

I've replaced the images in the Rollable table with 2 fresh uploaded images from my PC. 

Unfortunately, I'm getting the same error. 

Any other thoughts?

Sorry to be difficult. I'm just stumped.

    setImg = function (o,nextSide,allSides) {
        var nextURL = getCleanImgsrc(decodeURIComponent(allSides[nextSide]));
	if(nextURL){
            o.set({
                currentSide: nextSide,
                imgsrc: nextURL
            });
        }
        return nextURL;
    },
	setImgUrl = function (o, nextSide, nextURL) {
            var next=getCleanImgsrc(nextURL);
            if(next){
		o.set({
			currentSide: nextSide,
			imgsrc: next
		});
            }		
	},

The Aaron said:

David M. said:

Well...I'm running A LOT of scripts.  TokenMod, CleanAbilities, Shaped Scripts, IsGM, GroupInit, a custom script for populating druid abilities and health bars, and one just to populate some command buttons in chat to simplify my DM's life.

but...None of them are called TrackedObj or even contain that string.

Regardless, I went through and disabled all of them except ChangeTokenImg, and it fails the same way.

I've replaced the images in the Rollable table with 2 fresh uploaded images from my PC. 

Unfortunately, I'm getting the same error. 

Any other thoughts?

Sorry to be difficult. I'm just stumped.

Try changing the following:

    setImg = function (o,nextSide,allSides) {
        var nextURL = getCleanImgsrc(decodeURIComponent(allSides[nextSide]));
	if(nextURL){
            o.set({
                currentSide: nextSide,
                imgsrc: nextURL
            });
        }
        return nextURL;
    },
	setImgUrl = function (o, nextSide, nextURL) {
            var next=getCleanImgsrc(nextURL);
            if(next){
		o.set({
			currentSide: nextSide,
			imgsrc: next
		});
            }		
	},

and see if you still get the crash.

Coal Powered Puppet said:

Is this code gonna be posted up on github? 

The Aaron said:

David M. said:

Well...I'm running A LOT of scripts.  TokenMod, CleanAbilities, Shaped Scripts, IsGM, GroupInit, a custom script for populating druid abilities and health bars, and one just to populate some command buttons in chat to simplify my DM's life.

but...None of them are called TrackedObj or even contain that string.

Regardless, I went through and disabled all of them except ChangeTokenImg, and it fails the same way.

I've replaced the images in the Rollable table with 2 fresh uploaded images from my PC. 

Unfortunately, I'm getting the same error. 

Any other thoughts?

Sorry to be difficult. I'm just stumped.

Try changing the following:

    setImg = function (o,nextSide,allSides) {
        var nextURL = getCleanImgsrc(decodeURIComponent(allSides[nextSide]));
	if(nextURL){
            o.set({
                currentSide: nextSide,
                imgsrc: nextURL
            });
        }
        return nextURL;
    },
	setImgUrl = function (o, nextSide, nextURL) {
            var next=getCleanImgsrc(nextURL);
            if(next){
		o.set({
			currentSide: nextSide,
			imgsrc: next
		});
            }		
	},

and see if you still get the crash.

/images/14935838/uuC96TlJLyFXxLtdgrydeA/thumb.png?14518449565

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/thumb.png?14518449695

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/med.png?14518449695

var parts = imgsrc.match(/(.*\/images\/.*)(thumb|med|max)(.*)$/);

SeanOG said:

And I found what the problem is...

I checked out the Javascript Console and I see that what is being swapped when using this script is from this:

/images/14935838/uuC96TlJLyFXxLtdgrydeA/thumb.png?14518449565

to this:

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/thumb.png?14518449695

Okay... no problem, except that when you upload directly to the rollable table, it saves as this:

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/med.png?14518449695

To fix the problem with the script (where my error was concerned), I changed line 68 to:

var parts = imgsrc.match(/(.*\/images\/.*)(thumb|med|max)(.*)$/);

Now that I know where this problem was, I can now look into making this work with my AutoResize script that bases its resize on the image in the rollable table -- which is med.png...

David M. said:

SeanOG said:

And I found what the problem is...

I checked out the Javascript Console and I see that what is being swapped when using this script is from this:

/images/14935838/uuC96TlJLyFXxLtdgrydeA/thumb.png?14518449565

to this:

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/thumb.png?14518449695

Okay... no problem, except that when you upload directly to the rollable table, it saves as this:

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/med.png?14518449695

To fix the problem with the script (where my error was concerned), I changed line 68 to:

var parts = imgsrc.match(/(.*\/images\/.*)(thumb|med|max)(.*)$/);

Now that I know where this problem was, I can now look into making this work with my AutoResize script that bases its resize on the image in the rollable table -- which is med.png...

Awesome!  Thanks for following up on that!

/home/symbly/www/d20-api-server/node_modules/firebase/lib/firebase-node.js:1
orts, require, module, __filename, __dirname) { function g(a){throw a;}var j=v
                                                                    ^
TypeError: Cannot call method 'substring' of undefined
    at TrackedObj._validateAttrs (

SeanOG said:

David M. said:

SeanOG said:

And I found what the problem is...

I checked out the Javascript Console and I see that what is being swapped when using this script is from this:

/images/14935838/uuC96TlJLyFXxLtdgrydeA/thumb.png?14518449565

to this:

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/thumb.png?14518449695

Okay... no problem, except that when you upload directly to the rollable table, it saves as this:

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/med.png?14518449695

To fix the problem with the script (where my error was concerned), I changed line 68 to:

var parts = imgsrc.match(/(.*\/images\/.*)(thumb|med|max)(.*)$/);

Now that I know where this problem was, I can now look into making this work with my AutoResize script that bases its resize on the image in the rollable table -- which is med.png...

Awesome!  Thanks for following up on that!

No worries. I have been wanting to use this script for awhile because my players all use a rollable table token, with mounted and dismounted token values. With my own script that automatically resizes based upon the weight value of the side (1 for 1x1, 2 for 2x2), I wanted to make it easier for them than right-clicking and choosing a side. Right now, it's a double call macro (one for this script, one to manually resize), but I'll eventually get it down to one.

Coal Powered Puppet said:

For the PC tokens the script seems to work just fine.  FOr the NPC token, I keep getting this error:

/home/symbly/www/d20-api-server/node_modules/firebase/lib/firebase-node.js:1
orts, require, module, __filename, __dirname) { function g(a){throw a;}var j=v
                                                                    ^
TypeError: Cannot call method 'substring' of undefined
    at TrackedObj._validateAttrs (

• Everything has a character journal linked to it.
• The token are created by hitting the token button on the tallable table, made not to be a drawing, and assigned to a character journal.  The token on the character journal was deleted and this rollable table token was made the default.
• And I don't make changes to the rollable table (after the above embarrassment); I make whole new tables, remake the token, and assign it to a character sheet.

David M. said:

SeanOG said:

David M. said:

SeanOG said:

And I found what the problem is...

I checked out the Javascript Console and I see that what is being swapped when using this script is from this:

/images/14935838/uuC96TlJLyFXxLtdgrydeA/thumb.png?14518449565

to this:

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/thumb.png?14518449695

Okay... no problem, except that when you upload directly to the rollable table, it saves as this:

/images/14935850/RLTRIkfIWWc1AuUN9MUzqQ/med.png?14518449695

To fix the problem with the script (where my error was concerned), I changed line 68 to:

var parts = imgsrc.match(/(.*\/images\/.*)(thumb|med|max)(.*)$/);

Now that I know where this problem was, I can now look into making this work with my AutoResize script that bases its resize on the image in the rollable table -- which is med.png...

Awesome!  Thanks for following up on that!

No worries. I have been wanting to use this script for awhile because my players all use a rollable table token, with mounted and dismounted token values. With my own script that automatically resizes based upon the weight value of the side (1 for 1x1, 2 for 2x2), I wanted to make it easier for them than right-clicking and choosing a side. Right now, it's a double call macro (one for this script, one to manually resize), but I'll eventually get it down to one.

I'm actually in a similar position with Wildshapes, where I'm using 2 macros, 1 to do stat changes and actions and one for the images because I haven't really figured out how to call this script from my other one.  So I set up a menu in chat to give them buttons, because I'm too lazy to get around to pulling the pieces apart.

Coal Powered Puppet said:

The above error was- much to my embarrassment- likely caused by using a rollable table with a image hard dropped in the table instead of using the libary.  I have since taken to deleting old tables and making whole new ones.

I am still getting the error "2 is not a valid value for set parameter" (or any other number).  I can use --flip and --incr, but not --set.

• Everything has a character journal linked to it.
• The token are created by hitting the token button on the tallable table, made not to be a drawing, and assigned to a character journal.  The token on the character journal was deleted and this rollable table token was made the default.
• And I don't make changes to the rollable table (after the above embarrassment); I make whole new tables, remake the token, and assign it to a character sheet.

                            setval =  parseInt(cmds,10);