Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×

Macro not working. Any ideas?

Hey all, so I'm (re)creation a macro that I found online but it doesn't seem to work unless I change some of the symbols for&nbsp; HTML entities. It has worked for the first part of what i'm trying to do, but the /roll line at the end doesn't seem to work.&nbsp; The macro is for calculating the damage rolled for multiple creatures for my druid.&nbsp; /me rolls for the damage of ?{Number of Hits} hits with&nbsp; ?{Animal Attack|Elk Ram, Elk Ram (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)| Elk Hooves, Elk Hooves (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;4&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)| Elk Charge,Elk Charge (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;0&amp;#125;)| Wolf Bite,Wolf Bite(?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;4&amp;#125;+?{Bonus Damage &amp;#124;2&amp;#125;)| Giant Goat Ram,Giant Goat Ram (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;4&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)| Giant Goat Charge,Giant Goat Charge (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;4&amp;#125;+?{Bonus Damage &amp;#124;0&amp;#125;)| Warhorse,Warhorse (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)| Brown Bear Bite,Brown Bear Bite (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;8&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)| Brown Bear Claws,Brown Bear Claws (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)| Crag Cat Bite,Crag Cat Bite (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;10&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)| Crag Cat Claw,Crag Cat Claw (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;8&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)| Dire Wolf Bite,Dire Wolf Bite (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)| Giant Eagle Beak,Giant Eagle Beak (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125; )| Giant Eagle Talons,Giant Eagle Talons (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)| Cave Bear Bite,Cave Bear Bite (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;8&amp;#125;+?{Bonus Damage &amp;#124;5&amp;#125;)| Cave Bear Claws,Cave Bear Claws (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;5&amp;#125;)| Giant Elk Ram,Giant Elk Ram (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)| Giant Elk Hooves,Giant Elk Hooves (?{Number of Dice &amp;#124;4&amp;#125;d?{Type of Die &amp;#124;8&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)| Giant Elk Charge,Giant Elk Charge (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;0&amp;#125;} /r [[?{Number of Hits&amp;#125;*?{Number of Dice&amp;#125;]]d?{Type of Die&amp;#125;+[[?{Number of Hits&amp;#125;*?{Bonus Damage&amp;#125;]] This last line (/r ... ) is the problem.&nbsp; A summary of what it does: Enter your number of hits Select the attack. Click Submit a few times Have a roll show damage. Without the last line, it gives an output of&nbsp; &nbsp; Elk Ram (1d6+3) Any ideas? The original is here:&nbsp; <a href="https://app.roll20.net/forum/post/6466411/d-and-d-5e-conjure-animals-macro" rel="nofollow">https://app.roll20.net/forum/post/6466411/d-and-d-5e-conjure-animals-macro</a>
1564518374

Edited 1564518443
keithcurtis
Forum Champion
Marketplace Creator
API Scripter
Just at a quick glance, get rid of the "/r". The roll is already an inline roll. Make sure there is no return before that final roll, so that it is on the same line and can pick up the query results. Edit: a shift-return might work. I haven't tested.
1564520061
Ziechael
Forum Champion
Sheet Author
API Scripter
The Giant Elk Charge is also missing a closing )
1564522728

Edited 1564523031
Thank you guys for your replies. I made the changes you suggested as far as I understand. What do you mean a shift-return, Keith?&nbsp; How would I see if there is a return before the final roll? The macro now looks like this.. /me rolls for the damage of ?{Number of Hits} hits with ?{Animal Attack|Elk Ram, Elk Ram (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)|Elk Hooves, Elk Hooves (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;4&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)|Elk Charge,Elk Charge (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;0&amp;#125;)|Wolf Bite,Wolf Bite(?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;4&amp;#125;+?{Bonus Damage &amp;#124;2&amp;#125;)|Giant Goat Ram,Giant Goat Ram (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;4&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)|Giant Goat Charge,Giant Goat Charge (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;4&amp;#125;+?{Bonus Damage &amp;#124;0&amp;#125;)|Warhorse,Warhorse (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)|Brown Bear Bite,Brown Bear Bite (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;8&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)|Brown Bear Claws,Brown Bear Claws (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)|Crag Cat Bite,Crag Cat Bite (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;10&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)|Crag Cat Claw,Crag Cat Claw (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;8&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)|Dire Wolf Bite,Dire Wolf Bite (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)|Giant Eagle Beak,Giant Eagle Beak (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125; )|Giant Eagle Talons,Giant Eagle Talons (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;3&amp;#125;)|Cave Bear Bite,Cave Bear Bite (?{Number of Dice &amp;#124;1&amp;#125;d?{Type of Die &amp;#124;8&amp;#125;+?{Bonus Damage &amp;#124;5&amp;#125;)|Cave Bear Claws,Cave Bear Claws (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;5&amp;#125;)|Giant Elk Ram,Giant Elk Ram (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)|Giant Elk Hooves,Giant Elk Hooves (?{Number of Dice &amp;#124;4&amp;#125;d?{Type of Die &amp;#124;8&amp;#125;+?{Bonus Damage &amp;#124;4&amp;#125;)|Giant Elk Charge,Giant Elk Charge (?{Number of Dice &amp;#124;2&amp;#125;d?{Type of Die &amp;#124;6&amp;#125;+?{Bonus Damage &amp;#124;0&amp;#125;)}[[?{Number of Hits&amp;#125;*?{Number of Dice&amp;#125;]]d?{Type of Die&amp;#125;+[[?{Number of Hits&amp;#125;*?{Bonus Damage&amp;#125;]] It doesn't seem to output anything before the roll or after. (Only if I remove the last line from [[?{Number of Hits... ) My other macro works..., if it's helpful to see below: /me commands his conjured animals to attack using ?{Animal Attack| &nbsp; &nbsp;Elk Ram, Elk Ram (+?{To Hit &amp;#124;4 &amp;#125; to hit) | &nbsp; &nbsp;Elk Hooves, Elk Hooves (+?{To Hit &amp;#124;5 &amp;#125; to hit) | &nbsp; &nbsp;Wolf Bite, Elk Hooves (+?{To Hit &amp;#124;5 &amp;#125; to hit) | &nbsp; &nbsp;Giant Goat Ram, Giant Goat Ram (+?{To Hit &amp;#124;5 &amp;#125; to hit) | &nbsp; &nbsp;Warhorse Hooves, Warhorse Hooves (+?{To Hit &amp;#124;6 &amp;#125; to hit) | &nbsp; &nbsp;Brown Bear Bite, Brown Bear Bite (+?{To Hit &amp;#124;5&amp;#125; to hit) |&nbsp;&nbsp; &nbsp; &nbsp;Brown Bear Claws, Brown Bear Claws (+?{To Hit &amp;#124;5 &amp;#125; to hit) |&nbsp;&nbsp; &nbsp; &nbsp;Crag Cat Bite, Crag Cat Bite (+?{To Hit &amp;#124;5 &amp;#125; to hit) |&nbsp;&nbsp; &nbsp; &nbsp;Crag Cat Claw, Crag Cat Claw (+?{To Hit &amp;#124;5 &amp;#125; to hit) |&nbsp;&nbsp; &nbsp; &nbsp;Dire Wolf Bite, Dire Wolf Bite (+?{To Hit &amp;#124;5 &amp;#125; to hit) | &nbsp; &nbsp;Giant Eagle Beak, Giant Eagle Beak (+?{To Hit &amp;#124;5 &amp;#125; to hit) | &nbsp; &nbsp;Giant Eagle Talons, Giant Eagle Talons (+?{To Hit &amp;#124;5 &amp;#125; to hit) | &nbsp; &nbsp;Cave Bear Bite, Cave Bear Bite (+?{To Hit &amp;#124;7 &amp;#125; to hit) | &nbsp; &nbsp;Cave Bear Claws, Cave Bear Claws (+?{To Hit &amp;#124;7 &amp;#125; to hit) | &nbsp; &nbsp;Giant Elk Ram, Giant Elk Ram (+?{To Hit &amp;#124;6 &amp;#125; to hit) | &nbsp; &nbsp;Giant Elk Hooves, Giant Elk Hooves (+?{To Hit &amp;#124;6 &amp;#125; to hit) | &nbsp; &nbsp;Custom Animal, Custom Animal (+?{To Hit &amp;#124;4 &amp;#125 to hit); }: !?{Roll Type| &nbsp; &nbsp;Standard, ?{Die&amp;#124;1d20&amp;#125; ?{Info&amp;#124;Standard Roll&amp;#125;| &nbsp; &nbsp;Advantage,?{Die&amp;#124;2d20kh1&amp;#125;?{Info&amp;#124;Rolling with Advantage&amp;#125;| &nbsp; &nbsp;Disadvantage,?{Die&amp;#124;2d20kl1&amp;#125;?{Info&amp;#124;Rolling with Disadvantage&amp;#125;} ?{Info} ?{Number of Attackers| &nbsp; &nbsp;1, [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]] | &nbsp; &nbsp;2, [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]] | &nbsp; &nbsp;3, [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]] | &nbsp; &nbsp;4, [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]] | &nbsp; &nbsp;5, [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]] | &nbsp; &nbsp;6, [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]] | &nbsp; &nbsp;7, [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]] | &nbsp; &nbsp;8, [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]]&amp;#44; [[(?{Die &amp;#125;+?{To Hit &amp;#125;)]] | &nbsp; &nbsp; &nbsp; }:
Too much html. I’d use nested macros for this one. Break it down into smaller pieces.