[Attribute 3.5] can't modify the spell used without somme random error

Part of the issue is that findObjs will always return an array, even if it is an empty array... meaning this test will never come back positive:     if (attributeName === undefined){         debug("No attribute name for : " + spellName);         return undefined;     } If you want to test if the array is empty, you'll have to test the length property...     if (!attributeName.length){         debug("No attribute name for : " + spellName);         return undefined;     } Another thing to think about is that not every entry in a repeating section has every sub-attribute. I would suggest my XRay script to walk the character sheet and inspect the repeating section in chat. Maybe you will see a difference between one spell to the next. Also... one last thing to think about is that I sometimes see this sort of strange behavior if I am using a regular expression and not resetting its lastIndex property between uses... eventually it just walks itself to the end of whatever string it is looking at and it returns no match even though it should. I don't see one in your code, but I would log the spellName argument you are getting at the start of the function and see if it is what you would expect it to be.

1598904371

Pro

Thanks timmaugh ! With your correction about the testing it's ok. I forgot findobjs return an array (can be empty but still an array). I still don't understand why the log were different but it's working so it can wait some knowledge improvement ;) I keep in mind your XRay script for which I would have kill to have it someday ago ^^

1598923072

Pro

Sheet Author

API Scripter

Another thing - when working in the API (or sheet workers) it's better to work with the real row ids, not the $0, $1 form of the id. You can use findObs to get all the attributes in a repeating section on a character, and then extract the unique row ids from that. Then you can use them to eitehr cycle through the section, or access specific attributes.

1598967083

Pro

Hi Gigs i'm using the id in the name like  repeating_spells02_-M3MyGE2I5srAFB9Tjxz_spellused02  because I don't know how I can get all the line through findObjs. Are you telling me it's possible to filter on a partial name like  repeating_spells02%spellused02  ?

1598969065

Pro

Sheet Author

API Scripter

Yes, you can filter on partial attribute names. You can do a filterObjs to get the filtered list directly (though the wiki discourages this due to performance), or findObjs to get all attributes in the repeating section, then filter that to the subset you actually want using the partial names. I hadnt looked closely at your code-  now I see what it's doing, and yes, you can replace that for loop and get the attributes more efficiently. There's more than one way to do it, but here's one example: function getSpellAttributes(character, spellLevel, spellClass, whichStat) { // assuming whichStat = 'spellused'     const section = findObjs({         type: 'attribute',         characterid: character.get("id")     }) // this returns an array of ALL attributes from this character. Then we filter to the ones we want.     .filter(att => att.name.startsWith(`repeating_spells${spellLevel}${spellClass}_`) && att.name.endsWith(`_${whichStat}${spellLevel}${spellClass}`));     return section; } Assuming you call this function with whichStat = 'spellused', it will return an array of all 'spellused' attributes from the desired section. (Assuming I'm not messing up the code due to being half asleep, haha.)

1598969684

Edited 1598969832

Pro

Sheet Author

API Scripter

Also, Jakob posted a function a couple of years ago you can use to get all the IDs of a repeating section, in the order the rows are listed on the sheet, here: <a href="https://app.roll20.net/forum/permalink/5782857/" rel="nofollow">https://app.roll20.net/forum/permalink/5782857/</a> You could then loop through the ids and build any attribute name you wanted for the section.

1598986373

Pro

Thanks ! Yes I avoided the filter function due to the warning on the API page. This way will solve the warning message "ERROR: You tried to use the repeating section row at index 5 for repeating_spells22, but there doesn't seem to be a row at that index." in the log. I will rework this functionnality of my scripts with your code.

1598989092

Pro

Thanks again your code is exactly what I need (just a little error to getting the name) ! In case of anyone reading this post in the future : function getSpellAttributes(character, spellLevel, spellClass, whichStat) { // assuming whichStat = 'spellused'     const section = findObjs({         type: 'attribute',         characterid: character.get("id")     }) // this returns an array of ALL attributes from this character. Then we filter to the ones we want.     .filter(att => att.get("name").startsWith(`repeating_spells${spellLevel}${spellClass}_`) && att.get("name").endsWith(`_${whichStat}${spellLevel}${spellClass}`));     return section; } Hope you will have a restful night

1599004704

Pro

Sheet Author

API Scripter