Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Apocalypse World 1st ed Revision - WIP

So, I'm trying to add the supplementary classes for the Apocalypse World sheet. I was doing good until, well, I happened to it. Now the sheet it not working properly and I have it on good authority that I am missing a style="display: none;" somewhere. I've looked it over several times and I can not figure out what I did wrong. Any feedback would be appreciated. :) <a href="https://gist.github.com/Project462/ece28238c8ce45f" rel="nofollow">https://gist.github.com/Project462/ece28238c8ce45f</a>... &lt;html <a href="https://gist.github.com/Project462/60836f4a4752823" rel="nofollow">https://gist.github.com/Project462/60836f4a4752823</a>... &lt;CSS
1463459765
vÍnce
Pro
Sheet Author
Try adding this to your css .sheet-isAngel:not(:checked) ~ .sheet-angel, .sheet-isBattlebabe:not(:checked) ~ .sheet-battlebabe, .sheet-isHardholder:not(:checked) ~ .sheet-holder, .sheet-isChopper:not(:checked) ~ .sheet-chopper, .sheet-isDriver:not(:checked) ~ .sheet-driver, .sheet-isGunlugger:not(:checked) ~ .sheet-gunlugger, .sheet-isHocus:not(:checked) ~ .sheet-hocus, .sheet-isOperator:not(:checked) ~ .sheet-operator, .sheet-isSavvyhead:not(:checked) ~ .sheet-savvy, .sheet-isSkinner:not(:checked) ~ .sheet-skinner, .sheet-isBrainer:not(:checked) ~ .sheet-brainer, .sheet-isFaceless:not(:checked) ~ .sheet-faceless, .sheet-isHoarder:not(:checked) ~ .sheet-hoarder, .sheet-isMacaluso:not(:checked) ~ .sheet-macaluso, .sheet-isMaestro-D:not(:checked) ~ .sheet-maestro-d, .sheet-isMarmot:not(:checked) ~ .sheet-marmot, .sheet-isQuarantine:not(:checked) ~ .sheet-quarantine, .sheet-isSolace:not(:checked) ~ .sheet-solace, .sheet-isS-M-M:not(:checked) ~ .sheet-S-M-M, .sheet-isTouchstone:not(:checked) ~ .sheet-touchstone { display: none; }
Tried adding it into its own area, now the sheet will not display the improvements even when checked. :/
1463463104

Edited 1463463206
[Deleted]
Sheet Author
Ermagerd... I'm an idiot.. It works now, I was just implementing it wrong @.@ second day working on code without sleep I guess. EDIT: Thank you thank you thank you!
1463463291
vÍnce
Pro
Sheet Author
Strange, it works for me. &nbsp;I added the block of css above directly below the css section that uses display:block;
1463463319
vÍnce
Pro
Sheet Author
LOL. &nbsp;NP. &nbsp;glad that works for you now. &nbsp;;-P
1463495692

Edited 1463505829
[Deleted]
Sheet Author
Guess I'll just ask here instead of opening a new thread. How does one go about submitting their revision to replace the current available sheet? I haven't put my name anywhere in the sheet, I didn't create it, just modified it. But yeah, how does one go about making the sheet available to people who do not have Pro access? EDIT: I looked at the instructions on github, but I don't understand exactly what it is I need to do :/
1463533756

Edited 1463538547
vÍnce
Pro
Sheet Author
I'll explain what I do (there are probably other(better) ways to go about this) to update a sheet on roll20. Make sure you have created an account on github and&nbsp; fork the&nbsp; roll20 repository (this will make a copy of the repository that is added to your account) I use Github's Desktop (for windows) interface:&nbsp; <a href="https://desktop.github.com/" rel="nofollow">https://desktop.github.com/</a> install and run use Github Desktop to clone roll20's forked repository associated with your online account. &nbsp;(this will create a local copy) You now have access to the repo locally. Only make changes to the appropriate files you want to update. I often make a copy of the folder for the sheet I want to work on. &nbsp;After I'm done editing, I copy over the local copy and run Github Desktop. &nbsp;It will detect the change and you will get prompted to submit a pull request. &nbsp;Fill in the info required (the name of the update and a few notes) Submit when complete. Go online to your account. &nbsp;Open your forked roll20 repo and accept the pull request.(green button) &nbsp;This will submit your request to the roll20's repo and you will get a pull request #. &nbsp;You have to wait for roll20 to process any PR's. &nbsp;Usually once per week give or take days. &nbsp;If the repo manager (currently Phil, Steve, or Riley) approves, it will be submitted to roll20's Main/Live servers. &nbsp;Wait another day or so for the update to get picked up by the servers. Easy as that. &nbsp;;-P &nbsp;Github is a pain btw.&nbsp;
On that last note.. yes... yes it is.. But, thank you again. I have submitted the sheet for review. The only thing I'm not sure on is the .json, I'm not sure I updated it, but, I wasn't sure if I was supposed to or not since it's not my sheet.
1463538439

Edited 1463538633
vÍnce
Pro
Sheet Author
Seth said: On that last note.. yes... yes it is.. But, thank you again. I have submitted the sheet for review. The only thing I'm not sure on is the .json, I'm not sure I updated it, but, I wasn't sure if I was supposed to or not since it's not my sheet. It's probably personal preference. &nbsp;If I make big changes and/or the original sheet creator is no longer active, I don't feel bad sticking my name on the sheet .json(I believe that's how you get the cool "Sheet Author" tag). &nbsp;While not "required", proper etiquette is to ask previous/current sheet authors if they don't mind your contributions. &nbsp; I assume this is your PR? <a href="https://github.com/Roll20/roll20-character-sheets/pull/1634" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/pull/1634</a> Welcome to the club. &nbsp;;-P
:D It is, and thank you again. I didn't feel it was appropriate of me to add my name for adding a few lines and asking for other people's help.
1463541765
vÍnce
Pro
Sheet Author
Just keep improving the sheet and earn it. &nbsp;Cheers