Roll20 uses cookies to improve your experience on our site. Cookies enable you to enjoy certain features, social sharing functionality, and tailor message and display ads to your interests on our site and others. They also help us understand how our site is being used. By continuing to use our site, you consent to our use of cookies. Update your cookie preferences .
×
Create a free account

Ambiguous README.md

1585652785

Edited 1585653839
admiralnlson
Sheet Author
<a href="https://github.com/Roll20/roll20-character-sheets/blob/master/README.md" rel="nofollow">https://github.com/Roll20/roll20-character-sheets/blob/master/README.md</a> &nbsp;says "After we have reviewed your sheet if we approve it we will add it to the&nbsp; approved.yaml &nbsp;file in the root directory which will cause it to be available to everyone on the main Roll20 site." But it seems the addition of the sheet to the&nbsp; approved.yaml &nbsp;file on the master branch &nbsp;is not enough to " cause it to be available to everyone on the main Roll20 site. ". Generally speaking, for any updates to the content of the repo (not just on the approved.yaml file by the Roll20 team),&nbsp; I imagine that &nbsp;a manual (or if partially automated, at least manually-confirmed) mechanism&nbsp; is required&nbsp; to push the latest content from the master branch onto the Roll20 website. I propose that someone who has the permissions to change the README.md file, but more importantly knows more about the actual end-to-end process, updates the initial section of the README file to clarify that a pull request being accepted does not immediately equate to an update of the Roll20 website.
1585657820
Andreas J.
Forum Champion
Sheet Author
Translator
admiralnlson said: Generally speaking, for any updates to the content of the repo (not just on the approved.yaml file by the Roll20 team),&nbsp; I imagine that &nbsp;a manual (or if partially automated, at least manually-confirmed) mechanism&nbsp; is required&nbsp; to push the latest content from the master branch onto the Roll20 website. Yes, that is indeed how it works. After the weekly Monday deadline, Roll20 reviews and sometimes merges code during Monday/Tuesday, before finally on Tuesday rolling out the character sheet changes to the live site, together with their changes to the site. Yes, that could indeed be clarified, that the PRs are reviewed during Mondays, and usually implemented live during Tuesdays.