Spriteanon said: Hey! First of all, wanted to say, thanks a lot for keeping this sheet updated. Second, I thought I'd list a few minor glitches and other issues I noticed. 1) Various typos and other visual issues: This includes wrong rule references. One I found is: In ACC's tooltip from Combat/Ranged refers to Aim as B354, but it's B3 6 4. I then went through the gurps.html on the git to check and also noticed the following: The Team Effort section in Tools/General seems oddly sourced. It claims to reference B185 in multiple tooltips, but B185 is the middle of the Skills section, and while Crewman is on that page along with a similar concept for certain vehicle checks being made at average, that doesn't reflect this tool. I tried finding the corresponding rules in the Basic Set with no success, so unless I'm missing something, I'm pretty sure this is from a different sourcebook, although I don't know what that would be. Even if it's homebrew, I think it's a neat feature, and some players might rely on it so it should stay, but the tooltips should probably be fixed. This is all I found in terms of bad references, but then again, I only looked by Ctrl+F-ing the html file for B1, B2, etc while also skimming things a bit on account of the hundreds of references. I also didn't look for references to other books than the Basic Set, so if someone wants to verify the rest of the references, it's up to you. Macro tooltip typos: Only three I found was @{NAME|hit_points|max} where I'm fairly sure the second '|' should be a '_', as Roll20 uses '|' to separate characters and attributes/abilities in a Macro call. Indeed, it gives errors trying to find characters by the name of "[Actual Character Name]|hit_points" if the max HP is referenced this way. The other two are the same typo present for User Pool 1 and 2. (The custom pools.) And finally one other typo that might be best left as is, if only to make sure it doesn't mess up people's sheets: the simpler Hit Location table in Combat/Defense has pretty consistent naming for the 3 collumns, where each row has the same names just with the location name swapped out, except for "Groin" which in the DR collumn is mispelled 'groind'. That is not the tooltip, but the actual attribute name (the tooltip has the same typo, but it's not really a typo since it accurately names the attribute as 'groind'. This is inconsequential since like I said the tooltip is accurate, but I thought I'd list it because it might have something to do with the first example in the next point, depending on how things are coded. 2) Certain fields return their default value rather than their current value. This includes all of the right most collumn of the simpler version of the Hit Location tracker in Defense (the names and hit penalties collumn can be read, but not the DR collumn, which possibly coincidentally has the 'groind' typo in one of the fields), as well as the hit_points_max and user_pool1/2_max attributes (which, again, has a typo but only in the tooltip. Not sure how code works, but the issues could be tied to the typos since it popped up in both locations I noticed). Weirdly, the Max HP attribute is calculated correctly for the purposes of Token display when using hit_points as the tied attribute. It is only when being referenced from Macros that the default value of 10 is returned instead. Specifically for the Max HP attribute, I thought I'd mention a workaround for others who want to reference it in a macro: You can simply reference "hp_verge" instead and multiply it by (-1). HP Verge is when a character is at negative max hp and has to start rolling death saves. hp_verge returns the correct negative of max_hp Finally, Roll abilities from repeating tables seem to be found by the Macro system, as referencing them as abilities does not throw an error, but they do not execute the command. For example, using "%{[character_name]|repeating_skills_$0_skillroll}" seems to process, and Roll20 doesn't complain that the ability doesn't exist, but it doesn't execute the first skill's skill roll the way the dice button would. If possible, adjusting this would be very useful for custom macro purposes. I think this might be a result of the same issue, as if the initial, default value of these abilities is null, then Roll20 might be doing nothing when these abilities are called because it's returning their default value instead of their current value. 3) The Custom Pools don't seem to have their Max and Current values synced up properly, in that they cannot be set as Token attributes. (Well, user_pool1 and user_pool2 can be set, but they only show the current value, it doesn't fill in the Max with the max field.) And with that done, I'd like to just add a single wishlist item: I think it would be handy if the Ranged weapons repeating lines had an extra field next to shots for loaded. As is, things can get pretty crowded in that field for firearms, since most of them include a +1, and the reload speed goes into the same field, so for a simple pistol the Shots field usually looks like "12+1/12+1 (3)" which is pretty cramped. In fact, in practice writing just so much as 12+1/12+1 already cuts off the second +1. For the ease of keeping track of shot bullets, I think it would be nice to have that separate field for what's actually in the gun at the moment, so players don't need to be careful adjusting their available ammo. Increasing the width would also work, though I'm personally a fan of having them be separate fields so people can make custom macros referncing these things. Alternatively, it might make sense to instead create a collumn for the reload speed specifically, as that would also leave more room for ammo to be displayed, though like I said, 12+1/12+1 is already too much for the current size of the Shots collumn. Oh and one minor recommendation: Currently the Inventory complains if one enters in a decimal value with more than 3 digits past the decimal point for weight on an item, but still seems to calculate them correctly. If this is something done by the sheet, and not a Roll20 default, I think it would make sense to increase the allowance, as some entries in GURPS books (such as certain Ammo in High Tech) can go up to 4 digits. Thanks Spriteanon for looking into the Character Sheet and the source code! Fixed In ACC's tooltip from Combat/Ranged refers to Aim as B354, changed to B364. - pull request will be made on Sept. 2nd, hopefully merged on Sept. 3rd. Macro Toolips max is a special naming scheme used by Roll20. There should be a normal input, like "hit_points", then there's another input that has max appended to it, "hit_points_max". The former input represents the current hit points while the second one is used for the max value. If "hit_points" is assigned to a token attribute, the maximum is automatically pulled from "hit_points_max". You shouldn't get any syntax errors. Here's some code and screenshots showing that max is working correctly. Based on Roll20 instructions, the macro should look like this " /roll 1d20 + @{Guard | Intelligence | max}" see "max" macro ```macro /em current hit points: @{Artillery Mage|hit_points} /em max hit points: @{Artillery Mage|hit_points|max} ``` ```macro /em current pool 1: @{Artillery Mage|user_pool1} /em max pool 1: @{Artillery Mage|user_pool1|max} ``` ```macro /em current pool 2: @{Artillery Mage|user_pool2} /em max pool 2: @{Artillery Mage|user_pool2|max} ``` Team Effort The Team Effort section in Tools/General. Please refer to GURPS Basic Set Characters page 185, there's a callout box titled, "Team Efforts". See the attached screen shot. Simple hit location table Good catch! I never used this table before, except to add the macro tooltips, and it was created before Mike W and I started working on the sheet. The spelling bug is a little annoying, there are similar spelling issues, but you're correct, we're kind of stuck with it. Another good catch, the macro is returning wrong values for the DR fields. That's because the fields were named incorrectly, an input name can only end with "_max" if there's another input with the same name. There's no easy fix for this, which means macros for simple hit location table DRs are broken. I don't know what the original intention was, maybe there was going to be a field for the current DR value. Custom Pool and Token Assignment I didn't encounter any issues when trying to use user_pool1 with a token. Please see the screenshot. Ranged Table Shots field, yes this field needs revision! On hold for now, waiting for design direction documentation which is currently under construction. There is very little room to add new fields to the table and we're trying to come up with ideas. Inventory table. I don't see an error message when entering a weight with 4 decimal places. The subtotal does round down to three decimals, which was by design, and I know Mike W and another developer worked on how the rounding works. Do you just want the subtotal to be rounded to 4 decimal places? I can check with Mike W but it should be easy to do. Thanks! Ken
